Idomatic scala?

[Gabor Pihaj]

Hi Scala Users,

I'm working on a scala project for a while. It's a non-blocking client for the brickset.com's SOAP API.

The code is available on github: https://github.com/voidcontext/scala-brickset-client

And here's my question: how can I improve my code, to be more idiomatic scala code?

Thanks in advance,

Gabor

[Tim Harper]

Gabor,

Have you read through this? http://docs.scala-lang.org/style/naming-conventions.html

Some of my thoughts as I've read through your code:

• Returning Future[Success / Failure] is redundant, since Future already has a failure channel. If you want to transform a successful future to a failed one, you can do this:
• methodReturningFuture.flatMap { result => Future.failed(new Exception("Such failure!")) }
  
  
• It strikes me as odd to even use Options here: https://github.com/voidcontext/scala-brickset-client/blob/14b1372c6f64716743021c8f54aeaa7f95b919f6/src/main/scala/io/github/voidcontext/bricksetclient/client/BricksetClient.scala#L52
• Not saying it's wrong, maybe you have a good reason for it, but defaulting everything to Some("") looks weird. I'd just challenge it and try and make your method here default all parameters to None, instead; empty empty string is needed, then use orElse, IE
  userHash orElse Some("")

Keep up the great work!