Enumeration withName

[Kornel Kiełczewski]

Hi,

 it's a small detail yet might be useful. I find it annoying that a failed Enumeration#withName call tells me nothing about the argument supplied. What about a small change: 

   ...

   final def withName(s: String): Value = values.find(_.toString == s).getOrElse(

      throw new IllegalArgumentException(s"No value found for $s")

   ...

 If you think it makes sense, should I open an issue in the issue tracker and create a pull request from a new branch (as described in CONTRIBUTING.md)?

Cheers,

 Kornel

[Som Snytt]

I hope you open an issue.

I wouldn't quibble over which exception is thrown.

https://github.com/som-snytt/House-of-Mirrors-Fork/blob/master/src/main/scala/hom/Directions.scala#L50

--
You received this message because you are subscribed to the Google Groups "scala-internals" group.
To unsubscribe from this group and stop receiving emails from it, send an email to scala-interna...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Kornel Kiełczewski]

Done, the PR  is here: https://github.com/scala/scala/pull/4228

The Jira issue is here: https://issues.scala-lang.org/browse/INF-182

Regards,

 Kornel

[Kornel Kiełczewski]

Ok, fixed the jira - https://issues.scala-lang.org/browse/SI-9067.

The PR is here: https://github.com/scala/scala/pull/4229

All the best in the coming year :)

[Chris Howitt]

Shouldn't withName return an Option[Value]?   Doesn't seem very 'Scala' to throw an exception rather than ask the client to deal with Option. c.f. Map.get