ListBuffer.last is O(N)

[Chris Okasaki]

Given the representation of ListBuffer, it should be dead simple to retrieve the last element in constant time, but the current (inherited) implementation traverses the entire list.  I'm guessing this is merely an oversight, but is there some technical reason NOT to override the inherited method with the obvious constant-time implementation?  If it is just an oversight, I'm happy to provide a PR.

(Of course, removing the last element would be an entirely different matter, but just looking at the last element should be fine.)

-- Chris

[Rex Kerr]

AFAIK this is just an oversight, and a fix would be welcome.  Normal use cases don't involve requesting the last element of a `ListBuffer`, but those that do would benefit.

  --Rex

--
You received this message because you are subscribed to the Google Groups "scala-internals" group.
To unsubscribe from this group and stop receiving emails from it, send an email to scala-internals+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Simon Ochsenreither]

Chris filed this as https://issues.scala-lang.org/browse/SI-9906

Thanks!