database_cremona_ellcurve required to doctest sage/groups/generic.py

[Dima Pasechnik]

Many tests (with new gap-4.5 spkgs at #13211) in doctest sage/groups/generic.py fail if database_cremona_ellcurve, 

which is an optional package, is not installed.

I wonder why these tests are not marked as optional.

Should database_cremona_ellcurve be promoted to standard?

Dima

[Jeroen Demeyer]

On 2012-10-10 11:58, Dima Pasechnik wrote:
> Many tests (with new gap-4.5 spkgs at #13211) in doctest
> sage/groups/generic.py fail if database_cremona_ellcurve,
> which is an optional package, is not installed.
> I wonder why these tests are not marked as optional.

If these are tests introduced by #13211, then they should be marked
optional in that ticket.

[Dima Pasechnik]

no, these tests were always there. I have no idea why this started to play up.

 

[John Cremona]

This is very strange indeed.

Installing the optional database will certainly affect some elliptic
curve tests, and we have gradually eliminated the ones which are so
affected, or marked hem as optional. But as far as I no, there is no
place in the elliptic curve code where GAP is used.

Could you post one specific example of a failing test?

The optional spkg is 134M (and is steadily growing at the moment) so I
don't think that making it standard is sensible, even if it is the
first spkg I install every time a new Sage is released!

John

> --
> You received this message because you are subscribed to the Google Groups
> "sage-devel" group.
> To post to this group, send email to sage-...@googlegroups.com.
> To unsubscribe from this group, send email to
> sage-devel+...@googlegroups.com.
> Visit this group at http://groups.google.com/group/sage-devel?hl=en.
>
>

[Dima Pasechnik]

On Wednesday, 10 October 2012 18:53:03 UTC+8, John Cremona wrote:

This is very strange indeed.

Installing the optional database will certainly affect some elliptic
curve tests, and we have gradually eliminated the ones which are so
affected, or marked hem as optional.  But as far as I no, there is no
place in the elliptic curve code where GAP is used.

oops, it appears that I cannot reproduce this on a clean install.

Must be some weirdness coming from pre-existing installations, I 

don't have any other explanation.

 

Could you post one specific example of a failing test?

It looked as follows:

File "/usr/local/src/sage/sage-5.4.rc0/devel/sage/sage/groups/generic.py", line 253:

    sage: E=EllipticCurve('389a1')

Exception raised:

    Traceback (most recent call last):

      File "/usr/local/src/sage/sage-5.4.rc0/local/bin/ncadoctest.py", line 1231, in run_one_test

        self.run_one_example(test, example, filename, compileflags)

      File "/usr/local/src/sage/sage-5.4.rc0/local/bin/sagedoctest.py", line 38, in run_one_example

        OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)

      File "/usr/local/src/sage/sage-5.4.rc0/local/bin/ncadoctest.py", line 1172, in run_one_example

        compileflags, 1) in test.globs

      File "<doctest __main__.example_2[4]>", line 1, in <module>

        E=EllipticCurve('389a1')###line 253:

    sage: E=EllipticCurve('389a1')

      File "/usr/local/src/sage/sage-5.4.rc0/local/lib/python/site-packages/sage/schemes/elliptic_curves/constructor.py", line 345, in EllipticCurve

        return ell_rational_field.EllipticCurve_rational_field(x)

      File "/usr/local/src/sage/sage-5.4.rc0/local/lib/python/site-packages/sage/schemes/elliptic_curves/ell_rational_field.py", line 208, in __init__

        X = sage.databases.cremona.CremonaDatabase()[label]

      File "/usr/local/src/sage/sage-5.4.rc0/local/lib/python/site-packages/sage/databases/cremona.py", line 1569, in CremonaDatabase

        _db = LargeCremonaDatabase(name)

      File "/usr/local/src/sage/sage-5.4.rc0/local/lib/python/site-packages/sage/databases/cremona.py", line 1325, in __init__

        + 'not appear to be a valid SQL Cremona database.')

    RuntimeError: Database at /usr/local/src/sage/sage-5.4.rc0/local/share/cremona/cremona.db does not appear to be a valid SQL Cremona database.

**********************************************************************

File "/usr/local/src/sage/sage-5.4.rc0/devel/sage/sage/groups/generic.py", line 254:

    sage: P=E(-1,1)

Exception raised:

    Traceback (most recent call last):

      File "/usr/local/src/sage/sage-5.4.rc0/local/bin/ncadoctest.py", line 1231, in run_one_test

        self.run_one_example(test, example, filename, compileflags)

      File "/usr/local/src/sage/sage-5.4.rc0/local/bin/sagedoctest.py", line 38, in run_one_example

        OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)

      File "/usr/local/src/sage/sage-5.4.rc0/local/bin/ncadoctest.py", line 1172, in run_one_example

        compileflags, 1) in test.globs

      File "<doctest __main__.example_2[5]>", line 1, in <module>

        P=E(-Integer(1),Integer(1))###line 254:

    sage: P=E(-1,1)

    NameError: name 'E' is not defined

(just to prove I wasn't daydreaming :-))

 

Dima

[R. Andrew Ohana]

See trac.sagemath.org/12341, that patch needs to be rebased (SAGE_DATA -> SAGE_SHARE), but otherwise it should fix this issue.

--

Andrew