On 9 October 2015 at 10:00, John Cremona <
john.c...@gmail.com> wrote:
> On 9 October 2015 at 09:44, Nathann Cohen <
nathan...@gmail.com> wrote:
>>> Disclaimer -- I did not wrote that code and did not know it was there!
>>
>> Same here :-P
>>
>>> I agree that having this hidden away in graphs.py is not sensible, and
>>> having it in src/sage/schemes/elliptic_curves/ is more sensible.
>>>
>>> How shall we do this? Would it work to make that a separate ticket
>>> from anything else you are doing, Nathann?
>>
>> Yes of course. The refactoring ticket I opened will already be
>> sufficiently hard to review.
>>
>> How do you want to see it moved there? Should we keep the syntax
>> Graph(....,format="elliptic_curve_congruence") or would it be better
>> as some_object.graph()?
>
> I can do that independently, if it will not cause conflicts with your
> ongoing work.
>
> The function's argument is a list of objects (elliptic curves over Q)
> rather than one object, so it cannot be a method of some elliptic
> curve class but will have to be stand-alone. Still, it will be more
> visible than at present since it will at least appear in the reference
> manual in an elliptic curve page where people who might use it might
> actually see it!
>
> I will make a ticket for this now.