I want to encourage people to take a little time to look at these, because I think that many of them are either painfully easy to review, or in fact are not needing review at all.
Painfully easy: e.g. most (not all) of the documentation ones:
Good question! But if each Sage developer looked at just two "needs review" tickets to check whether they were actually "needs work" or "needs info", we'd be done with our campaign in just one day - wait, I mean we would have a better idea of the actual state of things. No one person has the expertise to know this for any given component, though of course anything that needs a rebase is obviously 'needs work' at least trivially.
Have fun!
- kcrisman
Bruno Grenet
unread,
Dec 19, 2014, 10:03:44 AM12/19/14
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Sign in to report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to sage-...@googlegroups.com
I've changed recently the status of a ticket to "needs review" since I
think it is not relevant anymore, and I wanted it to be closed. I now
guess it is not the right approach... What should I do in such a case?
For concreteness it is ticket #2907
(http://trac.sagemath.org/ticket/2907) that asks for a "content" method
for polynomials, which now exists (even if it has some issue, see #16613).
You do not have permission to delete messages in this group
Copy link
Report message
Sign in to report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to sage-...@googlegroups.com
On Friday, December 19, 2014 4:03:44 PM UTC+1, Bruno Grenet wrote:
I've changed recently the status of a ticket to "needs review" since I
think it is not relevant anymore, and I wanted it to be closed. I now
guess it is not the right approach... What should I do in such a case?
Put it to positive review and the status to won'tfix/...
Michael Orlitzky
unread,
Dec 22, 2014, 8:00:05 PM12/22/14
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Sign in to report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to sage-...@googlegroups.com
You can't move a ticket directly to "positive review" from "new" -- it
has to be "needs review" first. So either way, that's the first step.
But, "needs review" is fine. In that case, I'd mention that the feature
has already been implemented, and how to use it. Then a reviewer can
check that the implemented feature does in fact solve the problem
reported in the ticket, and if it does, mark it "positive review."