Pull Request Feedback

27 views

Skip to first unread message

Brian Malinconico

unread,

Dec 11, 2016, 9:03:57 PM12/11/16

to Ruby on Rails: Core

Hello All,

I wanted to reach out regarding a PR I opened about 20days ago (https://github.com/rails/rails/pull/27124). Since it was opened around the holidays I wanted to give it a bit more time before reaching out here, since the only feedback I have gotten was to re-assign it.

This PR expands the ActiveRecord::Relation calculation methods to take multiple argument eg: sum(:col1, :col2). If I get positive feedback on the feature, I'd like to flesh-out the specs a bit more.

Thanks,

Brian

Reply all

Reply to author

Forward

0 new messages