PR feedback

20 views

Skip to first unread message

Dillon Welch

unread,

Apr 18, 2018, 12:09:48 PM4/18/18

to Ruby on Rails: Core

I have two PRs needing feedback

https://github.com/rails/rails/pull/32326 - hasn't received any feedback

https://github.com/rails/rails/pull/32381 - received an initial round of feedback, from which I made changes. There were some outstanding items that I had questions on and the PR has not received a response since the initial review.