rbt 0.6 doesn't appear to handle git renames correctly

[Blair Barnett]

We're using the rbt 0.6 tools suite, and get the enclosed error when we do an rbt post.
I've attached the output of the "git diff --no-color ..." which as you can see, looks fine.

It appears that rbt can't figure out "git rename" stuff appropriately, or we're doing something wrong.

Can someone help with this?

Thanks!

-blair

P.S. this also doesn't appear to work with earlier post-review either.


[dsingleton@grumpy g1-new]$ rbt post -d  --tracking-branch=origin/g1-new
>>> RBTools 0.6
>>> Python 2.6.6 (r266:84292, Jan 22 2014, 09:42:36)
[GCC 4.4.7 20120313 (Red Hat 4.4.7-4)]
>>> Running on Linux-2.6.32-431.5.1.el6.x86_64-x86_64-with-centos-6.5-Final
>>> Home = /home/dsingleton
>>> Current directory = /home/dsingleton/Trees/sysfs/g1-new
>>> Checking for a Subversion repository...
>>> Running: svn info --non-interactive
>>> Command exited with rc 1: ['svn', 'info', '--non-interactive']
svn: '.' is not a working copy
---
>>> Checking for a Git repository...
>>> Running: git rev-parse --git-dir
>>> Running: git config core.bare
>>> Running: git rev-parse --show-toplevel
>>> Running: git symbolic-ref -q HEAD
>>> Running: git config --get branch.g1-new.merge
>>> Running: git config --get branch.g1-new.remote
>>> Running: git config --get remote.origin.url
>>> repository info: Path: git@gringotts:gs-g1p, Base path: , Supports changesets: False
>>> Running: git config --get reviewboard.url
>>> Making HTTP GET request to http://reviewboard/api/
>>> Making HTTP GET request to http://reviewboard/api/info/
>>> Running: git rev-parse refs/heads/g1-new
>>> Running: git merge-base 655e59720e26930c43cff04054be37532ca27fea origin/g1-new
>>> Running: git rev-parse 2ec2c9e9d717af48418c1d7d1cd8db6b5897a7d1
>>> Running: git status --porcelain --untracked-files=no
>>> Running: git diff --no-color --full-index --ignore-submodules --no-renames 2ec2c9e9d717af48418c1d7d1cd8db6b5897a7d1..655e59720e26930c43cff04054be37532ca27fea -M
>>> Running: git log --reverse --pretty=format:%s%n%n%b ^2ec2c9e9d717af48418c1d7d1cd8db6b5897a7d1 655e59720e26930c43cff04054be37532ca27fea
>>> Making HTTP GET request to http://reviewboard/api/review-requests/
>>> Making HTTP POST request to http://reviewboard/api/review-requests/
>>> Making HTTP GET request to http://reviewboard/api/review-requests/233/diffs/
>>> Making HTTP POST request to http://reviewboard/api/review-requests/233/diffs/
>>> Got API Error 207 (HTTP code 400): The file was not found in the repository
>>> Error data: {u'stat': u'fail', u'file': u'include/dev_layout_sysfs.h', u'err': {u'msg': u'The file was not found in the repository', u'code': 207}, u'revision': u''}
Traceback (most recent call last):
  File "/usr/bin/rbt", line 9, in <module>
    load_entry_point('RBTools==0.6', 'console_scripts', 'rbt')()
  File "/usr/lib/python2.6/site-packages/RBTools-0.6-py2.6.egg/rbtools/commands/main.py", line 134, in main
    command.run_from_argv([RB_MAIN, command_name] + args)
  File "/usr/lib/python2.6/site-packages/RBTools-0.6-py2.6.egg/rbtools/commands/__init__.py", line 422, in run_from_argv
    exit_code = self.main(*args) or 0
  File "/usr/lib/python2.6/site-packages/RBTools-0.6-py2.6.egg/rbtools/commands/post.py", line 769, in main
    submit_as=self.options.submit_as)
  File "/usr/lib/python2.6/site-packages/RBTools-0.6-py2.6.egg/rbtools/commands/post.py", line 545, in post_request
    raise CommandError('\n'.join(error_msg))
rbtools.commands.CommandError: Error uploading diff


The file was not found in the repository (HTTP 400, API Error 207)

Your review request still exists, but the diff is not attached.

[David Trowbridge]

What version of Review Board is this happening on?

-David

--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Blair Barnett]

Hi David,

Sorry, that I forgot to mention that we're running RB 1.7.21. This failure appears to be happening way before it gets to reviewboard, since it's the RBTools that fail to create a diff that can be uploaded to the site.

-blair

You received this message because you are subscribed to a topic in the Google Groups "reviewboard" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/reviewboard/l2psGM_1xy4/unsubscribe.
To unsubscribe from this group and all its topics, send an email to reviewboard...@googlegroups.com.