Upload Limit for Review Requests?

[Daniel Laird]

All,

I have a back up job running every night that ensures MYSQL Database and uploaded files are backed up.

I am having an issue where sometimes files are uploaded with incorrect permissions (even with umask and sticky bit set)

This means that the subsequent backup complains as file permissions are 0600 not 0644.

The odd thing is that the files that exhibit this behaviour are always in the region of 24MB in size.

Is there any upload limit for attachments in Reviewboard? (set in code and not in Apache)?

Currently we can limit diff size but it appears to not have a limit for Attachments.

Dan

[Christian Hammond]

Hi Daniel,

We don't have any sort of upload limit, as upload limits are a bit harder to handle for attachments due to the fact that we're streaming from the client to a destination (which may be on another service like S3), and that whole process is handled by Django and not us.

That's strange that some files would have different permissions. Is there any consistency between the file types?

Christian

--

---
You received this message because you are subscribed to the Google Groups "reviewboard-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-d...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--

-- 
Christian Hammond - chri...@beanbaginc.com
Review Board - https://www.reviewboard.org

Beanbag, Inc. - https://www.beanbaginc.com

[Ben Cooksley]

On Thu, Oct 1, 2015 at 7:57 AM, Christian Hammond
<chri...@beanbaginc.com> wrote:
> Hi Daniel,

Hi Christian,

>
> We don't have any sort of upload limit, as upload limits are a bit harder to
> handle for attachments due to the fact that we're streaming from the client
> to a destination (which may be on another service like S3), and that whole
> process is handled by Django and not us.
>
> That's strange that some files would have different permissions. Is there
> any consistency between the file types?

I've seen this on our install at KDE, but only once. In that case, the
file was a rather unremarkable image file - apart from the fact it was
quite large (20mb or so if I recall right). It was only noticed as we
got complaints the attachment could not be accessed (as Apache didn't
have permission to view the file - as we have Reviewboard running as a
separate user).

The person who uploaded the file reported that Reviewboard did act
rather odd when doing the upload, and our logs indicated a HTTP 500
error was returned as part of the upload request. Could the
thumbnailing process be failing to handle such a large file perhaps?
(that seems to be the stage it failed at)

I could probably fish the url to the original of that image out of
ticketing system if that would help.

Cheers,
Ben

[Christian Hammond]

Hi Ben,

It's possible, though thumbnailing should occur after the upload completes. Perhaps there's some weird race condition or something somewhere, though.

Can someone file a bug report about this, so we can track it?

Christia

--
Christian Hammond - chi...@chipx86.com

Review Board - https://www.reviewboard.org

Beanbag, Inc. - https://www.beanbaginc.com