default gitweb link is there even gitiles was installed after upgraded gerrit to 2.13-rc0

[Makson Lee]

no any gitweb configuration in gerrit.config, as you can see in the following figure, still a gitweb link there.

[David Pursehouse]

The documentation [1] doesn't say, but the default behaviour if no gitweb.type is specified is to assume the type is gitweb.

I don't think this default makes sense, particularly since if there is no gitweb config at all it sets the URL to "null", so I've uploaded a change [2] to make it so the default is "disabled" when the type is not set.

[1] https://gerrit-review.googlesource.com/Documentation/config-gerrit.html#gitweb.type

[2] https://gerrit-review.googlesource.com/#/c/85372/

On Mon, Sep 5, 2016 at 12:55 PM Makson Lee <cdle...@gmail.com> wrote:

no any gitweb configuration in gerrit.config, as you can see in the following figure, still a gitweb link there.

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Makson Lee]

On Monday, September 5, 2016 at 8:17:51 PM UTC+8, David Pursehouse wrote:

The documentation [1] doesn't say, but the default behaviour if no gitweb.type is specified is to assume the type is gitweb.

thanks, setting gitweb.type to disabled did make default gitweb link disappear :-)