Rant about in-lined CSS in Gerrit

[lucamilanesio]

Hi all,

following an animated discussion on Twitter (see [1]) I wanted to do a reality check of what is the current approach for CSS in-lining on PolyGerrit.

If I remember correctly, at the last Gerrit Summit 2015 when presenting PolyGerrit it was said (or written somewhere?) that one of the goals was to make easier CSS restyling / branding of the GUI. 

Are we still inlining CSS in PolyGerrit or are we relying on external CSS files?

Thanks for the feedback.

Luca.

[1] https://twitter.com/shellscape/status/697266700207722497

[Andrew Bonventre]

Polymer elements do not use inline styles of the type <a style="color:red;">. The CSS is defined within the element definition: https://gerrit.googlesource.com/gerrit/+/master/polygerrit-ui/app/elements/gr-message.html

In short, inlining styles is a non-issue since they won’t be permitted in PolyGerrit.

[Luca Milanesio]

What about a user trying to style the Polymer elements for branding purposes? Do we have to change the Polymer elements and recompile? Can we use an external alternative CSS instead of the Polymer element styles?

Luca.

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Andrew Bonventre]

Polymer’s support for styles/theming will support this use-case well — https://www.polymer-project.org/1.0/docs/devguide/styling.html#xscope-styling

[Markus Duft]

Hey,

Sorry to resurrect this thread :) Is there an example of how I could brand gerrit 2.14 (polymer) with custom colors, logo, etc.? I could not find any (easily digestable) information about this...

Cheers,

Markus

[Dave Borowitz]

It's not implemented in PG yet but is still on the roadmap. Follow along at https://bugs.chromium.org/p/gerrit/issues/detail?id=4026

--
--
To unsubscribe, email repo-discuss+unsubscribe@googlegroups.com

More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.

To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss+unsubscribe@googlegroups.com.

[Markus Duft]

Wehee, thanks :)