Plugin manager errors in Gerrit 2.15

Igor

unread,

Apr 2, 2018, 3:37:57 AM4/2/18

to Repo and Gerrit Discussion

Hi,

I upgraded today a test server to 2.15 without any errors. However all attempts to install plugins with plugin manager show failure:

[2018-04-02 09:20:03,087] [HTTP-66] WARN com.google.gerrit.server.plugins.PluginLoader : Plugin provides its own name: <reviewers>, use it instead of the input name: <reviewers.jar>

[2018-04-02 09:20:03,097] [HTTP-66] INFO com.google.gerrit.server.plugins.PluginLoader : Installed plugin reviewers

[2018-04-02 09:20:03,098] [HTTP-66] ERROR com.google.gerrit.httpd.restapi.RestApiServlet : Error in PUT /a/plugins/reviewers.jar

java.lang.IllegalStateException: READER

at org.eclipse.jetty.server.Request.getInputStream(Request.java:844)

at javax.servlet.ServletRequestWrapper.getInputStream(ServletRequestWrapper.java:138)

...

Although jar files are installed in plugins directory and plugins are marked as loaded after restart.

Also plugin-manager version displayed in gerrit web is v2.14-2-g1a2fc03, although I downloaded it from stable-2.15 build:

https://gerrit-ci.gerritforge.com/job/plugin-plugin-manager-bazel-master-stable-2.15/

Thanks,

Igor.

Luca Milanesio

unread,

Apr 2, 2018, 5:17:00 PM4/2/18

to Igor, Luca Milanesio, Repo and Gerrit Discussion

Hi Igor,

On 2 Apr 2018, at 08:37, Igor <igor.lit...@gmail.com> wrote:

Hi,

I upgraded today a test server to 2.15 without any errors. However all attempts to install plugins with plugin manager show failure:

[2018-04-02 09:20:03,087] [HTTP-66] WARN com.google.gerrit.server.plugins.PluginLoader : Plugin provides its own name: <reviewers>, use it instead of the input name: <reviewers.jar>
[2018-04-02 09:20:03,097] [HTTP-66] INFO com.google.gerrit.server.plugins.PluginLoader : Installed plugin reviewers

The plugin was installed based on the above line.

[2018-04-02 09:20:03,098] [HTTP-66] ERROR com.google.gerrit.httpd.restapi.RestApiServlet : Error in PUT /a/plugins/reviewers.jar
java.lang.IllegalStateException: READER
at org.eclipse.jetty.server.Request.getInputStream(Request.java:844)
at javax.servlet.ServletRequestWrapper.getInputStream(ServletRequestWrapper.java:138)
at javax.servlet.ServletRequestWrapper.getInputStream(ServletRequestWrapper.java:138)

Seems like this is a post-installation issue on the rest API I believe.

...

Although jar files are installed in plugins directory and plugins are marked as loaded after restart.

All good then :-)

Also plugin-manager version displayed in gerrit web is v2.14-2-g1a2fc03, although I downloaded it from stable-2.15 build:
https://gerrit-ci.gerritforge.com/job/plugin-plugin-manager-bazel-master-stable-2.15/

The plugin-manager shows 2.15 to me when downloaded from:

https://gerrit-ci.gerritforge.com/job/plugin-plugin-manager-bazel-master-stable-2.15/

You can see the version as well on here:

https://gerrit-ci.gerritforge.com/job/plugin-plugin-manager-bazel-master-stable-2.15/lastSuccessfulBuild/artifact/bazel-genfiles/plugins/plugin-manager/plugin-manager.jar-version/*view*/

Thanks,
Igor.

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Luca Milanesio

unread,

Apr 2, 2018, 5:41:17 PM4/2/18

to Igor, Luca Milanesio, Repo and Gerrit Discussion

On 2 Apr 2018, at 22:16, Luca Milanesio <Luca.Mi...@gmail.com> wrote:

Hi Igor,

On 2 Apr 2018, at 08:37, Igor <igor.lit...@gmail.com> wrote:

Hi,

I upgraded today a test server to 2.15 without any errors. However all attempts to install plugins with plugin manager show failure:

[2018-04-02 09:20:03,087] [HTTP-66] WARN com.google.gerrit.server.plugins.PluginLoader : Plugin provides its own name: <reviewers>, use it instead of the input name: <reviewers.jar>
[2018-04-02 09:20:03,097] [HTTP-66] INFO com.google.gerrit.server.plugins.PluginLoader : Installed plugin reviewers

The plugin was installed based on the above line.

[2018-04-02 09:20:03,098] [HTTP-66] ERROR com.google.gerrit.httpd.restapi.RestApiServlet : Error in PUT /a/plugins/reviewers.jar
java.lang.IllegalStateException: READER
at org.eclipse.jetty.server.Request.getInputStream(Request.java:844)
at javax.servlet.ServletRequestWrapper.getInputStream(ServletRequestWrapper.java:138)
at javax.servlet.ServletRequestWrapper.getInputStream(ServletRequestWrapper.java:138)

Seems like this is a post-installation issue on the rest API I believe.

This is a regression in Gerrit v2.15: broken by https://gerrit-review.googlesource.com/c/gerrit/+/100332/

I have raised a new issue:

https://bugs.chromium.org/p/gerrit/issues/detail?id=8677

And reverted the offending change:

https://gerrit-review.googlesource.com/c/gerrit/+/169490

Igor

unread,

Apr 3, 2018, 1:42:27 AM4/3/18

to Repo and Gerrit Discussion

Hi Luca,

thanks for the info. Apart from this issue plugins installed with plugin-manager seem to be installed correctly. Found some other issues in the upgraded server not related to this, will open new threads if I can't resolve them.