ls -al ../../apps/gerrit/index/changes_0032/open
total 8
drwxr-xr-x 4 jcentkowski staff 136 Dec 22 17:48 .
drwxr-xr-x 4 jcentkowski staff 136 Dec 22 17:43 ..
-rw-r--r-- 1 jcentkowski staff 71 Dec 22 17:48 segments_1
-rw-r--r-- 1 jcentkowski staff 0 Dec 22 17:43 write.lock
ls -al ../../apps/gerrit/index/changes_0032/open
total 40
drwxr-xr-x 7 jcentkowski staff 238 Dec 22 18:37 .
drwxr-xr-x 4 jcentkowski staff 136 Dec 22 17:43 ..
-rw-r--r-- 1 jcentkowski staff 363 Dec 22 18:37 _2.cfe
-rw-r--r-- 1 jcentkowski staff 6488 Dec 22 18:37 _2.cfs
-rw-r--r-- 1 jcentkowski staff 361 Dec 22 18:37 _2.si
-rw-r--r-- 1 jcentkowski staff 71 Dec 22 17:48 segments_1
-rw-r--r-- 1 jcentkowski staff 0 Dec 22 17:43 write.lock
ls -al ../../apps/gerrit/index/changes_0032/open
total 40
drwxr-xr-x 7 jcentkowski staff 238 Dec 22 18:37 .
drwxr-xr-x 4 jcentkowski staff 136 Dec 22 17:43 ..
-rw-r--r-- 1 jcentkowski staff 363 Dec 22 18:37 _2.cfe
-rw-r--r-- 1 jcentkowski staff 6488 Dec 22 18:37 _2.cfs
-rw-r--r-- 1 jcentkowski staff 361 Dec 22 18:37 _2.si
-rw-r--r-- 1 jcentkowski staff 71 Dec 22 17:48 segments_1
-rw-r--r-- 1 jcentkowski staff 0 Dec 22 17:43 write.lock
$ ../../apps/gerrit/bin/gerrit.sh start
Starting Gerrit Code Review: OK
ls -al ../../apps/gerrit/index/changes_0032/open
total 8
drwxr-xr-x 4 jcentkowski staff 136 Dec 22 18:38 .
drwxr-xr-x 4 jcentkowski staff 136 Dec 22 17:43 ..
-rw-r--r-- 1 jcentkowski staff 71 Dec 22 17:48 segments_1
-rw-r--r-- 1 jcentkowski staff 0 Dec 22 17:43 write.lock
--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en
---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
To unsubscribe, email repo-discuss+unsub...@googlegroups.com
To unsubscribe, email repo-discuss...@googlegroups.com
This would presumably reintroduce the bug fixed by the reverted change.
After this revert, does hitting ctrl+c leave changes unindexed again?
Look at the comments of that change: it seems that it was "very well know" as side-effect of this fix.Jonathan said:"This would presumably reintroduce the bug fixed by the reverted change.
After this revert, does hitting ctrl+c leave changes unindexed again?
"Worth asking then Jonathan and Hugo on their point of view?
Let's put in this way, they are both evils and both lead to an inconsistent index.1. On-line reindex: the first restart after an upgrade will make the index inconsistent2. Restart: every time you restart, your index is inconsistentso ...1. hurts once every 3 months2. hurts *every time*
I would say ... let's go for fixing 2. (restart) and then work hard to fix 1. without breaking 2. again :-)
On 30 Dec 2016, at 10:39, Remy Bohmer <li...@bohmer.net> wrote:Hi,Op 30 dec. 2016 00:45 schreef "Luca Milanesio" <luca.mi...@gmail.com>:Let's put in this way, they are both evils and both lead to an inconsistent index.1. On-line reindex: the first restart after an upgrade will make the index inconsistent2. Restart: every time you restart, your index is inconsistentso ...1. hurts once every 3 months2. hurts *every time*And... 1 has a workaround in the sense of offline reindex, but 2 does not have a workaround at all.
On 30 Dec 2016, at 10:39, Remy Bohmer <li...@bohmer.net> wrote:Hi,Op 30 dec. 2016 00:45 schreef "Luca Milanesio" <luca.mi...@gmail.com>:Let's put in this way, they are both evils and both lead to an inconsistent index.1. On-line reindex: the first restart after an upgrade will make the index inconsistent2. Restart: every time you restart, your index is inconsistentso ...1. hurts once every 3 months2. hurts *every time*And... 1 has a workaround in the sense of offline reindex, but 2 does not have a workaround at all.You need to put into Hugo's shoes ... off-line reindexing would take *days* for them, so it wasn't a workaround for them at all.
But I would agree that for the rest of the Community, it is a "good enough" workaround for a once-in-a-3-months problem.I would say ... let's go for fixing 2. (restart) and then work hard to fix 1. without breaking 2. again :-)I could not agree more :-)Kind regards,Remy
More info at http://groups.google.com/group/repo-discuss?hl=en
---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss+unsubscribe@googlegroups.com.
At the moment the close() is used during shutdown and at the end of on-line reindexing: let's split into two methods as a quick-fix?Luca.
More info at http://groups.google.com/group/repo-discuss?hl=en
---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
On 30 Dec 2016, at 11:44, Sven Selberg <sven.s...@axis.com> wrote:I might have misread the code and what I'm saying doesn't make sense but...
On 30 Dec 2016, at 11:44, Sven Selberg <sven.s...@axis.com> wrote:
I might have misread the code and what I'm saying doesn't make sense but...If they don't share the same ExecutorService you don't have to worry about the context, we have already separated the shared context.
To unsubscribe, email repo-discuss+unsubscribe@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en
---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss+unsubscribe@googlegroups.com.
To unsubscribe, email repo-discuss+unsubscribe@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en
---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss+unsubscribe@googlegroups.com.
--
--
To unsubscribe, email repo-discuss+unsubscribe@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en
---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss+unsubscribe@googlegroups.com.
GerritForge CI posted comments on this change.
Patch Set 1: Verified+1
Gerrit-CI Build: https://gerrit-ci.gerritforge.com/job/Gerrit-verifier-change/5050/console
Great work Luca, Thanks!
Sven Selberg
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en
---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en
---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.