Running buck build release return errors

thomasmu...@yahoo.com

unread,

Sep 17, 2016, 9:21:29 AM9/17/16

to Repo and Gerrit Discussion

When i run buck build release i get this error

|=> //plugins/hooks:hooks__plugin... 1.3s (running javac_jar[1.3s])

/home/paladox/gerrit/plugins/hooks/src/main/java/com/googlesource/gerrit/plugins/hooks/ReviewerAdded.java:24: error: com.googlesource.gerrit.plugins.hooks.ReviewerAdded is not abstract and does not override abstract method onReviewerAdded(com.google.gerrit.extensions.events.ReviewerAddedListener.Event) in com.google.gerrit.extensions.events.ReviewerAddedListener

class ReviewerAdded implements ReviewerAddedListener {

^

/home/paladox/gerrit/plugins/hooks/src/main/java/com/googlesource/gerrit/plugins/hooks/ReviewerAdded.java:37: error: cannot find symbol

for (AccountInfo reviewer: event.getReviewers()) {

^

symbol: method getReviewers()

location: variable event of type com.google.gerrit.extensions.events.ReviewerAddedListener.Event

/home/paladox/gerrit/plugins/hooks/src/main/java/com/googlesource/gerrit/plugins/hooks/ReviewerAdded.java:34: error: method does not override or implement a method from a supertype

@Override

^

Errors: 3. Warnings: 0.

This is on stable-2.13.

thomasmu...@yahoo.com

unread,

Sep 17, 2016, 2:02:56 PM9/17/16

to Repo and Gerrit Discussion

I filled the bug here https://bugs.chromium.org/p/gerrit/issues/detail?id=4576

David Ostrovsky

unread,

Sep 17, 2016, 3:57:57 PM9/17/16

to Repo and Gerrit Discussion

On Saturday, September 17, 2016 at 3:21:29 PM UTC+2, thomasmu...@yahoo.com wrote:

When i run buck build release i get this error

|=> //plugins/hooks:hooks__plugin... 1.3s (running javac_jar[1.3s])
/home/paladox/gerrit/plugins/hooks/src/main/java/com/googlesource/gerrit/plugins/hooks/ReviewerAdded.java:24: error: com.googlesource.gerrit.plugins.hooks.ReviewerAdded is not abstract and does not override abstract method onReviewerAdded(com.google.gerrit.extensions.events.ReviewerAddedListener.Event) in com.google.gerrit.extensions.events.ReviewerAddedListener
class ReviewerAdded implements ReviewerAddedListener {

That's because you are trying to build hooks plugin with this API change commit

from master: [1] against stable 2.13 branch. Just update the plugin submodules

and t would work. This is a common mistake and we've added this section: [2]

in dev-readme.txt.

Also note, that 2.13-rc1 was released a couple of days ago: [3], so that this is

lmost impossible, that this branch can't be built.

* [1] https://gerrit-review.googlesource.com/#/c/80052/2/src/main/java/com/googlesource/gerrit/plugins/hooks/ReviewerAdded.java@35

* [2] https://github.com/gerrit-review/gerrit/blob/master/Documentation/dev-readme.txt#L28-L41

* [3] https://groups.google.com/d/topic/repo-discuss/-mwM0dvJsa8/discussion

thomasmu...@yahoo.com

unread,

Sep 17, 2016, 4:44:01 PM9/17/16

to Repo and Gerrit Discussion

Oh thanks for your reply. But woulden the submodule commit for the submodule in gerrit choose what commit to use? Since i am using stable 2.13 branch for gerrit but then in plugins/hooks should it link to the commit that will work?

On Saturday, September 17, 2016 at 2:21:29 PM UTC+1, thomasmu...@yahoo.com wrote:

thomasmu...@yahoo.com

unread,

Sep 17, 2016, 4:57:31 PM9/17/16

to Repo and Gerrit Discussion

Hi fixed it here https://gerrit-review.googlesource.com/#/c/86207/

On Saturday, September 17, 2016 at 2:21:29 PM UTC+1, thomasmu...@yahoo.com wrote:

Reply all

Reply to author

Forward