[ANNOUNCE] Gerrit 2.15-rc0

[Dave Borowitz]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Gerrit version 2.15-rc0 is now available. This release candidate
contains a new UI, a new database backend, and many other exciting
features you'll want to read about. Please see the release notes for
details.

Release Notes:
https://www.gerritcodereview.com/releases/2.15.md

Documentation:
http://gerrit-documentation.storage.googleapis.com/Documentation/2.15/index.html

Download:
https://gerrit-releases.storage.googleapis.com/gerrit-2.15-rc0.war

SHA1:
fd00d26668b68774006bdbbb137ede29ebd651c7

SHA256:
df56b82612c81a766690c88d1d40cb35af0cc43be16b2516eb2e578ea5f1881e

MD5:
ef23ad836ee57a9997c64776e352b189

Maintainers' public keys:
https://www.gerritcodereview.com/releases/public-keys.md
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJZ0VeJAAoJEF/XxZqaEoiMO0MQAJ2yNGwOHpKfYTjJ+JbKUGuX
cEwxLG8qm6OTK9uaNOsrE0nf2fF5IuToIYyNgZSV3kDWxiUU1S+PHfV+3WOIyuix
aX1d8765W4ZdYgkgIimvDym4Qj9g77WmYkEj9WGhjMxUrGLfPG5AMxL+M4vZag9l
CsQzWbDCyxv97QJx8NEdwQTfl9Kg6dy1Onn5bqV53Lntkosj3BI1LTRBQptOaOEa
zYYZu50d1+2KSAFhGGanWtdsYzN1vVN7GY7xlBLqVgpAQFqgxxPHZOZiCLfptf8R
PbXGIvgbOcJ48bFWvhL/UjpLTbtuvqCh/pNmpSXaLmTXHeEVFT7nx9EpjevmqB+D
uQEONWqbv4Qr9nLaJJ0hMVQXiwz8lhmn1g/VvFW87VnME93UTfbcTPc+/LMk+GK3
ShJRjgJZEYdsQgqPvNZi/goXcjNyt5G88v3brM10BXd7O3pqoeUTabQUpZaM9ftB
XUXa26ASccnTA4In6kFozBjJuwIk/BNwJ0WGaCfWZy7sqwO8/YV21lbghdp3vAAQ
HWMFAZQCtOmUw8J+CHzMUmBC6Xn8sSHInOopOM1VxRAltGY06UrNy/w3ik0A3Hi2
L0lYlaSdT9bbXrH/HmZCGrtCJKg2zRMYXH/bir4mnYvBfxWSP3NG03Tw5TXLUwkE
jkBtUbzZybeaYIdd/USU
=0iky
-----END PGP SIGNATURE-----

[Makson Lee]

thanks for that, i have upgraded from 2.14.4, but got the following error when doing reindex,

$ java -jar gerrit-2.15-rc0.war reindex -d /srv/gerrit2

[2017-10-02 09:40:54,764] [main] INFO  com.google.gerrit.server.git.LocalDiskRepositoryManager : Defaulting core.streamFileThreshold to 444m

[2017-10-02 09:40:55,758] [main] INFO  com.google.gerrit.server.cache.h2.H2CacheFactory : Enabling disk cache /srv/gerrit2/cache

Collecting accounts:    6

Reindexing accounts:    100% (6/6)

Reindexed 6 documents in accounts index in 0.6s (10.0/s)

Reindexing groups:      100% (2/2)

Reindexed 2 documents in groups index in 0.1s (29.4/s)

Collecting projects:    579

Reindexing changes: projects: 32% (186/579), failed: 1[2017-10-02 09:40:58,769] [Index-Batch-3] WARN  com.google.gerrit.server.index.change.AllChangesIndexer : Failed to read change 1 for indexing

com.google.gwtorm.server.OrmException: java.io.IOException: Error loading refs/changes/01/1/meta in All-Projects at 46e4fa618a7dca293d214861757a11c35cbe6a6a

        at com.google.gerrit.server.notedb.AbstractChangeNotes.load(AbstractChangeNotes.java:170)

        at com.google.gerrit.server.notedb.ChangeNotes$Factory.toResult(ChangeNotes.java:389)

        at com.google.gerrit.server.notedb.ChangeNotes$Factory.scanOneNoteDbChange(ChangeNotes.java:382)

        at com.google.gerrit.server.notedb.ChangeNotes$Factory.lambda$scanNoteDb$4(ChangeNotes.java:342)

        at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193)

        at java.util.Iterator.forEachRemaining(Iterator.java:116)

        at java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801)

        at java.util.stream.Streams$ConcatSpliterator.forEachRemaining(Streams.java:742)

        at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)

        at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471)

        at java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151)

        at java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174)

        at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)

        at java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:418)

        at com.google.gerrit.server.index.change.AllChangesIndexer$ProjectIndexer.call(AllChangesIndexer.java:225)

        at com.google.gerrit.server.index.change.AllChangesIndexer$ProjectIndexer.call(AllChangesIndexer.java:199)

        at com.google.common.util.concurrent.TrustedListenableFutureTask$TrustedFutureInterruptibleTask.runInterruptibly(TrustedListenableFutureTask.java:111)

        at com.google.common.util.concurrent.InterruptibleTask.run(InterruptibleTask.java:58)

        at com.google.common.util.concurrent.TrustedListenableFutureTask.run(TrustedListenableFutureTask.java:75)

        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)

        at java.util.concurrent.FutureTask.run(FutureTask.java:266)

        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)

        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)

        at com.google.gerrit.server.git.WorkQueue$Task.run(WorkQueue.java:435)

        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)

        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)

        at java.lang.Thread.run(Thread.java:748)

Caused by: java.io.IOException: Error loading refs/changes/01/1/meta in All-Projects at 46e4fa618a7dca293d214861757a11c35cbe6a6a

        at com.google.gerrit.server.notedb.ChangeNotesCache.get(ChangeNotesCache.java:342)

        at com.google.gerrit.server.notedb.ChangeNotes.onLoad(ChangeNotes.java:710)

        at com.google.gerrit.server.notedb.AbstractChangeNotes.load(AbstractChangeNotes.java:164)

        ... 26 more

Caused by: java.util.concurrent.ExecutionException: org.eclipse.jgit.errors.ConfigInvalidException: Change 1: invalid Patch-set: 2 (draft)

        at com.google.common.util.concurrent.AbstractFuture.getDoneValue(AbstractFuture.java:503)

        at com.google.common.util.concurrent.AbstractFuture.get(AbstractFuture.java:462)

        at com.google.common.util.concurrent.AbstractFuture$TrustedFuture.get(AbstractFuture.java:79)

        at com.google.common.util.concurrent.Uninterruptibles.getUninterruptibly(Uninterruptibles.java:142)

        at com.google.common.cache.LocalCache$Segment.getAndRecordStats(LocalCache.java:2453)

        at com.google.common.cache.LocalCache$Segment.loadSync(LocalCache.java:2417)

        at com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2299)

        at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2212)

        at com.google.common.cache.LocalCache.get(LocalCache.java:4147)

        at com.google.common.cache.LocalCache$LocalManualCache.get(LocalCache.java:5053)

        at com.google.gerrit.server.notedb.ChangeNotesCache.get(ChangeNotesCache.java:338)

        ... 28 more

Caused by: org.eclipse.jgit.errors.ConfigInvalidException: Change 1: invalid Patch-set: 2 (draft)

        at com.google.gerrit.server.notedb.ChangeNotes.parseException(ChangeNotes.java:101)

        at com.google.gerrit.server.notedb.ChangeNotesParser.parseException(ChangeNotesParser.java:1156)

        at com.google.gerrit.server.notedb.ChangeNotesParser.invalidFooter(ChangeNotesParser.java:1145)

        at com.google.gerrit.server.notedb.ChangeNotesParser.parsePatchSetState(ChangeNotesParser.java:672)

        at com.google.gerrit.server.notedb.ChangeNotesParser.parse(ChangeNotesParser.java:339)

        at com.google.gerrit.server.notedb.ChangeNotesParser.parseAll(ChangeNotesParser.java:214)

        at com.google.gerrit.server.notedb.ChangeNotesCache$Loader.call(ChangeNotesCache.java:316)

        at com.google.gerrit.server.notedb.ChangeNotesCache$Loader.call(ChangeNotesCache.java:301)

        at com.google.common.cache.LocalCache$LocalManualCache$1.load(LocalCache.java:5058)

        at com.google.common.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3708)

        at com.google.common.cache.LocalCache$Segment.loadSync(LocalCache.java:2416)

        ... 33 more

Reindexing changes: projects: 100% (579/579), failed: 1, done

[2017-10-02 09:40:58,876] [main] ERROR com.google.gerrit.server.index.change.AllChangesIndexer : Failed 1/1 changes (100%); not marking new index as ready

Reindexed 1 documents in changes index in 0.2s (5.2/s)

[David Pursehouse]

Looks like there is a draft change that was not migrated?

 

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Makson Lee]

so how to migrate draft change to private change manually? i can't find the document.

[luca.mi...@gmail.com]

I believe we should migrate them during the schema upgrade (init). So possibly something missing or failed there?

Luca

Sent from my iPhone

[Makson Lee]

not sure, i did see the change migration during schema upgrade, but can't find any error related, then i re-ran the init again, this time, no migration was performing.

[Edwin Kempin]

I think this is because the migration that converts draft changes / draft patch sets to private / WIP changes only works for ReviewDb [1]. A migration for NoteDb was not implemented :(

[1] https://gerrit-review.googlesource.com/#/c/gerrit/+/97230/92/gerrit-server/src/main/java/com/google/gerrit/server/schema/Schema_159.java

--
--
To unsubscribe, email repo-discuss+unsubscribe@googlegroups.com

More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.

To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss+unsubscribe@googlegroups.com.

[Makson Lee]

yep, we were using notedb in 2.14.x :(, any chances to migrate the data manually?

[Dave Borowitz]

Sorry about the lack of a migration. The reason for getting this
change in 2.15 is that prior to 2.15 NoteDb was not "officially
supported", but we also don't want to screw over users who are helping
us out with early testing.

It shouldn't be too hard to manually migrate the data. You just have
to remove the " (draft)" anywhere that you see it, on any change it
complains about. The tricky part is you can't just use interactive
rebase, because you also need to preserve the committer.

I'll try to come up with a git-filter-branch invocation (if nobody
beats me to it).

[Edwin Kempin]

Am 02.10.2017 09:10 schrieb "Makson Lee" <cdle...@gmail.com>:

yep, we were using notedb in 2.14.x :(, any chances to migrate the data manually?

Definitely possible by rewriting the change meta branches, but I'm afraid that it's too much work to do this manually.

On the bright side I wrote a migration for this to do the conversion internally at Google. It only supports migration to private changes (not wip changes). I may try to pull that code out and put it into a pgm program so that you can run it.

--
--
To unsubscribe, email repo-discuss+unsubscribe@googlegroups.com

More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.

To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss+unsubscribe@googlegroups.com.

[Makson Lee]

On Monday, October 2, 2017 at 4:24:55 PM UTC+8, Edwin Kempin wrote:

Am 02.10.2017 09:10 schrieb "Makson Lee" <cdle...@gmail.com>:

yep, we were using notedb in 2.14.x :(, any chances to migrate the data manually?

Definitely possible by rewriting the change meta branches, but I'm afraid that it's too much work to do this manually.

On the bright side I wrote a migration for this to do the conversion internally at Google. It only supports migration to private changes (not wip changes). I may try to pull that code out and put it into a pgm program so that you can run it.

 

great, its okay to migrate to private changes only :)

[Edwin Kempin]

I have a WIP change for this [1] but it's not fully tested yet.

I'm out for a few days. If you have time to test it and provide feedback it would be great.

[1] https://gerrit-review.googlesource.com/c/gerrit/+/131211

[Makson Lee]

On Friday, October 6, 2017 at 10:51:01 PM UTC+8, Edwin Kempin wrote:

On Mon, Oct 2, 2017 at 10:29 AM, Makson Lee <cdle...@gmail.com> wrote:

On Monday, October 2, 2017 at 4:24:55 PM UTC+8, Edwin Kempin wrote:

Am 02.10.2017 09:10 schrieb "Makson Lee" <cdle...@gmail.com>:

yep, we were using notedb in 2.14.x :(, any chances to migrate the data manually?

Definitely possible by rewriting the change meta branches, but I'm afraid that it's too much work to do this manually.

On the bright side I wrote a migration for this to do the conversion internally at Google. It only supports migration to private changes (not wip changes). I may try to pull that code out and put it into a pgm program so that you can run it.

 

great, its okay to migrate to private changes only :)

I have a WIP change for this [1] but it's not fully tested yet.

I'm out for a few days. If you have time to test it and provide feedback it would be great.

[1] https://gerrit-review.googlesource.com/c/gerrit/+/131211

sure, i will test it later and update you the result. 

[Makson Lee]

great, it works, i tried the following command on the test environment,

$ java -jar release.war MigrateDraftChangesForNoteDb output.txt -d /srv/gerrit2

[2017-10-07 00:30:25,073] [main] INFO  com.google.gerrit.server.git.LocalDiskRepositoryManager : Defaulting core.streamFileThreshold to 1340m

Migrate draft changes and changes with draft patch sets: 100% (581/581)

and then started the gerrit instance, here is what we have in log file, schema has been migrated successfully, thanks again :)

[2017-10-07 00:31:17,630] [Reindex changes v39-v48] INFO  com.google.gerrit.server.index.OnlineReindexer : Starting online reindex of changes from schema version 39 to 48

[2017-10-07 00:31:17,794] [main] INFO  com.google.gerrit.sshd.SshDaemon : Started Gerrit SSHD-CORE-1.6.0 on *:29418

[2017-10-07 00:31:17,798] [main] INFO  org.eclipse.jetty.server.Server : jetty-9.3.18.v20170406

[2017-10-07 00:31:18,416] [main] INFO  com.googlesource.gerrit.plugins.gitiles.HttpModule : No /srv/gerrit2/etc/gitiles.config; assuming defaults

[2017-10-07 00:31:19,198] [main] INFO  org.eclipse.jetty.server.handler.ContextHandler : Started o.e.j.s.ServletContextHandler@9af2a00{/,null,AVAILABLE}

[2017-10-07 00:31:19,219] [main] INFO  org.eclipse.jetty.server.AbstractConnector : Started ServerConnector@10ac5a14{HTTP/1.1,[http/1.1]}{0.0.0.0:8080}

[2017-10-07 00:31:19,227] [main] INFO  org.eclipse.jetty.server.Server : Started @18295ms

[2017-10-07 00:31:19,239] [main] INFO  com.google.gerrit.pgm.Daemon : Gerrit Code Review 2.15-rc0-70-g36e72eb4c2 ready

[2017-10-07 00:31:20,786] [Reindex changes v39-v48] INFO  com.google.gerrit.server.index.OnlineReindexer : Reindex changes to version 48 complete

[2017-10-07 00:31:20,786] [Reindex changes v39-v48] INFO  com.google.gerrit.server.index.OnlineReindexer : Using changes schema version 48