Cherry-Picking of LDAP Connection Leaking fix

[Claudio Pacchiega]

I noticed that our gerrit 2.9 server with LDAP authentication is eagerly leaking LDAP connections and threads, I investigated and see that this was a known bug fixed in 2.10 see [1]. I also verified that the problem is quite severe since it leaks one thread  with any LDAP authentication, and forcing us to restart quite often the gerrit server to reclaim resources.

We can't still update to 2.10 or later, and this is the only big problem we met with  stable 2.9, thus  I cherry-picked this change [2] 

 so that we can keep in using it without additional problems.

Can this be merged by someone on the stable 2.9?

[1] https://gerrit-review.googlesource.com/#/c/63080/1

[2] https://gerrit-review.googlesource.com/#/c/78730/

Thanks,

Claudio

[David Pursehouse]

On Sat, Jun 11, 2016 at 7:47 AM Claudio Pacchiega <claudio....@gmail.com> wrote:

I noticed that our gerrit 2.9 server with LDAP authentication is eagerly leaking LDAP connections and threads, I investigated and see that this was a known bug fixed in 2.10 see [1]. I also verified that the problem is quite severe since it leaks one thread  with any LDAP authentication, and forcing us to restart quite often the gerrit server to reclaim resources.

We can't still update to 2.10 or later, and this is the only big problem we met with  stable 2.9, thus  I cherry-picked this change [2] 

 so that we can keep in using it without additional problems.

Can this be merged by someone on the stable 2.9?

Is there are reason you need it to be merged?  Can't you just build your deployment with that cherry-picked fix.

It can of course be merged, but I don't think anyone is interested in making a new release off the stable-2.9 branch.

[luca.mi...@gmail.com]

Lots of changes were merged as well on stable-2.7 after the release. Would just make it easier to have a CI build on gerrit-ci.

Should be harmless anyway :-)

Luca

Sent from my iPhone

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.