The message log, adding/removing reviewers, and consolidation

[Andrew Bonventre]

This proposal comes in a two parts:

+ Add the ability to edit reviewers of a change in the reply dialog.

+ Include reviewer additions/removals in the message log.

The first is a workflow optimization as many users have expressed the desire to edit the metadata of a change while also being able to comment on it. With the addition of the CC field coming soon (already implemented in NoteDB), this will reduce even more clicks. It will not lead to the removal of the ‘Add reviewer’ button in the UI.

The second has been requested as both a usability and auditing mechanism. Many first-time users don’t know what happens when they add a reviewer even though an email has been sent. This has caused a lot of confusion since the message log reflects all other messages sent over email.

With the addition of tags (https://gerrit-review.googlesource.com/75803/), the ability to filter out machine comments will allow these new messages to be elided in the UI. Additionally, if the ability to edit reviewers/CC is within the reply dialog will reduce the number of emails sent by Gerrit.

Are there any objections to this?

[Matthias Sohn]

I like both these proposals 

-Matthias

[Edwin Kempin]

+1

 

-Matthias

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Zaro]

On Tue, Apr 5, 2016 at 5:18 AM, Andrew Bonventre <andy...@chromium.org> wrote:
> This proposal comes in a two parts:
> + Add the ability to edit reviewers of a change in the reply dialog.
> + Include reviewer additions/removals in the message log.
>
> The first is a workflow optimization as many users have expressed the desire
> to edit the metadata of a change while also being able to comment on it.
> With the addition of the CC field coming soon (already implemented in
> NoteDB), this will reduce even more clicks. It will not lead to the removal
> of the ‘Add reviewer’ button in the UI.

Like this idea in general but I was just wondering if 'editing' means
anything other than add/remove reviewer? Also are you proposing to
add any other metadata besides reviewers to reply dialog?

>
> The second has been requested as both a usability and auditing mechanism.
> Many first-time users don’t know what happens when they add a reviewer even
> though an email has been sent. This has caused a lot of confusion since the
> message log reflects all other messages sent over email.
>

+1 here, i had alway wondered why there was no message for these
actions. I didn't think it was a big deal until now :)

> With the addition of tags (https://gerrit-review.googlesource.com/75803/),
> the ability to filter out machine comments will allow these new messages to
> be elided in the UI. Additionally, if the ability to edit reviewers/CC is
> within the reply dialog will reduce the number of emails sent by Gerrit.
>
> Are there any objections to this?
>

[Andrew Bonventre]

On Tue, Apr 5, 2016 at 12:35 PM Zaro <zaro...@gmail.com> wrote:

On Tue, Apr 5, 2016 at 5:18 AM, Andrew Bonventre <andy...@chromium.org> wrote:
> This proposal comes in a two parts:
> + Add the ability to edit reviewers of a change in the reply dialog.
> + Include reviewer additions/removals in the message log.
>
> The first is a workflow optimization as many users have expressed the desire
> to edit the metadata of a change while also being able to comment on it.
> With the addition of the CC field coming soon (already implemented in
> NoteDB), this will reduce even more clicks. It will not lead to the removal
> of the ‘Add reviewer’ button in the UI.

Like this idea in general but I was just wondering if 'editing' means
anything other than add/remove reviewer?  Also are you proposing to
add any other metadata besides reviewers to reply dialog?

At the moment, no.