Re: Can't install replication plugin in gerrit-2.5-rc0 when using J2EE container (Jetty 8)

301 views
Skip to first unread message

Shawn Pearce

unread,
Sep 30, 2012, 10:40:24 PM9/30/12
to Rajin Gill, repo-discuss
On Sun, Sep 16, 2012 at 11:38 PM, Rajin Gill <raj...@gmail.com> wrote:
> When I try to issue the "ssh -p 29418 user@host gerrit plugin install --name
> replication - < replication.jar" I get the following error in the jetty
> logs. Everything works fine using the embedded jetty server. Would there be
> something wrong with my jetty8 configuration or is it something else? I have
> no specific reason to run in jetty8 other than learning how it works.
>
> 2012-09-16 21:37:53.938:INFO:oejsh.ContextHandler:started
> o.e.j.w.WebAppContext{/gerrit,file:/var/cache/jetty8/data/jetty--8080-gerrit.war-_gerrit-any-/webapp/},/usr/share/jetty8/webapps-plus/gerrit.war
> 2012-09-16 21:37:53.938:INFO:oejsh.ContextHandler:started
> o.e.j.w.WebAppContext{/gerrit,file:/var/cache/jetty8/data/jetty--8080-gerrit.war-_gerrit-any-/webapp/},/usr/share/jetty8/webapps-plus/gerrit.war
> [2012-09-16 21:37:56,092] INFO
> com.google.gerrit.server.cache.h2.H2CacheFactory : Enabling disk cache
> /srv/jetty8/gerrit2/cache
> [2012-09-16 21:38:01,288] INFO
> com.google.gerrit.server.plugins.PluginLoader : Loading plugins from
> /srv/jetty8/gerrit2/plugins
> [2012-09-16 21:38:01,352] WARN
> com.google.gerrit.server.plugins.PluginLoader : Cannot load plugin
> replication
> com.google.inject.CreationException: Guice creation errors:
>
> 1) A binding to java.io.File annotated with interface
> com.google.gerrit.server.config.SitePath was already configured at
> com.google.gerrit.server.plugins.CopyConfigModule.getSitePath().

There is a difference in the way Guice is configured between the
internal Jetty, and running Gerrit as a WAR in a standard J2EE
container. Looks like the latter case is not well tested and was
broken when plugin support was added. This should probably be fixed
before 2.5 ships, because many users do run Gerrit in the WAR
environment.

Saša Živkov

unread,
Oct 1, 2012, 4:36:10 PM10/1/12
to Shawn Pearce, Rajin Gill, repo-discuss
I tried fixing it:

Starting Gerrit in GWT Debug mode works with that change.

Saša
 

Reply all
Reply to author
Forward
0 new messages