Does gerrit use interdiff between patchset?

[Ping Yin]

I upload a topic with 3 commit for review, got 3 pactchset A1, B1, C1

then i add a few lines in A1, do a rebase and re upload, now got new
patchset A2, B2, C2

What i expected is A1..A2 with added lines, and the should be no
change in B1..B2 and C1..C2

But what i saw is the added lines appear in A1..A2, B1..B2 and C1..C2

So gerrit diff between patchset is diff between snapshot, not interdiff?





Ping Yin

[Ping Yin]

Ping Yin

On Tue, Apr 15, 2014 at 6:36 PM, Ping Yin <pkuf...@gmail.com> wrote:
> I upload a topic with 3 commit for review, got 3 pactchset A1, B1, C1
>
> then i add a few lines in A1, do a rebase and re upload, now got new
> patchset A2, B2, C2
>
> What i expected is A1..A2 with added lines, and the should be no
> change in B1..B2 and C1..C2

s/the should be/there should be/g

[Edwin Kempin]

Yes, Gerrit compares the two commits of the patches with each other and Gerrit isn't able to filter out diffs which come from a rebase.

 

Ping Yin

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Gustavo Leite de Mendonça Chaves]

2014-04-15 8:03 GMT-03:00 Edwin Kempin <edwin....@gmail.com>:

2014-04-15 12:36 GMT+02:00 Ping Yin <pkuf...@gmail.com>:

So gerrit diff between patchset is diff between snapshot, not interdiff?

Yes, Gerrit compares the two commits of the patches with each other and Gerrit isn't able to filter out diffs which come from a rebase.

IMHO it shouldn't be able to. But it should provide a clear way to show when a rebase has been made. I made a suggestion a while ago about this: https://groups.google.com/forum/#!msg/repo-discuss/jCFPnrIIdLI/vczDFrdspdcJ. Unfortunately, I don't do Java to try it myself. ;-(

--

Gustavo 

[Ping Yin]

Thanks, i have found the link and corresponding issue from google by myself :)