Follow-up buttion is not visible in the chagne screen after merge in gerrit

[kamal gumparthi]

Hi,

"Follow-up" button is visible in gerrit change screen before "merge" status but not visible after merge in gerrit UI.

How can i configure this option in gerrit 2.11.5 version.

 Required to see this option after merger.

Regars,

Sharma

[Matthew Webber]

This is not something I know much about, but since no-one else has responded:

(1) 2.11.5 is a fairly old release, and with a release that old, it's unlikely that anyone is going to be interested in spending any time looking at it. Consider updating to a newer version and seeing if your problem is still there.

(2) I personally don't understand your question. You are more likely to get a response if you describe step by step what you do, and what you want. But first, upgrade to a newer release.

Hope that helps

Matthew

[kamal gumparthi]

Hi Webber,

Thanks for the reply.

We have a plan to migrate to new gerrit version but takes time due to other issues.

At present we have this issue.

We post a “rework” comment on commit which is already in Merged status.

Developers get an email from gerrit, but due to the big number of emails, they often miss this email and the rework is not done.

 

In the gerrit documention we found that there is a follow up button exactly for this case.

But on our gerrit the follow button is only visible in case the commit is not in Merged state.

Can we change this? It really would make sense that it is visible.

gerrit documention:

https://gerrit-review.googlesource.com/Documentation/user-inline-edit.html

By clicking the 'Follow-Up' button on the change screen, to create a new change based on the selected change.

[Matthew Webber]

It looks like the behaviour is the same in 2.13.9, so my guess is that what you want to do is not supported.

If you want to do "Follow-up" for a change that has already been merged, why don't you just create a new change whose parent is the HEAD of the appropriate branch? You can start such a new in-line edit change, by clicking on the 'Create Change' button in the project screen, as shown in the documentation.

I don't understand why you want to base your new change on a point other than the current HEAD. If the reason is just that you want to indicate that the new change is related to the old change, then there are other and better ways to do that.

I hope that makes sense

Matthew

[David Ostrovsky]

Am Montag, 21. August 2017 13:58:16 UTC+2 schrieb Matthew Webber:

It looks like the behaviour is the same in 2.13.9, so my guess is that what you want to do is not supported.

If you want to do "Follow-up" for a change that has already been merged, why don't you just create a new change whose parent is the HEAD of the appropriate branch? You can start such a new in-line edit change, by clicking on the 'Create Change' button in the project screen, as shown in the documentation.

Yeah, we only render the Follow-Up button for open changes:

  if (ctl.getChange().getStatus().isOpen()) {

      UiAction.Description descr = new UiAction.Description();

      descr.setTitle("Create follow-up change");

      descr.setLabel("Follow-Up");

  [...]

[David Pursehouse]

On Mon, Aug 21, 2017 at 9:09 PM David Ostrovsky <david.o...@gmail.com> wrote:

Am Montag, 21. August 2017 13:58:16 UTC+2 schrieb Matthew Webber:

It looks like the behaviour is the same in 2.13.9, so my guess is that what you want to do is not supported.

If you want to do "Follow-up" for a change that has already been merged, why don't you just create a new change whose parent is the HEAD of the appropriate branch? You can start such a new in-line edit change, by clicking on the 'Create Change' button in the project screen, as shown in the documentation.

Yeah, we only render the Follow-Up button for open changes:

I don't think it's unreasonable to allow this also for merged changes.

https://gerrit-review.googlesource.com/#/c/gerrit/+/121390/

 

  if (ctl.getChange().getStatus().isOpen()) {

      UiAction.Description descr = new UiAction.Description();

      descr.setTitle("Create follow-up change");

      descr.setLabel("Follow-Up");

  [...]

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[kamal gumparthi]

Hi David,

Thanks for considering this requirement.

This is definitely a helpful one to most of the people to do followup on the merged change.

Thank you very much

Regards,

kamalakar