Fresh install from current master fails

[Björn Pedersen]

Trying to initialize a fresh instance with gerrit-master I get:

java -jar gerrit.war init -d ../gerritslave/
Exception in thread "main" java.io.IOException: Failure during plugin installation
    at com.google.gerrit.pgm.init.InitPlugins.listPlugins(InitPlugins.java:80)
    at com.google.gerrit.pgm.Init.run(Init.java:93)
    at com.google.gerrit.pgm.util.AbstractProgram.main(AbstractProgram.java:67)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:601)
    at com.google.gerrit.launcher.GerritLauncher.invokeProgram(GerritLauncher.java:168)
    at com.google.gerrit.launcher.GerritLauncher.mainImpl(GerritLauncher.java:92)
    at com.google.gerrit.launcher.GerritLauncher.main(GerritLauncher.java:50)
    at Main.main(Main.java:25)
Caused by: java.io.IOException: Datei oder Verzeichnis nicht gefunden
    at java.io.UnixFileSystem.createFileExclusively(Native Method)
    at java.io.File.createTempFile(File.java:1879)
    at com.google.gerrit.server.plugins.PluginLoader.asTemp(PluginLoader.java:175)
    at com.google.gerrit.server.plugins.PluginLoader.storeInTemp(PluginLoader.java:169)
    at com.google.gerrit.pgm.init.InitPlugins.listPlugins(InitPlugins.java:70)
    ... 10 more

strace shows it happens here:

[pid  4600] lstat64("/home/resi/pedersen/.gerritcodereview/tmp/gerrit_5055647002877439132_app", {st_mode=S_IFDIR|0700, st_size=4096, ...}) = 0
[pid  4600] lstat64("/home/resi/pedersen/.gerritcodereview/tmp/gerrit_5055647002877439132_app/slf4j-log4j12-1.6.1.jar", {st_mode=S_IFREG|0644, st_size=9753, ...}) = 0
[pid  4600] open("/home/resi/pedersen/tmp/gerrit/../gerritslave/tmp/plugin_reviewnotes_130726_0949_4435248649903746643.jar", O_RDWR|O_CREAT|O_EXCL|O_LARGEFILE, 0666) = -1 ENOENT (No such file or directory)

The problem does not occur during upgrading of an existing installation.

bisecting indicates that [3c22678e3f9595375e15f7abf5be1c55d9757814] Add '--install-plugin' option to init step
is the problematic commit.

Björn

[Björn Pedersen]

Manually creating the tmp dir in the new gerrit-site dir fixes the problem.

[Dariusz Luksza]

Hi Björn,

Thanks for pointing this out, this change should fix this bug:

https://gerrit-review.googlesource.com/48222

On Mon, Jul 29, 2013 at 2:53 PM, Björn Pedersen <ice...@googlemail.com> wrote:
>
>
> Manually creating the tmp dir in the new gerrit-site dir fixes the problem.
>

> --
> --
> To unsubscribe, email repo-discuss...@googlegroups.com
> More info at http://groups.google.com/group/repo-discuss?hl=en
>
> ---
> You received this message because you are subscribed to the Google Groups
> "Repo and Gerrit Discussion" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to repo-discuss...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>



--
Best regards

GSM: +49 017 445 41235
Blog: http://luksza.org
LinkedIn: http://www.linkedin.com/in/dariuszluksza

[Zu, Bruce]

Hi Dariusz

Is it intentional to keep same static class, variable, function with Plugin in JarPlugin?
Refe https://gerrit-review.googlesource.com/#/c/39270/5/gerrit-server/src/main/java/com/google/gerrit/server/plugins/JarPlugin.java

/B

[Dariusz Luksza]

That duplication wasn't intentional. Great catch Bruce. Will send
patch within minutes.

[Zu, Bruce]

I prepared one
https://gerrit-review.googlesource.com/#/c/48233/

sorry forget to mention it.
/B

[Dariusz Luksza]

I've just abandoned my change, since yours is cleaning more then mine ;)

[Zu, Bruce]

Thanks :)