Skip build when patchSet contains changes in comments

53 views
Skip to first unread message

Shosh

unread,
May 26, 2017, 1:15:39 AM5/26/17
to Repo and Gerrit Discussion
Hi,

Lets say I am currently in patchset number 1 and I just want to edit my file and add a comment to it.
Obviously it will create a new patchset but I don't want it to trigger new builds because the comment I added it not affecting the code.

How can I do that?
Thanks

Matthew Webber

unread,
May 26, 2017, 4:38:57 AM5/26/17
to Repo and Gerrit Discussion
How do you know that the code is not affected by your change? Maybe you made a typing error!

The purpose of verification builds is exactly that, to verify the change. I guess what you're asking for is a way for the change submitter to override the normal workflow, based on his/her knowledge of the change. That will depend on what mechanism you are using to trigger new builds - can you let us know that?

Shosh

unread,
May 27, 2017, 6:46:04 AM5/27/17
to Repo and Gerrit Discussion
Well, ,my assumption is that if the change included comments only, then I don't want to trigger a build.
I'm working with Jenkins. Jenkins has integration with Gerrit - once a patchset is created, it triggers a build in Jenkins. 

Shosh

unread,
Jun 15, 2017, 9:11:20 AM6/15/17
to Repo and Gerrit Discussion
Any suggestions? 

Edwin Kempin

unread,
Jun 16, 2017, 2:57:36 AM6/16/17
to Shosh, Repo and Gerrit Discussion


On Thu, Jun 15, 2017 at 3:11 PM, Shosh <shira...@gmail.com> wrote:
Any suggestions? 
Gerrit can't detect that a new patch set only changed comments, since it doesn't interpret file contents, e.g. Gerrit doesn't parse Java or C code. Hence Gerrit has no clue if a change touches a comment or code. If you can detect comment-only changes on Jenkins, Jenkins could just skip the build and re-apply the previous Verified vote.
 

--
--
To unsubscribe, email repo-discuss+unsubscribe@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Reply all
Reply to author
Forward
0 new messages