Click the button of "Projects -- List" and the results return take a few time!

[vista...@gmail.com]

Hi all:

       Something very strange is happening in my gerrit.

       Some accounts click the button of "Projects -- List" and "People -- List Groups"  and the results return take a few time about 5-10s,but 1-5s for other accounts.

What is the problem？

Thanks！

[vista...@gmail.com]

And the number of Git Projects : about 10000. 

[vista...@gmail.com]

There is a bug in  gerrit-server/src/main/java/com/google/gerrit/server/project/ListProjects.java

Any account click the button of "Projects -- List" and all of GitProjects in gerrit will be scaned one time which right permissions for the accounts.

[Jonathan Nieder]

What version of Gerrit are you using?

вс, 8 апр. 2018 г. в 10:21, <vista...@gmail.com>:

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[vista...@gmail.com]

gerrit version:2.13.7

[Luca Milanesio]

On 8 Apr 2018, at 18:21, vista...@gmail.com wrote:

There is a bug in  gerrit-server/src/main/java/com/google/gerrit/server/project/ListProjects.java

Any account click the button of "Projects -- List" and all of GitProjects in gerrit will be scaned one time which right permissions for the accounts.

If projects cache is full, the scanning of 10k in memory should take a small fraction of a second: 10s CPU time is *a lot* for scanning 10k objects in memory.

Can you check your cache configs (gerrit.config / [cache "<something>"]) ?

The default cache size is 1024 and, if you haven't customised anything about caching on your gerrit.config, it could be the reason why the scanning takes so long.

Luca.

On Sunday, April 8, 2018 at 11:37:18 PM UTC+8, vista...@gmail.com wrote:

And the number of Git Projects : about 10000. 

On Sunday, April 8, 2018 at 9:25:05 AM UTC+8, vista...@gmail.com wrote:

Hi all:

       Something very strange is happening in my gerrit.

       Some accounts click the button of "Projects -- List" and "People -- List Groups"  and the results return take a few time about 5-10s,but 1-5s for other accounts.

What is the problem？

Thanks！

[vista...@gmail.com]

And the number of Git Projects is about 10000

What can be configed for [cache "projects"] and now default cache size is 1024.

On Monday, April 9, 2018 at 3:10:03 PM UTC+8, lucamilanesio wrote:

On 8 Apr 2018, at 18:21, vista...@gmail.com wrote:

There is a bug in  gerrit-server/src/main/java/com/google/gerrit/server/project/ListProjects.java

Any account click the button of "Projects -- List" and all of GitProjects in gerrit will be scaned one time which right permissions for the accounts.

If projects cache is full, the scanning of 10k in memory should take a small fraction of a second: 10s CPU time is *a lot* for scanning 10k objects in memory.

Can you check your cache configs (gerrit.config / [cache "<something>"]) ?

The default cache size is 1024 and, if you haven't customised anything about caching on your gerrit.config, it could be the reason why the scanning takes so long.

Luca.

On Sunday, April 8, 2018 at 11:37:18 PM UTC+8, vista...@gmail.com wrote:

And the number of Git Projects : about 10000. 

On Sunday, April 8, 2018 at 9:25:05 AM UTC+8, vista...@gmail.com wrote:

Hi all:

       Something very strange is happening in my gerrit.

       Some accounts click the button of "Projects -- List" and "People -- List Groups"  and the results return take a few time about 5-10s,but 1-5s for other accounts.

What is the problem？

Thanks！

--
--

To unsubscribe, email repo-disc...@googlegroups.com

[Luca Milanesio]

If you have 1024 as projects cache ... whilst you have in reality 10k ... I am not surprised that is quite slow :-)

Just amend the value with a value that is over the maximum number of projects you have.

Luca.

To unsubscribe, email repo-discuss...@googlegroups.com

[vista...@gmail.com]

Thank you very much!

[vista...@gmail.com]

[cache "projects"]

        maxAge = 30s

        loadOnStartup = true

        memoryLimit = 20000

Also quite slow! :-(

The results of gerrit show-caches 

On Monday, April 9, 2018 at 5:00:26 PM UTC+8, lucamilanesio wrote:

[Matthias Sohn]

On Sat, Apr 14, 2018 at 10:21 AM, <vista...@gmail.com> wrote:

[cache "projects"]

        maxAge = 30s

        loadOnStartup = true

        memoryLimit = 20000

Also quite slow! :-(

 why do you expire entries in projects cached already after 30sec ?

This means Gerrit has to scan the file system for git repositories every

30 seconds to rediscover all the repositories under the folder at hand.

 

--
--
To unsubscribe, email repo-discuss+unsubscribe@googlegroups.com

More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.

To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss+unsubscribe@googlegroups.com.

[Remy Bohmer]

Hi,

The screenshot of show-caches still shows 1024 as cache size. After changing such settings you need to restart Gerrit.

Kind regards,

Remy

Op za 14 apr. 2018 10:21 schreef <vista...@gmail.com>:

To unsubscribe, email repo-discuss...@googlegroups.com

[vista...@gmail.com]

Hi,Matthias Sohn.

    This is for the new projects.

--
--
To unsubscribe, email repo-discuss...@googlegroups.com

[vista...@gmail.com]

Sorry,the screenshot is wrong,I upload the new one.

[Matthias Sohn]

 

On Sunday, April 15, 2018 at 7:44:30 AM UTC+8, Matthias Sohn wrote:

On Sat, Apr 14, 2018 at 10:21 AM, <vista...@gmail.com> wrote:

[cache "projects"]

        maxAge = 30s

        loadOnStartup = true

        memoryLimit = 20000

Also quite slow! :-(

 why do you expire entries in projects cached already after 30sec ?

This means Gerrit has to scan the file system for git repositories every

30 seconds to rediscover all the repositories under the folder at hand.

 

On Mon, Apr 16, 2018 at 1:14 AM, <vista...@gmail.com> wrote:

Hi,Matthias Sohn.

    This is for the new projects.

please avoid top posting on this list

ok, but documentation [1] says :

"Entries are removed from the cache and refreshed from source data every maxAge interval"

this means that if a project isn't used for 30 seconds it's evicted from the cache and if you need

if after 31 sec you'll have to wait for a new scan. Scans are expensive especially if your site

is large. We have set checkFrequency to "off".

Newly inserted projects should not require flushing the corresponding caches but should read

as soon they are read:

cache "projects"

Caches the project description records, from the projects table in the database. If a project record is updated or deleted, this cache should be flushed. Newly inserted projects do not require a cache flush, as they will be read upon first reference.

-Matthias

[1] https://gerrit-review.googlesource.com/Documentation/config-gerrit.html#cache.name.maxAge 

 

--
--
To unsubscribe, email repo-discuss+unsubscribe@googlegroups.com

More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.

To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss+unsubscribe@googlegroups.com.

[vista...@gmail.com]

Thank you very much!