Converting ChangeSubject from velocity to soy

[Orgad Shaneh]

Hi,

I want to convert the ChangeSubject.vm template from here to soy.

If I understand correctly, closure doesn't have local variables.

Can you suggest an alternative?

Thanks.

[thomasmu...@yahoo.com]

Hi, please see https://stackoverflow.com/questions/7039426/how-to-declare-local-variable-in-closure-javascript-template

Wikimedia have also converted one of it's mail templates to soy. See https://github.com/wikimedia/puppet/blob/production/modules/gerrit/files/etc/mail/ChangeSubject.soy

Though the template is pretty similar to gerrit's one.

[Orgad Shaneh]

Hi,

Ok, I did this: https://gist.github.com/orgads/93df7ca47b96eb328f3fc39624437174

and got the following error:

ChangeSubject.soy:28: error: Unknown data key 'messageClass'.

    {switch $messageClass}

     ^

1 error

at com.google.template.soy.SoyFileSet.throwIfErrorsPresent(SoyFileSet.java:1334)

at com.google.template.soy.SoyFileSet.compileForServerRendering(SoyFileSet.java:927)

at com.google.template.soy.SoyFileSet.compileToTofu(SoyFileSet.java:845)

...

Any ideas?

[thomasmu...@yahoo.com]

Im not sure how to use custom variables in soy in gerrit, just was pointing to an site that said it's possible. wyatt may know how to do this.

[Orgad Shaneh]

That's not where the error is. The soy engine claims that messageClass is undefined.

[thomasmu...@yahoo.com]

It should probably be

{let $subjectPrefix : $messageClass}
{switch $subjectPrefix}

[thomasmu...@yahoo.com]

See https://developers.google.com/closure/templates/docs/commands#let

[Orgad Shaneh]

I found that I don't need the variable at all. Ended up with https://gist.github.com/orgads/d8a61a1c10efeb7a4fafbcb6374167c3

Thanks for your help!