Re: log4j and slf4j in Google3

31 views
Skip to first unread message
Message has been deleted

Matthias Sohn

unread,
Jun 13, 2017, 11:49:55 AM6/13/17
to Alexandra Goultiaeva, gerritcodereview-team, Repo and Gerrit Discussion
On Tue, Jun 13, 2017 at 11:34 AM, 'Alexandra Goultiaeva' via Repo and Gerrit Discussion <repo-d...@googlegroups.com> wrote:
In cl/158712078 I'm trying to port a gerrit plugin base to google3, because we are developing an internal plugin that will rely on that code.


where is this change cl/158712078 ?
 
It seems that the test utilities for the plugin use log4j, while the google3 gerrit uses slf4j. If both are used, the tests are failing with "Could not find log message containing ...". I'm guessing it's logging to one system while trying to get the logs out of the other.

I've tried depending on "//third_party/java/log4j_over_slf4j" instead, hoping that it will re-route the log4j calls over slf4j. However, now the thing no longer compiles: it apparently uses methods of a class LoggingEvent, which are not implemented in log4j_over_slf4j

As I'm digging deeper into this, does someone have any experience and/or advice on how to approach it?

Thanks!
-Alexandra

--
--
To unsubscribe, email repo-discuss+unsubscribe@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Dave Borowitz

unread,
Jun 13, 2017, 12:02:01 PM6/13/17
to Alexandra Goultiaeva, gerritcodereview-team, repo-discuss, Matthias Sohn
bcc repo-discuss

Let's keep internal Google conversations off public mailing lists :)
Reply all
Reply to author
Forward
0 new messages