issue about adding permission on refs/heads/${username}/*

[Makson Lee]

a fresh new gerrit 2.14.3 install, here is the situation,

1. user xxx can code review +1 changes on refs/heads/xxx/test with default permission setting.

2. but if we add 'create reference' permission on refs/heads/${username}/*, then user xxx can't code review +1 on those changes anymore.

expected behavior?

[Makson Lee]

can anyone help to confirm if this happens to you too?

[Edwin Kempin]

This is unexpected. I tried this on master but couldn't reproduce this issue.

--
--
To unsubscribe, email repo-discuss+unsubscribe@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Makson Lee]

yep, i just tried it too, works fine on master branch, but doesn't on 2.13.x and 2.14.x branches.

On Monday, September 25, 2017 at 8:30:51 PM UTC+8, Edwin Kempin wrote:

This is unexpected. I tried this on master but couldn't reproduce this issue.

On Mon, Sep 25, 2017 at 11:33 AM, Makson Lee <cdle...@gmail.com> wrote:

can anyone help to confirm if this happens to you too?

On Thursday, September 21, 2017 at 9:38:01 PM UTC+8, Makson Lee wrote:

a fresh new gerrit 2.14.3 install, here is the situation,

1. user xxx can code review +1 changes on refs/heads/xxx/test with default permission setting.

2. but if we add 'create reference' permission on refs/heads/${username}/*, then user xxx can't code review +1 on those changes anymore.

expected behavior?

--
--
To unsubscribe, email repo-discuss...@googlegroups.com

More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.

To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.

[Edwin Kempin]

I think I can reproduce it on stable 2.14, let me have a closer look.

--
--
To unsubscribe, email repo-discuss+unsubscribe@googlegroups.com

More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.

To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss+unsubscribe@googlegroups.com.

[Makson Lee]

thanks.

[Edwin Kempin]

This problem was introduced with 2.13 by [1] and fixed by [2] which is only included in master.

[1] https://gerrit-review.googlesource.com/77077

[2] https://gerrit-review.googlesource.com/104331

[Edwin Kempin]

Cherry-picking the fix to the stable-2.13 branch:

  https://gerrit-review.googlesource.com/128890

--
--
To unsubscribe, email repo-discuss+unsubscribe@googlegroups.com

More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.

To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss+unsubscribe@googlegroups.com.

[Makson Lee]

great job.