[ANNOUNCE] Gerrit 2.15-rc1

[Dave Borowitz]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

A new release candidate Gerrit 2.15-rc1 is now available.

The following issues have been fixed since 2.15-rc0:

http://crbug.com/gerrit/7317: New refreshed UI with paper button is
not mobile optimised (PolyGerrit)
http://crbug.com/gerrit/7098: Broken Gitweb link above right pane in diff view
http://crbug.com/gerrit/5897: False positive warning in gitweb
http://crbug.com/gerrit/7333: Incorrect text "Move Change Commit
Message" (PolyGerrit)
http://crbug.com/gerrit/7277: Ctrl-F followed by Enter doesn't open
highlighted link (PolyGerrit)
http://crbug.com/gerrit/7336: Navigating related changes occasionally
doesn't work (PolyGerrit)
http://crbug.com/gerrit/7315: Creating a revert does not go to the
reverted change (PolyGerrit)
http://crbug.com/gerrit/7316: Cherry picking a change does not
redirect to that change (PolyGerrit)
http://crbug.com/gerrit/7357: Bad rounding: Updated 1 year, 12 months ago
http://crbug.com/gerrit/7340: Slave rejects any ssh traffic (both ssh
command and clone/fetch)
http://crbug.com/gerrit/7358: First user created during init is
effectively not an admin
http://crbug.com/gerrit/7334: Reviewer suggestion dropdown doesn't go
away (PolyGerrit)

For the full list of changes since 2.15-rc0, see:
https://gerrit.googlesource.com/gerrit/+log/v2.15-rc0..v2.15-rc1?no-merges

Download:
https://gerrit-releases.storage.googleapis.com/gerrit-2.15-rc0.war

SHA1:
0e6620fa64998f9abb3539e8b1ac313022fefa0a

SHA256:
005b76dd3aa09942aec908feffca06b16757adf60b03d49d3985cf69e07b5ec5

MD5:
e0b669937845a15988b3f12755bcf15c
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJZ2+iTAAoJEF/XxZqaEoiMyPcP/2f7oa6mWjMOyGO8KlA4FZDK
pUEp/rt2pPEq++6nBfb/w9OnErscPdwOgXt8qc6VeGq970m84pOEZYMDeuwh9Ph3
RM0rkZcy6eF2L/eaaPRhxFZoXnlon7gkfpMkLgnXE0/MnhCcuZ+ezKe6BdgdWpLw
sWByRWxxVPFxN7P+eElJ5adSzwUu0iG2iWiTDODAvEf8vTKdvKXjVDrV2d7pzaAv
IFzbJVz4LjScANXRiV6USfkITID7ZIyaTQqPj6g88fltgQn9HQkJ4gnoJ8mQlzWd
zYV8nLy4P9tu/29FC4ZRA/ICHmaR7tV+l95jtNEKqOOknHsBdpGFD6EaGpM69nCH
pritRj8wO05mtDlCnYUNvQdycpg4/qmmG+XoU12GYkj9vhsv5fLtiOqVwqpxFzJ9
oPQ1tt8hobOkawo4Nj1bRxw5EHHEeZyM1iozHnAJ0Wh6iLHEN0FKywcW3MRr3kgE
McCzlleTT02Ko4dN5NyfZqiMB5KyD1Q9O4FKxhBoyj89Ha9qgSyubU1enFciLadn
N1v0LsaLNuz7Wzf/vKyDpqfEkEpfmI17qfPX93QXkxhtmtiHso2dRK5D8BldXkGM
y6CvjOcUa8YrRlr5CC/Q63H6na1QVMxA0sdNuIa8B7cXe+nFxwg5/N94FBYYtI+2
X2hThfZIyirqIfLDHmeL
=7i7R
-----END PGP SIGNATURE-----

[James Hartig]

Great! Just switched from 2.14.4 to 2.15-rc1 and ran init and reindex. I assume that moved accounts to NoteDB but not changes. When I tried to mark a WIP change as ready using the "Start Review" button in the UI it errored:

Caused by: java.lang.NoClassDefFoundError: com/google/gerrit/server/events/DraftPublishedEvent

at com.criteo.gerrit.plugins.automerge.AutomaticMerger.onEvent(AutomaticMerger.java:75)

at com.google.gerrit.common.EventBroker.fireEventForUnrestrictedListeners(EventBroker.java:113)

at com.google.gerrit.common.EventBroker.fireEvent(EventBroker.java:124)

at com.google.gerrit.common.EventBroker.postEvent(EventBroker.java:92)

at com.google.gerrit.server.events.StreamEventsApiListener.onCommentAdded(StreamEventsApiListener.java:405)

at com.google.gerrit.server.extensions.events.CommentAdded.fire(CommentAdded.java:72)

at com.google.gerrit.server.change.PostReview$Op.postUpdate(PostReview.java:887)

at com.google.gerrit.server.update.ReviewDbBatchUpdate.executePostOps(ReviewDbBatchUpdate.java:852)

at com.google.gerrit.server.update.ReviewDbBatchUpdate.execute(ReviewDbBatchUpdate.java:300)

at com.google.gerrit.server.update.ReviewDbBatchUpdate.execute(ReviewDbBatchUpdate.java:361)

at com.google.gerrit.server.update.BatchUpdate.execute(BatchUpdate.java:283)

at com.google.gerrit.server.change.PostReview.apply(PostReview.java:365)

at com.google.gerrit.server.change.PostReview.applyImpl(PostReview.java:216)

at com.google.gerrit.server.change.PostReview.applyImpl(PostReview.java:139)

at com.google.gerrit.server.update.RetryingRestModifyView.lambda$apply$0(RetryingRestModifyView.java:30)

at com.google.gerrit.server.update.RetryHelper.lambda$execute$0(RetryHelper.java:169)

at com.github.rholder.retry.AttemptTimeLimiters$NoAttemptTimeLimit.call(AttemptTimeLimiters.java:78)

at com.github.rholder.retry.Retryer.call(Retryer.java:160)

It did actually mark it as ready when I refreshed. Looking at the stacktrace, I assume this is because autosubmitter plugin hasn't been updated yet for 2.15? Just thought I'd ask.

--
--
To unsubscribe, email repo-discuss+unsubscribe@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[James Hartig]

Additionally, when trying to create a branch (on new or existing projects), I get:

[remote rejected] master -> master (prohibited by Gerrit: create not permitted)

I didn't change any permissions between 2.14 and 2.15. Here are the relevant permissions:

[access "refs/heads/*"]

create = group Registered Users

[access "refs/heads/master"]

exclusiveGroupPermissions = create delete push

create = group Administrators

create = group Project Owners

I'm both the Administrator and Project Owner for this repo. I've tried reindexing and removing/re-adding myself from groups. The same error is returned when I try and create other branches besides master as well.

[Edwin Kempin]

On Tue, Oct 10, 2017 at 4:24 AM, James Hartig <faste...@gmail.com> wrote:

Great! Just switched from 2.14.4 to 2.15-rc1 and ran init and reindex. I assume that moved accounts to NoteDB but not changes. When I tried to mark a WIP change as ready using the "Start Review" button in the UI it errored:

Caused by: java.lang.NoClassDefFoundError: com/google/gerrit/server/events/DraftPublishedEvent

at com.criteo.gerrit.plugins.automerge.AutomaticMerger.onEvent(AutomaticMerger.java:75)

at com.google.gerrit.common.EventBroker.fireEventForUnrestrictedListeners(EventBroker.java:113)

at com.google.gerrit.common.EventBroker.fireEvent(EventBroker.java:124)

at com.google.gerrit.common.EventBroker.postEvent(EventBroker.java:92)

at com.google.gerrit.server.events.StreamEventsApiListener.onCommentAdded(StreamEventsApiListener.java:405)

at com.google.gerrit.server.extensions.events.CommentAdded.fire(CommentAdded.java:72)

at com.google.gerrit.server.change.PostReview$Op.postUpdate(PostReview.java:887)

at com.google.gerrit.server.update.ReviewDbBatchUpdate.executePostOps(ReviewDbBatchUpdate.java:852)

at com.google.gerrit.server.update.ReviewDbBatchUpdate.execute(ReviewDbBatchUpdate.java:300)

at com.google.gerrit.server.update.ReviewDbBatchUpdate.execute(ReviewDbBatchUpdate.java:361)

at com.google.gerrit.server.update.BatchUpdate.execute(BatchUpdate.java:283)

at com.google.gerrit.server.change.PostReview.apply(PostReview.java:365)

at com.google.gerrit.server.change.PostReview.applyImpl(PostReview.java:216)

at com.google.gerrit.server.change.PostReview.applyImpl(PostReview.java:139)

at com.google.gerrit.server.update.RetryingRestModifyView.lambda$apply$0(RetryingRestModifyView.java:30)

at com.google.gerrit.server.update.RetryHelper.lambda$execute$0(RetryHelper.java:169)

at com.github.rholder.retry.AttemptTimeLimiters$NoAttemptTimeLimit.call(AttemptTimeLimiters.java:78)

at com.github.rholder.retry.Retryer.call(Retryer.java:160)

It did actually mark it as ready when I refreshed. Looking at the stacktrace, I assume this is because autosubmitter plugin hasn't been updated yet for 2.15? Just thought I'd ask.

Yes, exactly. Support for draft changes has been removed with Gerrit 2.15 so there is no DraftPublishedEvent anymore. The plugin must be adapted to not depend on this class.

[Edwin Kempin]

On Tue, Oct 10, 2017 at 5:24 AM, James Hartig <faste...@gmail.com> wrote:

Additionally, when trying to create a branch (on new or existing projects), I get:

[remote rejected] master -> master (prohibited by Gerrit: create not permitted)

I didn't change any permissions between 2.14 and 2.15. Here are the relevant permissions:

[access "refs/heads/*"]

create = group Registered Users

[access "refs/heads/master"]

exclusiveGroupPermissions = create delete push

create = group Administrators

create = group Project Owners

I'm both the Administrator and Project Owner for this repo. I've tried reindexing and removing/re-adding myself from groups. The same error is returned when I try and create other branches besides master as well.

Likely your push is trying to create the branch on a new commit. In this case you need push permission on the branch for pushing the new commit to it. But then the error message would be confusing :/

[James Hartig]

I also have push on the branch:

[access "refs/heads/*"]

push = +force group Registered Users

[access "refs/heads/master"]

push = group Administrators

push = group Project Owners

If that's what you mean?

[Edwin Kempin]

On Tue, Oct 10, 2017 at 1:02 PM, James Hartig <faste...@gmail.com> wrote:

I also have push on the branch:

[access "refs/heads/*"]

push = +force group Registered Users

[access "refs/heads/master"]

push = group Administrators

push = group Project Owners

If that's what you mean?

Yes this is what I meant.

Hmm, not sure then. The error message seems to indicate a problem with the 'Create' permission. Maybe this permission is blocked on a parent project?

[James Hartig]

Is there anything that specifically changed with this with 2.15? The permissions haven't been changed at all since 2.14.

The permissions I shared were on All-Projects and the repo I'm trying to push to inherits directly from that project.

[Edwin Kempin]

On Tue, Oct 10, 2017 at 1:16 PM, James Hartig <faste...@gmail.com> wrote:

Is there anything that specifically changed with this with 2.15? The permissions haven't been changed at all since 2.14.

No, but there have been quite some refactorings in this area. 

It's hard to reproduce without knowing the full set of permissions of all involved projects. Can you share the complete picture and file this as a bug?

[thomasmu...@yahoo.com]

You need to upgrade automerger to the latest commit which you can download the plugin from https://gerrit-ci.gerritforge.com/job/plugin-automerger-bazel-master-master/

drafts code was removed in https://github.com/GerritCodeReview/plugins_automerger/commit/a3e57cd9f1508bca0ea2c30a7b56fae446583624

--
--
To unsubscribe, email repo-discuss...@googlegroups.com

More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.

To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.

[Makson Lee]

i think we are talking about this [1] plugin.

[1] https://gerrit.googlesource.com/plugins/autosubmitter/+/master/src/main/java/com/criteo/gerrit/plugins/automerge/AutomaticMerger.java#76

[thomasmu...@yahoo.com]

Oh i see thanks.

[James Hartig]

Yes, I was talking about the autosubmitter, though the folder names are confusing between the 2 plugins.

Additionally, I filed the bug about not being able to create any branches and attached our full config to the bug: https://bugs.chromium.org/p/gerrit/issues/detail?id=7385

--
--
To unsubscribe, email repo-discuss+unsubscribe@googlegroups.com

More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.

To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss+unsubscribe@googlegroups.com.

[thomasmu...@yahoo.com]

Fixed the plugin https://gerrit-review.googlesource.com/#/c/plugins/autosubmitter/+/131912/ (Untested but building it works).

[Adeodato Simó]

For the full list of changes since 2.15-rc0, see:
https://gerrit.googlesource.com/gerrit/+log/v2.15-rc0..v2.15-rc1?no-merges

Download:
https://gerrit-releases.storage.googleapis.com/gerrit-2.15-rc0.war

Quick note that there’s a typo here, and the link points to 2.15-r0.war, instead of rc1. 

SHA1:
0e6620fa64998f9abb3539e8b1ac313022fefa0a

The hashes seem correct for gerrit-2.15-rc1.war.

-d

[Dave Borowitz]

Thanks for the correction. The correct link is:
https://gerrit-releases.storage.googleapis.com/gerrit-2.15-rc1.war

This download should match the hashes in my original email.

--
--
To unsubscribe, email repo-discuss+unsubscribe@googlegroups.com

More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.

To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss+unsubscribe@googlegroups.com.

[James Hartig]

Thanks! I can confirm that your change works. Though instead of currentUser I tried getBotUser() for the submitRuleEvaluatorFactory.

Before 2.15, when autosubmitter merged a change it said "Autosubmitter merged this change". In 2.15 it now attributes the merge to the person who voted last (and caused the merge), instead of autosubmitter. Is that intended?

For example:

In 2.14: Brian adds Code-Review: +2, then autosubmitter merged this change, immediately after

In 2.15: Brian adds Code-Review: +2, then Brian merged this change, immediately after

The autosubmitter code looks like it's using getBotUser() in getRevisionResource() so I'm not sure if this is intended or a bug.

Thanks!

--
--
To unsubscribe, email repo-discuss+unsubscribe@googlegroups.com

More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.

To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss+unsubscribe@googlegroups.com.