Owners plugin

[Jungho Ahn]

Hello,

I'm trying to setup owners plugin with gerrit 2.14, but I couldn't find any doc on like how to config it.

I just copied owners.jar to plugins. Is there any doc on how to config it?

Thanks,

[Matthias Sohn]

usually the plugins have a config.md in the git repository:

https://gerrit.googlesource.com/plugins/owners/+/master/config.md 

[Jungho Ahn]

Thanks Matthias,

One thing that is unclear to me is whether I should add rules.pl for this to repos? Or is it automatically added?

And owners file supports username too in addition to full name or email? I think using username is more convenient than others. 

[Jungho Ahn]

I'm using username in OWNERS file and it seems to work.

But I saw this recent change: https://gerrit-review.googlesource.com/#/c/104996/1/owners-common/src/main/java/com/vmware/gerrit/owners/common/AccountsImpl.java

Does this mean we can only use email in OWNERS file?

[Luca Milanesio]

Hi Jungho,

it's a bug, I am fixing it now :-)

Luca.

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Jungho Ahn]

Thanks Luca!

After fixing it, can we use username?

On Fri, May 12, 2017 at 12:37 PM, Luca Milanesio <luca.mi...@gmail.com> wrote:

Hi Jungho,

it's a bug, I am fixing it now :-)

Luca.

On 12 May 2017, at 19:47, 'Jungho Ahn' via Repo and Gerrit Discussion <repo-d...@googlegroups.com> wrote:

I'm using username in OWNERS file and it seems to work.

But I saw this recent change: https://gerrit-review.googlesource.com/#/c/104996/1/owners-common/src/main/java/com/vmware/gerrit/owners/common/AccountsImpl.java

Does this mean we can only use email in OWNERS file?

On Friday, April 28, 2017 at 9:18:35 AM UTC-7, Jungho Ahn wrote:

Thanks Matthias,

One thing that is unclear to me is whether I should add rules.pl for this to repos? Or is it automatically added?

And owners file supports username too in addition to full name or email? I think using username is more convenient than others. 

On Thursday, April 27, 2017 at 2:32:59 PM UTC-7, Matthias Sohn wrote:

On Thu, Apr 27, 2017 at 4:43 AM, 'Jungho Ahn' via Repo and Gerrit Discussion <repo-d...@googlegroups.com> wrote:

Hello,

I'm trying to setup owners plugin with gerrit 2.14, but I couldn't find any doc on like how to config it.

I just copied owners.jar to plugins. Is there any doc on how to config it?

usually the plugins have a config.md in the git repository:

https://gerrit.googlesource.com/plugins/owners/+/master/config.md 

--
--
To unsubscribe, email repo-discuss+unsubscribe@googlegroups.com

More info at http://groups.google.com/group/repo-discuss?hl=en

---

You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.

To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--

Jungho

[Luca Milanesio]

Yes, that was the intention :-)