Gitiles plugin for Gerrit

[Dave Borowitz]

Following discussion at the Gerrit table at lunch at EclipseCon, I hacked together a quick Gitiles plugin for Gerrit: https://gerrit-review.googlesource.com/44024/

Drop the jar in your plugins directory (ok, actually building the jar is nontrivial since it depends on an unreleased plugin api jar :) and /plugins/gitiles will be a Gitiles interface configured to point back at the Gerrit instance. This includes both setting up URLs to point back at Gerrit and, more importantly, using Gerrit's access controls for listing repositories and refs.

This is not entirely working yet and is more of a proof of concept, just thought I'd throw it out there in case anyone is interested.

[Alex Blewitt]

This looks great - will play with it and see how well it works.

Alex

[Sundar Shankar]

I am trying to build gitiles and other plugins from sources like hook-jira so far no luck.  It would be great, if someone could point or post the built artifacts which is compatible for Gerrit version 2.6 and above?

-Sundar

[Dave Borowitz]

We haven't released a packaged gitiles plugin yet; I probably will do so once Gerrit 2.6 lands. To build now, the easiest thing to do is install the latest Gerrit 2.6 rc and change the Gerrit versions in the plugin pom.xml to point to that.

[Sundar Shankar]

hmm. ok. Tried like you suggested. Also, copied all jar files that build produced to plugin folder and restarted the server. It Gerrit does show as enabled in plugin page. However, I don't see "gitiles" browse option anywhere in the review page..?

	Plugin Name	Version	Status
	commit-message-length-validator	2.7-rc1	Enabled
	gitiles-dev-1.0-SNAPSHOT	1.0-SNAPSHOT	Enabled
	original-gitiles-dev-1.0-SNAPSHOT	1.0-SNAPSHOT	Enabled
	replication	2.7-rc1	Enabled
	reviewnotes	2.7-rc1	Enabled

Sundar

[Dave Borowitz]

So you ran init and it prompted you about your gitiles config? It should have put a gitweb section in your gerrit.config, did that happen?

Where are you looking for gitiles links? The simplest place is next to a patch set on the change screen, e.g. next to "Patch Set 1" here:

https://gerrit-review.googlesource.com/45802

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en
 
---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

[Sundar Shankar]

No. It is not prompting for any config update...I tried this on 2.6.rc2 and upgraded to 2.7rc1 as well. 

sshank2@sshank2-mac.local:/Users/sshank2/sw/opt # java -jar download/gerrit-2.7-rc1.war init -d reviews/

*** Gerrit Code Review 2.7-rc1

*** 

*** Git Repositories

*** 

Location of Git repositories   [git]: 

*** SQL Database

*** 

Database server type           [h2]: 

*** User Authentication

*** 

Authentication method          [DEVELOPMENT_BECOME_ANY_ACCOUNT/?]: 

*** Email Delivery

*** 

SMTP server hostname           [localhost]: 

SMTP server port               [(default)]: 

SMTP encryption                [NONE/?]: 

SMTP username                  : 

*** Container Process

*** 

Run as                         [sshank2]: 

Java runtime                   [/System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home]: 

Upgrade /Users/sshank2/sw/opt/reviews/bin/gerrit.war [Y/n]? 

Copying gerrit.war to /Users/sshank2/sw/opt/reviews/bin/gerrit.war

*** SSH Daemon

*** 

Listen on address              [*]: 

Listen on port                 [29418]: 

*** HTTP Daemon

*** 

Behind reverse proxy           [Y/n]? 

Proxy uses SSL (https://)      [y/N]? 

Subdirectory on proxy server   [/]: 

Listen on address              [*]: 

Listen on port                 [8081]: 

Canonical URL                  [localhost]: 

*** Plugins

*** 

Prompt to install core plugins [y/N]? Y

Install plugin reviewnotes version 2.7-rc1 [y/N]? Y

version 2.7-rc1 is already installed, overwrite it [y/N]? Y

Install plugin commit-message-length-validator version 2.7-rc1 [y/N]? Y

version 2.7-rc1 is already installed, overwrite it [y/N]? Y

Install plugin replication version 2.7-rc1 [y/N]? Y

version 2.7-rc1 is already installed, overwrite it [y/N]? Y

Initialized /Users/sshank2/sw/opt/reviews

ssh...@sshank2-mac.local:/Users/sshank2/sw/opt # ls reviews/plugins/

commit-message-length-validator.jar gitiles-dev-1.0-SNAPSHOT.jar replication.jar reviewnotes.jar

sshank2@sshank2-mac.local:/Users/sshank2/sw/opt # cat reviews/etc/gerrit.config 

[gerrit]

basePath = git

canonicalWebUrl = localhost

[database]

type = h2

database = db/ReviewDB

[auth]

type = DEVELOPMENT_BECOME_ANY_ACCOUNT

[sendemail]

smtpServer = localhost

[container]

user = sshank2

javaHome = /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home

heapLimit = 3g

[sshd]

listenAddress = *:29418

[httpd]

listenUrl = proxy-http://*:8081/

[cache]

directory = cache

[commitmessager]

maxSubjectLength = 75

maxLineLength = 120

-Sundar

[Chunlin Zhang]

I have just try place gitiles-dev-1.0-SNAPSHOT.jar into plugins directory,and run gerrit init,but gitiles still not work.

How can I do with it?

在 2013年5月17日星期五UTC+8上午3时31分54秒，Sundar Shankar写道：

[burke]

I re-compile gitiles plugin for gerrit 2.8.4:

#compile gerrit api

git clone https://gerrit.googlesource.com/gerrit --recursive

cd gerrit

git checkout v2.8.4 -b v2.8.4

git submodule update

buck build gerrit

buck build api

buck build api_install

mvn install:install-file -DgroupId=com.google.gerrit -DartifactId=gerrit-plugin-api -Dversion=2.8-SNAPSHOT -Dpackaging=jar -Dfile=buck-out/gen/plugin-api.jar

#compile gitiles sevelet

git clone https://gerrit.googlesource.com/gitiles --recursive

cd gitiles

git checkout 86462dfb1e17af0bb65892aa9977221f58cf7131 -b b1

mvn clean install

#compile gitiles plugin

cd ../plugins

git clone https://gerrit.googlesource.com/plugins/gitiles

cd gitiles

git checkout 7bd510a969e9679b48a2e0931c402c14c361940d -b b1

mvn clean package

#Update etc/gerrit.config

[Gitiles]

        type = custom

        linkname = gitiles

        url = plugins/gitiles/

        revision = ${project}/+/${commit}

        project = ${project}

        branch = ${project}/+/${branch}

        filehistory = ${project}/+log/${branch}/${file}

 

[Louis Bellet]

Hello,

Since plugins/gitiles was migrated to BUCK

I didn't manage to build it.

I am checkout out the sources in plugins/ folder.

then in gerrit/ I am running:

$> buck build plugins/gitiles:gitiles

/usr/src/gerrit/plugins/gitiles/src/main/java/com/googlesource/gerrit/plugins/gitiles/GerritGitilesAccess.java:18: error: cannot find symbol

import com.google.gerrit.extensions.common.ProjectInfo;

[David Ostrovsky]

Am Mittwoch, 17. September 2014 15:04:40 UTC+2 schrieb Louis Bellet:

Hello,

Since plugins/gitiles was migrated to BUCK

I didn't manage to build it.

I am checkout out the sources in plugins/ folder.

then in gerrit/ I am running:

$> buck build plugins/gitiles:gitiles

/usr/src/gerrit/plugins/gitiles/src/main/java/com/googlesource/gerrit/plugins/gitiles/GerritGitilesAccess.java:18: error: cannot find symbol

import com.google.gerrit.extensions.common.ProjectInfo;

That's because of mismatch of Gerrit core and plugin, see [1]

[1] https://gerrit-review.googlesource.com/55425

[Louis Bellet]

It worked using master for both gerrit and plugin/gitiles

Now I am facing the unclear part of the install.

I copied my jar into a gerrit install plugin folder.

But where should I place the source from gitiles ?

Using a jar, Using a war ?

My error in Gerrit logs:

[2014-09-17 07:14:54,210] ERROR com.google.gerrit.pgm.http.jetty.HiddenErrorHandler : Error in GET /plugins/gitiles/

java.lang.NoClassDefFoundError: com/google/gerrit/extensions/common/ProjectInfo

at com.googlesource.gerrit.plugins.gitiles.GerritGitilesAccess.listRepositories(GerritGitilesAccess.java:115)

at com.google.gitiles.HostIndexServlet.getDescriptions(HostIndexServlet.java:68)

at com.google.gitiles.HostIndexServlet.getDescriptions(HostIndexServlet.java:61)

at com.google.gitiles.HostIndexServlet.doGetHtml(HostIndexServlet.java:103)

at com.google.gitiles.BaseServlet.doGet(BaseServlet.java:105)

at javax.servlet.http.HttpServlet.service(HttpServlet.java:621)

at javax.servlet.http.HttpServlet.service(HttpServlet.java:728)

at com.google.gitiles.GitilesFilter$DispatchFilter$1.doFilter(GitilesFilter.java:150)

at com.googlesource.gerrit.plugins.gitiles.MenuFilter.doFilter(MenuFilter.java:63)

at com.google.gitiles.GitilesFilter$DispatchFilter$1.doFilter(GitilesFilter.java:148)

at com.google.gitiles.GitilesFilter$DispatchFilter.doFilter(GitilesFilter.java:143)

[Louis Bellet]

My bad, wrong expection:

[2014-09-17 07:21:01,203] INFO  org.eclipse.jetty.server.ServerConnector : Started ServerConnector@7081c100{HTTP/1.1}{0.0.0.0:8081}

[2014-09-17 07:21:01,204] WARN  org.eclipse.jetty.util.component.AbstractLifeCycle : FAILED org.eclipse.jetty.server.Server@2104ce68: java.lang.NoSuchMethodErro

r: com.google.common.io.Resources.newReaderSupplier(Ljava/net/URL;Ljava/nio/charset/Charset;)Lcom/google/common/io/InputSupplier;

java.lang.NoSuchMethodError: com.google.common.io.Resources.newReaderSupplier(Ljava/net/URL;Ljava/nio/charset/Charset;)Lcom/google/common/io/InputSupplier;

        at com.google.template.soy.base.SoyFileSupplier$Factory.create(SoyFileSupplier.java:136)

        at com.google.template.soy.base.SoyFileSupplier$Factory.create(SoyFileSupplier.java:153)

        at com.google.template.soy.SoyFileSet$Builder.addWithKind(SoyFileSet.java:275)

        at com.google.template.soy.SoyFileSet$Builder.add(SoyFileSet.java:292)

        at com.google.gitiles.DefaultRenderer.<init>(DefaultRenderer.java:52)

        at com.google.gitiles.DefaultRenderer.<init>(DefaultRenderer.java:36)

        at com.google.gitiles.GitilesFilter.setDefaultRenderer(GitilesFilter.java:326)

[...]

[2014-09-17 07:21:01,206] ERROR com.google.gerrit.pgm.Daemon : Unable to start daemon

java.lang.NoSuchMethodError: com.google.common.io.Resources.newReaderSupplier(Ljava/net/URL;Ljava/nio/charset/Charset;)Lcom/google/common/io/InputSupplier;

        at com.google.template.soy.base.SoyFileSupplier$Factory.create(SoyFileSupplier.java:136)

        at com.google.template.soy.base.SoyFileSupplier$Factory.create(SoyFileSupplier.java:153)

        at com.google.template.soy.SoyFileSet$Builder.addWithKind(SoyFileSet.java:275)

        at com.google.template.soy.SoyFileSet$Builder.add(SoyFileSet.java:292)

        at com.google.gitiles.DefaultRenderer.<init>(DefaultRenderer.java:52)

        at com.google.gitiles.DefaultRenderer.<init>(DefaultRenderer.java:36)

[men...@gmail.com]

I'm trying to build plugin/gitiles  for gerrit 2.8.5, but must build gerrit v.2.8.5 first, but i find gitiles doesn't  have   stable 2.8 branch,so how can i build  gitiles  2.8.5?

I try build  plugin/gitiles  for gerrit 2.9,so i download gerrit 2.9.4,   but failed  when i  run buck build api or buck build gerrit

gerrit# buck build api

:::

::: '.nobuckcheck' file is present. Not updating buck.

:::

Using buckd.

[+] PARSING BUCK FILES...0.1s

Traceback (most recent call last):

  File "/root/tools/gerrit/.buckd/tmp/buck_run.53RMeb/buck9139929503263693230.py", line 1414, in <module>

    main()

  File "/root/tools/gerrit/.buckd/tmp/buck_run.53RMeb/buck9139929503263693230.py", line 495, in main

    values = buildFileProcessor.process(build_file.rstrip())

  File "/root/tools/gerrit/.buckd/tmp/buck_run.53RMeb/buck9139929503263693230.py", line 407, in process

    implicit_includes=self._implicit_includes)

  File "/root/tools/gerrit/.buckd/tmp/buck_run.53RMeb/buck9139929503263693230.py", line 399, in _process_build_file

    implicit_includes=implicit_includes)

  File "/root/tools/gerrit/.buckd/tmp/buck_run.53RMeb/buck9139929503263693230.py", line 363, in _process

    exec(code, module.__dict__)

  File "/root/tools/gerrit/BUCK", line 1, in <module>

    include_defs('//tools/build.defs')

  File "/root/tools/gerrit/.buckd/tmp/buck_run.53RMeb/buck9139929503263693230.py", line 289, in _include_defs

    implicit_includes=implicit_includes)

  File "/root/tools/gerrit/.buckd/tmp/buck_run.53RMeb/buck9139929503263693230.py", line 380, in _process_include

    implicit_includes=implicit_includes)

  File "/root/tools/gerrit/.buckd/tmp/buck_run.53RMeb/buck9139929503263693230.py", line 363, in _process

    exec(code, module.__dict__)

  File "/root/tools/gerrit/tools/build.defs", line 17, in <module>

    DOCS_SRC = genfile('Documentation/html.zip')

NameError: name 'genfile' is not defined

[2015-05-02 13:55:30.530][error][command:79f8073a-8d6a-4d5a-affb-4236e9586d31][tid:91][com.facebook.buck.json.ProjectBuildFileParser] Process java.lang.UNIXProcess@5d69b59e exited with error code 1

BUILD FAILED: Parse error for build file /root/tools/gerrit/BUCK: End of input at line 1 column 1

[David Ostrovsky]

Am Samstag, 2. Mai 2015 08:33:42 UTC+2 schrieb Guangyi Meng:

I'm trying to build plugin/gitiles  for gerrit 2.8.5, but must build gerrit v.2.8.5 first, but i find gitiles doesn't  have   stable 2.8 branch,so how can i build  gitiles  2.8.5?

I try build  plugin/gitiles  for gerrit 2.9,so i download gerrit 2.9.4,   but failed  when i  run buck build api or buck build gerrit

gerrit# buck build api

:::

::: '.nobuckcheck' file is present. Not updating buck.

That's wrong. With `touch .nobuckcheck` you deactivated Buck's

"Update itself according to the content of .buckversion" feature

and as the consequence you have now mismatch between Gerrit

build rules and Buck version. Remove .nobuckcheck and it should

work.

[Ảnh Viện Wednesday]

Dear,

I am trying to build buck with gerrit but i faced this problem:

root@dpi-VirtualBox:~/gerrit# buck build gerrit

fatal: Not a git repository (or any of the parent directories): .git

Using watchman.

fatal: Not a git repository (or any of the parent directories): .git

[+] PARSING BUCK FILES...0.8s

BUILD FAILED: Parse error for build file /root/gerrit/BUCK:

NameError: global name 'genfile' is not defined

Call stack:

  File "/home/dpi/Downloads/buck-master/build/classes/buck_parser/buck.py", line 1216, in process_with_diagnostics

    diagnostics=diagnostics)

  File "/home/dpi/Downloads/buck-master/build/classes/buck_parser/buck.py", line 1105, in process

    os.path.join(self._project_root, path))

  File "/home/dpi/Downloads/buck-master/build/classes/buck_parser/buck.py", line 1041, in _process_build_file

    return self._process(build_env, path, is_implicit_include=False)

  File "/home/dpi/Downloads/buck-master/build/classes/buck_parser/buck.py", line 975, in _process

    exec(code, module.__dict__)

  File "/root/gerrit/BUCK", line 3

    gerrit_war(name = 'gerrit')

  File "/root/gerrit/tools/build.defs", line 79, in gerrit_war

    ] + context,

  File "/root/gerrit/tools/build.defs", line 58, in war

    src.append(genfile(r))

Could you help me to check this error.

Thank you so much

[Matthias Sohn]

On Thu, Apr 27, 2017 at 6:46 AM, Ảnh Viện Wednesday <hoangn...@gmail.com> wrote:

Dear,

I am trying to build buck with gerrit but i faced this problem:

you can't build buck with gerrit. You can build older versions of gerrit with buck ;-)

Since 2.14 gerrit is built using bazel. See

https://gerrit-review.googlesource.com/Documentation/index.html#_developer

Which version are you trying to build ?

 

root@dpi-VirtualBox:~/gerrit# buck build gerrit

fatal: Not a git repository (or any of the parent directories): .git

Did you clone the gerrit git repository and started the build from the root of its working tree ?

 

Using watchman.

fatal: Not a git repository (or any of the parent directories): .git

[+] PARSING BUCK FILES...0.8s

BUILD FAILED: Parse error for build file /root/gerrit/BUCK:

NameError: global name 'genfile' is not defined

Call stack:

  File "/home/dpi/Downloads/buck-master/build/classes/buck_parser/buck.py", line 1216, in process_with_diagnostics

    diagnostics=diagnostics)

  File "/home/dpi/Downloads/buck-master/build/classes/buck_parser/buck.py", line 1105, in process

    os.path.join(self._project_root, path))

  File "/home/dpi/Downloads/buck-master/build/classes/buck_parser/buck.py", line 1041, in _process_build_file

    return self._process(build_env, path, is_implicit_include=False)

  File "/home/dpi/Downloads/buck-master/build/classes/buck_parser/buck.py", line 975, in _process

    exec(code, module.__dict__)

  File "/root/gerrit/BUCK", line 3

    gerrit_war(name = 'gerrit')

  File "/root/gerrit/tools/build.defs", line 79, in gerrit_war

    ] + context,

  File "/root/gerrit/tools/build.defs", line 58, in war

    src.append(genfile(r))

Could you help me to check this error.

Thank you so much

--
--
To unsubscribe, email repo-discuss+unsubscribe@googlegroups.com

More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.

To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Ảnh Viện Wednesday]

Dear Mr Sohn,

I am so glad to receive your response.

I already tried to build as your guidance, but there is a error like this:

root@dpi-VirtualBox:~/gerrit# /root/bin/bazel build
INFO: Found 0 targets...
INFO: Building...
^C
Bazel caught interrupt signal; shutting down.
ERROR: build interrupted.
INFO: Elapsed time: 3.410s, Critical Path: 0.84s
root@dpi-VirtualBox:~/gerrit# /root/bin/bazel build gerrit
ERROR: /root/gerrit/lib/js/BUILD:25:1: no such package '@iron-resizable-behavior//': failed /usr/bin/python /root/gerrit/tools/js/download_bower.py -b /usr/bin/python /root/gerrit/tools/js/run_npm_binary.py /root/.cache/bazel/_bazel_root/8eda2b502a7e650827d9f7c001f5e796/external/bower/bo...@1.8.0.npm_binary.tgz -n iron-resizable-behavior -p iron-resizable-behavior -v 1.0.5 -s 2ebe983377dceb3794dd335131050656e23e2beb -o iron-resizable-behavior__download_bower.zip: /usr/bin/env: node: No such file or directory

Traceback (most recent call last):

  File "/root/gerrit/tools/js/run_npm_binary.py", line 91, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/root/gerrit/tools/js/run_npm_binary.py", line 87, in main
    subprocess.check_call([bin] + args[1:])
  File "/usr/lib/python2.7/subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['/root/.cache/bazel/_bazel_root/8eda2b502a7e650827d9f7c001f5e796/external/bower/bo...@1.8.0-55dbebef0ad9155382d9e9d3e497c1372345b44a/package/bin/bower', '-l=error', '-j', 'info', 'iron-resizable-behavior#1.0.5']' returned non-zero exit status 127

Traceback (most recent call last):

  File "/root/gerrit/tools/js/download_bower.py", line 128, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/root/gerrit/tools/js/download_bower.py", line 99, in main
    info = bower_info(opts.b, opts.n, opts.p, opts.v)
  File "/root/gerrit/tools/js/download_bower.py", line 49, in bower_info
    raise OSError('Command failed: %s' % ' '.join(cmd))
OSError: Command failed: /usr/bin/python /root/gerrit/tools/js/run_npm_binary.py /root/.cache/bazel/_bazel_root/8eda2b502a7e650827d9f7c001f5e796/external/bower/bo...@1.8.0.npm_binary.tgz -l=error -j info iron-resizable-behavior#1.0.5
 and referenced by '//lib/js:iron-resizable-behavior'.

And i built bazel in folder gerrit.

root@dpi-VirtualBox:~/gerrit# ls
bazel-bin       BUILD                        gerrit-antlr          gerrit-gwtdebug      gerrit-lucene            gerrit-pgm           gerrit-sshd       INSTALL        SUBMITTING_PATCHES
bazel-genfiles  contrib                      gerrit-cache-h2       gerrit-gwtexpui      gerrit-main              gerrit-plugin-api    gerrit-test-util  lib            tools
bazel-gerrit    COPYING                      gerrit-common         gerrit-gwtui         gerrit-oauth             gerrit-plugin-gwtui  gerrit-util-cli   plugins        version.bzl
bazel-out       Documentation                gerrit-elasticsearch  gerrit-gwtui-common  gerrit-openid            gerrit-prettify      gerrit-util-http  polygerrit-ui  website
bazel-testlogs  gerrit-acceptance-framework  gerrit-extension-api  gerrit-httpd         gerrit-patch-commonsnet  gerrit-reviewdb      gerrit-util-ssl   README.md      WORKSPACE
buck-out        gerrit-acceptance-tests      gerrit-gpg            gerrit-launcher      gerrit-patch-jgit        gerrit-server        gerrit-war        ReleaseNotes

And i have 1 more question that.

If i deploy gerrit by a gerrit war file, and i want to add gitiles plugin, so in this case what should i do?

I tried to copy the gitiles plugin folder(cloned from gerrit source), and copy to gerrit review site(which was deployed from war file). Then build with bazel and a error like this was displayed:

root@dpi-VirtualBox:/home/gerrit2/review_site# /root/bin/bazel build plugins/gitiles/

The 'build' command is only supported from within a workspace.

Best Regards,

Vào 04:30:38 UTC+7 Thứ Sáu, ngày 28 tháng 4 năm 2017, Matthias Sohn đã viết:

--
--
To unsubscribe, email repo-discuss...@googlegroups.com

More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.

To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.

[Ảnh Viện Wednesday]

Dear Mr Sohn,

You could skipp the issue of build bazel with gerrit, my company blocks github, so when i pass this step but face this issue.

So there is any another way to install gitiles plugin when i deploy the gerrit.war file as my last comment?

Best Regards,