Posting robot comments from CI

[Logan Hanks]

We've converted polygerrit-ui over to lint-free ES6, and we also have a java formatting tool. With a little work, we could use these tools to emit robot comments and make consistent style even easier.

Luca, what would be the best way to bring this about? I was thinking JSON files emitted during the build, which Gerrit-CI would look for and post after the build. Or maybe a command made available during the build that permits an arbitrary REST API call using Gerrit-CI's credentials (that seems riskier).

[Luca Milanesio]

See my feedback inline.

On 18 May 2017, at 17:34, Logan Hanks <lo...@google.com> wrote:

We've converted polygerrit-ui over to lint-free ES6, and we also have a java formatting tool. With a little work, we could use these tools to emit robot comments and make consistent style even easier.

Luca, what would be the best way to bring this about? I was thinking JSON files emitted during the build, which Gerrit-CI would look for and post after the build.

Yes, and possibly archive them as well as artifacts.

Or maybe a command made available during the build that permits an arbitrary REST API call using Gerrit-CI's credentials (that seems riskier).

Better to do as post-action at the end, IMHO.

[Kasper Nilsson]

Thanks for the advice! For now, we’d like to get the linter running as part of PolyGerrit CI.

I’ve set it up as a bazel test (the target is //polygerrit-ui/app:lint_test), but it isn’t hermeticized and has a few system dependencies. How do I go about setting that up on CI?

Kasper

[thomasmu...@yahoo.com]

I guess we update the os docker image in https://gerrit.googlesource.com/gerrit-ci-scripts/+/refs/heads/master/jenkins-docker/

Then update the shell files that build gerrit to run that command only if we do changes to polygerrit files here https://gerrit.googlesource.com/gerrit-ci-scripts/+/refs/heads/master/jenkins/gerrit-bazel-verifier-test.sh#42

[luca.mi...@gmail.com]

Will work on both this morning to enable them on the CI.

Luca

Sent from my iPhone

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.