Pushing with vote and comment-added event

Björn Pedersen

unread,

Sep 29, 2015, 3:00:04 AM9/29/15

to Repo and Gerrit Discussion

Hi,

if you push with a vote ( git push ... refs/for/master%l=Code-Review+1),
there is no comment-added event generated (and the voting comment is not added to the as well), Just the vote itself is set.
Is this intended behaviour?

This has been tested with 2.11.3-1378-gaaaf9fa (current master).

Björn

Khai Do

unread,

Oct 4, 2015, 12:41:49 PM10/4/15

to Repo and Gerrit Discussion

I see the same thing. I do get a patchset-created event but I guess it would make sense to get 2 events for this action, patchset-created and comment-added. I think the missing vote comment is definitely a bug though.

David Ostrovsky

unread,

Oct 4, 2015, 4:40:07 PM10/4/15

to Repo and Gerrit Discussion

Am Dienstag, 29. September 2015 09:00:04 UTC+2 schrieb Björn Pedersen:

Hi,

if you push with a vote ( git push ... refs/for/master%l=Code-Review+1),
there is no comment-added event generated (and the voting comment is not added to the as well), Just the vote itself is set.
Is this intended behaviour?

Yes. The reason I added label magic banch option is to support OpenStack WIP

workflow. As you may know, they abuse Workflow label to mark a change as a

WIP, e.g. [1]. With this new opion, a change can be marked as a WIP during the

upload.

If you need comment-added event in this case, consider to add it yourself or open a issue.

[1] https://review.openstack.org/230750

Björn Pedersen

unread,

Oct 7, 2015, 2:31:39 AM10/7/15

to Repo and Gerrit Discussion

Yes. The reason I added label magic banch option is to support OpenStack WIP

workflow. As you may know, they abuse Workflow label to mark a change as a
WIP, e.g. [1]. With this new opion, a change can be marked as a WIP during the
upload.

If you need comment-added event in this case, consider to add it yourself or open a issue.

[1] https://review.openstack.org/230750

I looked into the code a bit, and it seems like the base reason is, that the comment added hokk, that is also responsible for sending the event never gets called in this workflow.
I tried to add a call to insertChange in ReceiveCommits, but that seems to be the wrong place. Any hints where to best call the hook?

Björn

Björn Pedersen

unread,

Oct 10, 2015, 2:49:18 PM10/10/15

to Repo and Gerrit Discussion

Thanks to David for tackling this: https://gerrit-review.googlesource.com/#/c/71406/1

Reply all

Reply to author

Forward