got NoClassDefFoundError: org/commonmark/parser/delimiter/DelimiterProcessor when browsing lfs enabled git repositories using gitiles

[Makson Lee]

gerrit: 2.13.1

gitiles plugin: 6e3b81c

[2016-09-27 10:08:24,796] [HTTP-74] WARN  org.eclipse.jetty.servlet.ServletHandler : Error for /plugins/gitiles/test12/b/+/refs/heads/master

java.lang.NoClassDefFoundError: org/commonmark/parser/delimiter/DelimiterProcessor

at com.google.gitiles.doc.GitilesMarkdown.<clinit>(GitilesMarkdown.java:36)

at com.google.gitiles.ReadmeHelper.render(ReadmeHelper.java:100)

at com.google.gitiles.TreeSoyData.toSoyData(TreeSoyData.java:151)

at com.google.gitiles.TreeSoyData.toSoyData(TreeSoyData.java:161)

at com.google.gitiles.RevisionServlet.doGetHtml(RevisionServlet.java:107)

at com.google.gitiles.BaseServlet.doGet(BaseServlet.java:112)

at javax.servlet.http.HttpServlet.service(HttpServlet.java:622)

at javax.servlet.http.HttpServlet.service(HttpServlet.java:729)

at com.google.gitiles.GitilesFilter$DispatchFilter$1.doFilter(GitilesFilter.java:157)

at com.googlesource.gerrit.plugins.gitiles.MenuFilter.doFilter(MenuFilter.java:63)

at com.google.gitiles.GitilesFilter$DispatchFilter$1.doFilter(GitilesFilter.java:155)

at com.google.gitiles.GitilesFilter$DispatchFilter.doFilter(GitilesFilter.java:160)

at com.google.gitiles.AbstractHttpFilter.doFilter(AbstractHttpFilter.java:31)

at org.eclipse.jgit.http.server.glue.UrlPipeline$Chain.doFilter(UrlPipeline.java:235)

at com.google.gitiles.ViewFilter.doFilter(ViewFilter.java:128)

at com.google.gitiles.AbstractHttpFilter.doFilter(AbstractHttpFilter.java:31)

at com.google.gitiles.ViewFilter.doFilter(ViewFilter.java:36)

at org.eclipse.jgit.http.server.glue.UrlPipeline$Chain.doFilter(UrlPipeline.java:235)

at com.google.gitiles.RepositoryFilter.doFilter(RepositoryFilter.java:50)

at com.google.gitiles.AbstractHttpFilter.doFilter(AbstractHttpFilter.java:31)

at org.eclipse.jgit.http.server.glue.UrlPipeline$Chain.doFilter(UrlPipeline.java:235)

at org.eclipse.jgit.http.server.glue.UrlPipeline.service(UrlPipeline.java:215)

at org.eclipse.jgit.http.server.glue.RegexPipeline.service(RegexPipeline.java:149)

at org.eclipse.jgit.http.server.glue.MetaFilter.doFilter(MetaFilter.java:175)

at org.eclipse.jgit.http.server.glue.MetaServlet.service(MetaServlet.java:133)

at javax.servlet.http.HttpServlet.service(HttpServlet.java:729)

at com.google.inject.servlet.ServletDefinition.doServiceImpl(ServletDefinition.java:286)

at com.google.inject.servlet.ServletDefinition.doService(ServletDefinition.java:276)

at com.google.inject.servlet.ServletDefinition.service(ServletDefinition.java:181)

at com.google.inject.servlet.ManagedServletPipeline.service(ManagedServletPipeline.java:91)

at com.googlesource.gerrit.plugins.gitiles.SetContextClassLoader.doFilter(SetContextClassLoader.java:42)

at com.googlesource.gerrit.plugins.gitiles.LoginFilter.doFilter(LoginFilter.java:71)

at com.googlesource.gerrit.plugins.gitiles.HttpModule$1.doFilter(HttpModule.java:81)

at com.google.inject.servlet.ManagedFilterPipeline.dispatch(ManagedFilterPipeline.java:120)

at com.google.inject.servlet.GuiceFilter.doFilter(GuiceFilter.java:135)

at com.google.gerrit.httpd.plugins.HttpPluginServlet.service(HttpPluginServlet.java:239)

at javax.servlet.http.HttpServlet.service(HttpServlet.java:729)

at com.google.inject.servlet.ServletDefinition.doServiceImpl(ServletDefinition.java:286)

at com.google.inject.servlet.ServletDefinition.doService(ServletDefinition.java:276)

at com.google.inject.servlet.ServletDefinition.service(ServletDefinition.java:181)

at com.google.inject.servlet.ManagedServletPipeline.service(ManagedServletPipeline.java:91)

at com.google.gerrit.httpd.GetUserFilter.doFilter(GetUserFilter.java:82)

at com.google.gwtexpui.server.CacheControlFilter.doFilter(CacheControlFilter.java:73)

at com.google.gerrit.httpd.RunAsFilter.doFilter(RunAsFilter.java:122)

at com.google.gerrit.httpd.RequestMetricsFilter.doFilter(RequestMetricsFilter.java:60)

at com.google.gerrit.httpd.AllRequestFilter$FilterProxy$1.doFilter(AllRequestFilter.java:136)

at com.google.gerrit.httpd.AllRequestFilter$FilterProxy.doFilter(AllRequestFilter.java:105)

at com.google.gerrit.httpd.RequestContextFilter.doFilter(RequestContextFilter.java:75)

at com.google.inject.servlet.ManagedFilterPipeline.dispatch(ManagedFilterPipeline.java:120)

at com.google.inject.servlet.GuiceFilter.doFilter(GuiceFilter.java:135)

at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)

at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:585)

at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:221)

at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1127)

at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:515)

at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)

at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1061)

at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)

at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:97)

at org.eclipse.jetty.server.handler.RequestLogHandler.handle(RequestLogHandler.java:95)

at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:97)

at org.eclipse.jetty.server.Server.handle(Server.java:499)

at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:311)

at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:257)

at org.eclipse.jetty.io.AbstractConnection$2.run(AbstractConnection.java:544)

at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:635)

at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:555)

at java.lang.Thread.run(Thread.java:745)

Caused by: java.lang.ClassNotFoundException: org.commonmark.parser.delimiter.DelimiterProcessor

at java.net.URLClassLoader.findClass(URLClassLoader.java:381)

at java.lang.ClassLoader.loadClass(ClassLoader.java:424)

at java.lang.ClassLoader.loadClass(ClassLoader.java:357)

... 68 more

[2016-09-27 10:08:24,803] [HTTP-74] ERROR com.google.gerrit.pgm.http.jetty.HiddenErrorHandler : Error in GET /plugins/gitiles/test12/b/+/refs/heads/master

java.lang.NoClassDefFoundError: org/commonmark/parser/delimiter/DelimiterProcessor

at com.google.gitiles.doc.GitilesMarkdown.<clinit>(GitilesMarkdown.java:36)

at com.google.gitiles.ReadmeHelper.render(ReadmeHelper.java:100)

at com.google.gitiles.TreeSoyData.toSoyData(TreeSoyData.java:151)

at com.google.gitiles.TreeSoyData.toSoyData(TreeSoyData.java:161)

at com.google.gitiles.RevisionServlet.doGetHtml(RevisionServlet.java:107)

at com.google.gitiles.BaseServlet.doGet(BaseServlet.java:112)

at javax.servlet.http.HttpServlet.service(HttpServlet.java:622)

at javax.servlet.http.HttpServlet.service(HttpServlet.java:729)

at com.google.gitiles.GitilesFilter$DispatchFilter$1.doFilter(GitilesFilter.java:157)

at com.googlesource.gerrit.plugins.gitiles.MenuFilter.doFilter(MenuFilter.java:63)

at com.google.gitiles.GitilesFilter$DispatchFilter$1.doFilter(GitilesFilter.java:155)

at com.google.gitiles.GitilesFilter$DispatchFilter.doFilter(GitilesFilter.java:160)

at com.google.gitiles.AbstractHttpFilter.doFilter(AbstractHttpFilter.java:31)

at org.eclipse.jgit.http.server.glue.UrlPipeline$Chain.doFilter(UrlPipeline.java:235)

at com.google.gitiles.ViewFilter.doFilter(ViewFilter.java:128)

at com.google.gitiles.AbstractHttpFilter.doFilter(AbstractHttpFilter.java:31)

at com.google.gitiles.ViewFilter.doFilter(ViewFilter.java:36)

at org.eclipse.jgit.http.server.glue.UrlPipeline$Chain.doFilter(UrlPipeline.java:235)

at com.google.gitiles.RepositoryFilter.doFilter(RepositoryFilter.java:50)

at com.google.gitiles.AbstractHttpFilter.doFilter(AbstractHttpFilter.java:31)

at org.eclipse.jgit.http.server.glue.UrlPipeline$Chain.doFilter(UrlPipeline.java:235)

at org.eclipse.jgit.http.server.glue.UrlPipeline.service(UrlPipeline.java:215)

at org.eclipse.jgit.http.server.glue.RegexPipeline.service(RegexPipeline.java:149)

at org.eclipse.jgit.http.server.glue.MetaFilter.doFilter(MetaFilter.java:175)

at org.eclipse.jgit.http.server.glue.MetaServlet.service(MetaServlet.java:133)

at javax.servlet.http.HttpServlet.service(HttpServlet.java:729)

at com.google.inject.servlet.ServletDefinition.doServiceImpl(ServletDefinition.java:286)

at com.google.inject.servlet.ServletDefinition.doService(ServletDefinition.java:276)

at com.google.inject.servlet.ServletDefinition.service(ServletDefinition.java:181)

at com.google.inject.servlet.ManagedServletPipeline.service(ManagedServletPipeline.java:91)

at com.googlesource.gerrit.plugins.gitiles.SetContextClassLoader.doFilter(SetContextClassLoader.java:42)

at com.googlesource.gerrit.plugins.gitiles.LoginFilter.doFilter(LoginFilter.java:71)

at com.googlesource.gerrit.plugins.gitiles.HttpModule$1.doFilter(HttpModule.java:81)

at com.google.inject.servlet.ManagedFilterPipeline.dispatch(ManagedFilterPipeline.java:120)

at com.google.inject.servlet.GuiceFilter.doFilter(GuiceFilter.java:135)

at com.google.gerrit.httpd.plugins.HttpPluginServlet.service(HttpPluginServlet.java:239)

at javax.servlet.http.HttpServlet.service(HttpServlet.java:729)

at com.google.inject.servlet.ServletDefinition.doServiceImpl(ServletDefinition.java:286)

at com.google.inject.servlet.ServletDefinition.doService(ServletDefinition.java:276)

at com.google.inject.servlet.ServletDefinition.service(ServletDefinition.java:181)

at com.google.inject.servlet.ManagedServletPipeline.service(ManagedServletPipeline.java:91)

at com.google.gerrit.httpd.GetUserFilter.doFilter(GetUserFilter.java:82)

at com.google.gwtexpui.server.CacheControlFilter.doFilter(CacheControlFilter.java:73)

at com.google.gerrit.httpd.RunAsFilter.doFilter(RunAsFilter.java:122)

at com.google.gerrit.httpd.RequestMetricsFilter.doFilter(RequestMetricsFilter.java:60)

at com.google.gerrit.httpd.AllRequestFilter$FilterProxy$1.doFilter(AllRequestFilter.java:136)

at com.google.gerrit.httpd.AllRequestFilter$FilterProxy.doFilter(AllRequestFilter.java:105)

at com.google.gerrit.httpd.RequestContextFilter.doFilter(RequestContextFilter.java:75)

at com.google.inject.servlet.ManagedFilterPipeline.dispatch(ManagedFilterPipeline.java:120)

at com.google.inject.servlet.GuiceFilter.doFilter(GuiceFilter.java:135)

at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)

at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:585)

at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:221)

at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1127)

at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:515)

at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)

at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1061)

at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)

at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:97)

at org.eclipse.jetty.server.handler.RequestLogHandler.handle(RequestLogHandler.java:95)

at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:97)

at org.eclipse.jetty.server.Server.handle(Server.java:499)

at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:311)

at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:257)

at org.eclipse.jetty.io.AbstractConnection$2.run(AbstractConnection.java:544)

at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:635)

at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:555)

at java.lang.Thread.run(Thread.java:745)

Caused by: java.lang.ClassNotFoundException: org.commonmark.parser.delimiter.DelimiterProcessor

at java.net.URLClassLoader.findClass(URLClassLoader.java:381)

at java.lang.ClassLoader.loadClass(ClassLoader.java:424)

at java.lang.ClassLoader.loadClass(ClassLoader.java:357)

... 68 more

[David Pursehouse]

Can you be more specific about what "when browsing lfs enabled git repositories" means?

I've just tried it now with the same plugin version, and didn't see any problems in browsing the project history or content of files containing the LFS pointer.

Did you build the plugin from source, or download it?  If from source, was it in-tree or standalone?

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Makson Lee]

On Tuesday, September 27, 2016 at 2:40:40 PM UTC+8, David Pursehouse wrote:

Can you be more specific about what "when browsing lfs enabled git repositories" means?

/srv/gerrit2/etc/gerrit.config:

[lfs]

        plugin = lfs

All-Projects/refs/meta/config/./lfs.config:

[lfs "?/*"]

  enabled = true

  maxObjectSize = 500m

test12/b/refs/heads/master/./.lfsconfig:

[lfs]

        url = http://master.domain:8080/test12/b/info/lfs

followed the git lfs tutorial in [1], created a lfs enabled git repository and pushed it to gerrit, it is working fine to clone it back without any problem, but if you try to browse branch of project in gerrit ui, you got server error.

 

I've just tried it now with the same plugin version, and didn't see any problems in browsing the project history or content of files containing the LFS pointer,

Did you build the plugin from source, or download it?  If from source, was it in-tree or standalone?

i downloaded it from [2].

[1] https://github.com/github/git-lfs/wiki/Tutorial

[2] https://gerrit-ci.gerritforge.com/job/plugin-gitiles-stable-2.13/1/artifact/buck-out/gen/plugins/gitiles/gitiles.jar

[Makson Lee]

okay, for ordinary git repositories, we also got NoClassDefFoundError,

[2016-09-28 17:10:49,476] [HTTP-27804] ERROR com.google.gerrit.pgm.http.jetty.HiddenErrorHandler : Error in GET /plugins/gitiles/platform/frameworks/base/+/refs/heads/xxxxxx/packages/SystemUI/

java.lang.NoClassDefFoundError: Could not initialize class com.google.gitiles.doc.GitilesMarkdown

at com.google.gitiles.ReadmeHelper.render(ReadmeHelper.java:100)

at com.google.gitiles.TreeSoyData.toSoyData(TreeSoyData.java:151)

at com.google.gitiles.PathServlet.showTree(PathServlet.java:489)

at com.google.gitiles.PathServlet.doGetHtml(PathServlet.java:139)

[Deepanshu Gupta]

I don't think this is related to "lfs enabled git repositories". We are seeing both those errors (GitilesMarkdown and DelimiterProcessor) in our logs and we don't use lfs.

In addition only direct links to files are working. Browsing the repo results in "Server error" shown in the browser with one of the above error logged.

I've tried both downloading the jar from the gerrit jenkins server and building myself from the tagged release: b9a2cef. Both exhibit the same behavior.

[David Pursehouse]

On Fri, Sep 30, 2016 at 9:53 AM Deepanshu Gupta <deep...@zendrive.com> wrote:

I don't think this is related to "lfs enabled git repositories". We are seeing both those errors (GitilesMarkdown and DelimiterProcessor) in our logs and we don't use lfs.

In addition only direct links to files are working. Browsing the repo results in "Server error" shown in the browser with one of the above error logged.

I've tried both downloading the jar from the gerrit jenkins server and building myself from the tagged release: b9a2cef. Both exhibit the same behavior.

Version b9a2cef will not work with Gerrit 2.13.x because that's on the plugin's master branch which is built against 2.14-SNAPSHOT.

The correct latest version for 2.13.x is 6e3b81c.

I've tested again with that version and can't reproduce any errors.

 

--

[Makson Lee]

On Friday, September 30, 2016 at 1:16:03 PM UTC+8, David Pursehouse wrote:

The correct latest version for 2.13.x is 6e3b81c.

I've tested again with that version and can't reproduce any errors.

i also tried to build this version from source, still have the same problem, can you provide the plugin jar file you used? 

[Deepanshu Gupta]

Thanks for checking, however since I was still seeing the error, I decided to debug and fixed it by upgrading commonmark dependency from 0.5.1 to 0.6.0. I did not see org/commonmark/parser/delimiter/DelimiterProcessor.java in the 0.5.1 jar on maven central and it was there in the 0.6.0 jar.

diff --git a/BUCK b/BUCK

index eb9072f..d81cf11 100644

--- a/BUCK

+++ b/BUCK

@@ -126,11 +126,11 @@ maven_jar(

   visibility = [],

 )

-COMMONMARK_VERSION = '0.5.1'

+COMMONMARK_VERSION = '0.6.0'

 maven_jar(

   name = 'commonmark',

   id = 'com.atlassian.commonmark:commonmark:' + COMMONMARK_VERSION,

-  sha1 = 'b35ae2353871955674bbfa1a92394272b1dada45',

+  sha1 = '5df3f6fa3073966620685924aa22d08ece7213f2',

   license = 'commonmark',

   local_license = True,

 )

@@ -138,7 +138,7 @@ maven_jar(

 maven_jar(

   name = 'cm-autolink',

   id = 'com.atlassian.commonmark:commonmark-ext-autolink:' + COMMONMARK_VERSION,

-  sha1 = '29bb9d22a7aaf5bd8f23d8cbdd9f438f07e26735',

+  sha1 = '4d7e828a4651e2f590b4a059925991be58e62da6',

   license = 'commonmark',

   local_license = True,

   deps = [

@@ -158,7 +158,7 @@ maven_jar(

 maven_jar(

   name = 'gfm-strikethrough',

   id = 'com.atlassian.commonmark:commonmark-ext-gfm-strikethrough:' + COMMONMARK_VERSION,

-  sha1 = 'acc28d79c4e00a6e24017596dd22ce757df71db3',

+  sha1 = '75a95aaec77810496de41239bcc773adfb13285f',

   license = 'commonmark',

   local_license = True,

   deps = [':commonmark'],

@@ -167,7 +167,7 @@ maven_jar(

 maven_jar(

   name = 'gfm-tables',

   id = 'com.atlassian.commonmark:commonmark-ext-gfm-tables:' + COMMONMARK_VERSION,

-  sha1 = '5cdc350f7e498458e5ed6751771c5e8c3efc107e',

+  sha1 = 'ae1c701517e8116bc205b561b9b215a53df8abc7',

   license = 'commonmark',

   local_license = True,

   deps = [':commonmark'],

[David Pursehouse]

Do you have any specific configuration in gitiles.config?  What types of file are in the repository?

[David Pursehouse]

On Fri, Sep 30, 2016 at 3:37 PM Deepanshu Gupta <deep...@zendrive.com> wrote:

Thanks for checking, however since I was still seeing the error, I decided to debug and fixed it by upgrading commonmark dependency from 0.5.1 to 0.6.0.

Thanks.  Can you push that for review on gerrit-review?

I've also just been able to reproduce it.  I realised that I was testing on a project that does not have README.md, and after adding that it starts to throw the error.

[Makson Lee]

On Friday, September 30, 2016 at 2:37:27 PM UTC+8, David Pursehouse wrote:

On Fri, Sep 30, 2016 at 3:35 PM Makson Lee <cdle...@gmail.com> wrote:

On Friday, September 30, 2016 at 1:16:03 PM UTC+8, David Pursehouse wrote:

The correct latest version for 2.13.x is 6e3b81c.

I've tested again with that version and can't reproduce any errors.

i also tried to build this version from source, still have the same problem, can you provide the plugin jar file you used? 

Do you have any specific configuration in gitiles.config?  What types of file are in the repository?

actually, i don't have gitiles.config file there, and we only have text files in the repository. 

[Makson Lee]

On Friday, September 30, 2016 at 2:41:15 PM UTC+8, David Pursehouse wrote:

On Fri, Sep 30, 2016 at 3:37 PM Deepanshu Gupta <deep...@zendrive.com> wrote:

Thanks for checking, however since I was still seeing the error, I decided to debug and fixed it by upgrading commonmark dependency from 0.5.1 to 0.6.0.

Thanks.  Can you push that for review on gerrit-review?

I've also just been able to reproduce it.  I realised that I was testing on a project that does not have README.md, and after adding that it starts to throw the error.

yes, we also have README.md in our repository.

[David Pursehouse]

I've built locally and confirmed that Deepanshu's patch fixes it.  I'll approve and merge that as soon as possible after he uploads it for review.

[Makson Lee]

On Friday, September 30, 2016 at 2:53:36 PM UTC+8, David Pursehouse wrote:

I've built locally and confirmed that Deepanshu's patch fixes it.  I'll approve and merge that as soon as possible after he uploads it for review.

thanks for both of your help :-)