Gerrit can no longer load its-jira

[Khai Do]

Hello.  I believe there's a library conflict that prevents gerrit from loading the its-jira plugin.  This is only happening on the master branch.  I was wondering if anybody knows anything about this and how it might be corrected?  I've entered a bug for it on the issue tracker: https://bugs.chromium.org/p/gerrit/issues/detail?id=5261

[Luca Milanesio]

Yes, I've noticed that a couple of days ago.

To be honest with you, I believe the problem is really the embedding of the Atlassian-custom stack.

When you just read the name of the version ... it freezes your blood in the veins: "4.0-beta3-atlassian-1".

At the end of the day, they are documented REST API and we should invoke them directly using a native HTTP stack instead of their hacked APIs.

For the time being, Gerrit master is not released yet and there's no urgency ... but it will be something to fix once 2.14 is released.

Luca.

On 13 Jan 2017, at 07:03, Khai Do <zaro...@gmail.com> wrote:

Hello.  I believe there's a library conflict that prevents gerrit from loading the its-jira plugin.  This is only happening on the master branch.  I was wondering if anybody knows anything about this and how it might be corrected?  I've entered a bug for it on the issue tracker: https://bugs.chromium.org/p/gerrit/issues/detail?id=5261

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[thomasmu...@yahoo.com]

What if we changed the name in the maven_jar from httpasyncclient to httpasyncclient_2 would that work?

Do we have to use version 4.0-beta3-atlassian-1 or can we update to the one in gerrit's core?

[Luca Milanesio]

mmm ... is this a Java-language related question?

StackOverflow has the answer:

http://stackoverflow.com/questions/6105124/java-classpath-classloading-multiple-versions-of-the-same-jar-project

Isn't that simple as renaming a jar name or a Bazel rule, unfortunately :-(

Luca.

[thomasmu...@yahoo.com]

Can we switch to the newer one that is in gerrit's core? Or do we have to use the atlassian one?

On Friday, January 13, 2017 at 7:03:11 AM UTC, Khai Do wrote:

[Luca Milanesio]

You can try and ... put your helmet to avoid being hit by the blast :-O

Doesn't unfortunately work, the two versions aren't compatible.

The point is: do we really need to use their (cr**py)  JAR to call a REST API?

Luca.

[thomasmu...@yahoo.com]

Is there a way we can exclude the jar file that are conflicting with the newer version in gerrit's core?

On Friday, January 13, 2017 at 7:03:11 AM UTC, Khai Do wrote:

[Luca Milanesio]

Nope, it isn't compatible.

Luca.

[thomasmu...@yahoo.com]

I wonder how to fix this easily. Or is there a new rest api jar for jira we could use inside the its-jira plugin?

On Friday, January 13, 2017 at 7:03:11 AM UTC, Khai Do wrote:

[Luca Milanesio]

Easily? not really :-(

Cleanly? Yes, using the Jira REST API directly, without having to include Atlasshi**yjars.

Luca.

[thomasmu...@yahoo.com]

Oh, but doint we have to use jira-rest-java-client-core for that? Or by directly does that include not using jira-rest-java-client-core.

[Luca Milanesio]

On 7 Feb 2017, at 22:49, thomasmulhall410 via Repo and Gerrit Discussion <repo-d...@googlegroups.com> wrote:

Oh, but doint we have to use jira-rest-java-client-core for that?

Who said that? REST was invented to avoid including the API client stubs ... and the Atlassian guys decided to build a fantastic REST client stub, smart !

Or by directly does that include not using jira-rest-java-client-core.

Nope, I mean calling directly the endpoint using an HTTP client.

[thomasmu...@yahoo.com]

 I thought the only way to access jira rest api was using a plugin. But using an http client is good. Though i doint know how to switch to http client.

[thomasmu...@yahoo.com]

Yipee i figured out a short term solution. But we should deffitly migrate away from using the attlasion* jars as it just makes keeping the plugin compatible with gerrit core hardeer.

The soultion for short term is to build some of the deps from source like we do with gitblit.

Yes i know this is not what we want to do, but its the only thing i could do to get it working.

I will update the patch here https://gerrit-review.googlesource.com/#/c/95533/

Also i've only managed to test that building and loading the plugin worked. I didnt actually test any funtionality. Also i have these repos https://github.com/paladox/jira-rest-java-client and https://github.com/paladox/atlassian-webhooks-plugin/

I would need someone else to actually test that the functionality works please.

:)

On Friday, January 13, 2017 at 7:03:11 AM UTC, Khai Do wrote:

[thomasmu...@yahoo.com]

I've uploaded the fix now at https://gerrit-review.googlesource.com/#/c/95533/ :)

On Friday, January 13, 2017 at 7:03:11 AM UTC, Khai Do wrote: