Custom Label Order on new change screen not working?

[Welch, Ronald P (US SSA)]

I have Project level labels specified as follows in the

project.config file:

[label "Devl-Build"]
value = -1 Fails-Devl
value =  0 No score
value = +1 Verified-Devl
        abbreviation = D
function = MaxWithBlock
[label "Qual-Build"]
value = -1 Fails-Qual
value =  0 No score
value = +1 Verified-Qual
        abbreviation = Q
function = MaxWithBlock
[label "Prod-Build"]
value = -1 Fails-Prod
value =  0 No score
value = +1 Verified-Prod
        abbreviation = P
function = MaxWithBlock

They do not appear in Devl/Qual/Prod order on the change screen

but rather as Devl/Prod/Qual as can be seen in this screen shot:

Is this a bug or am I doing something wrong?

Thanks,

Ron

----------=-=-=-=-=-=-=-=-========oOo========-=-=-=-=-=-=-=-=----------
mailto:Ronald....@baesystems.com                Phone:(607)206-8718
BAE SYSTEMS                       1701 North Street, Endicott, NY 13760
----------=-=-=-=-=-=-=-=-===================-=-=-=-=-=-=-=-=----------

[Thomas Swindells (tswindel)]

Looks like they are appearing in alphabetical order.  What makes you think they should appear in the same order that they are defined as in the config file?

 

Thomas

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Welch, Ronald P (US SSA)]

Hi Thomas,

In the "Your Label Here" section of the labels config-labels.html

file at:

https://gerrit-review.googlesource.com/Documentation/config-labels.html

The last paragraph says:

"Labels are laid out in the order they are specified in project.config, with inherited 

labels appearing first, providing some layout control to the administrator."

Maybe I am not interpreting what is meant by that correctly…

Ron

----------=-=-=-=-=-=-=-=-========oOo========-=-=-=-=-=-=-=-=----------
mailto:Ronald....@baesystems.com                Phone:(607)206-8718
BAE SYSTEMS                       1701 North Street, Endicott, NY 13760
----------=-=-=-=-=-=-=-=-===================-=-=-=-=-=-=-=-=----------

<image001.png>

 

 

Is this a bug or am I doing something wrong?

 

Thanks,

Ron

 

----------=-=-=-=-=-=-=-=-========oOo========-=-=-=-=-=-=-=-=----------
mailto:Ronald....@baesystems.com                Phone:(607)206-8718
BAE SYSTEMS                       1701 North Street, Endicott, NY 13760
----------=-=-=-=-=-=-=-=-===================-=-=-=-=-=-=-=-=----------

 

[Zu, Bruce]

How about provide a config option to decide alphabetical order or their place order(default)?
/Bruce

Sent from my Sony Xperia™ smartphone


---- Thomas Swindells (tswindel) wrote ----

[cid:image0...@01CFD362.6D776270]

Is this a bug or am I doing something wrong?

Thanks,
Ron

----------=-=-=-=-=-=-=-=-========oOo========-=-=-=-=-=-=-=-=----------
mailto:Ronald....@baesystems.com Phone:(607)206-8718
BAE SYSTEMS 1701 North Street, Endicott, NY 13760
----------=-=-=-=-=-=-=-=-===================-=-=-=-=-=-=-=-=----------

--
--

To unsubscribe, email repo-discuss...@googlegroups.com<mailto:repo-discuss...@googlegroups.com>

More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.

To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com<mailto:repo-discuss...@googlegroups.com>.

For more options, visit https://groups.google.com/d/optout.

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.

To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com<mailto:repo-discuss...@googlegroups.com>.

[Dave Borowitz]

On Thu, Sep 18, 2014 at 9:45 AM, Welch, Ronald P (US SSA) <ronald....@baesystems.com> wrote:

Hi Thomas,

In the "Your Label Here" section of the labels config-labels.html

file at:

https://gerrit-review.googlesource.com/Documentation/config-labels.html

The last paragraph says:

"Labels are laid out in the order they are specified in project.config, with inherited 

labels appearing first, providing some layout control to the administrator."

Maybe I am not interpreting what is meant by that correctly…

I suspect they are coming back in the right order in the REST API and then reordered on the client. (Either that or I was lying when I wrote that sentence...)

Can you look at the REST API response and confirm?

[Welch, Ronald P (US SSA)]

That would be good, but one could easily achieve alphabetical 

order just by listing them that way in the config file if the 

file-based layout ordering worked…

BTW, the order is the same in the "Reply…" button dialog:

 

----------=-=-=-=-=-=-=-=-========oOo========-=-=-=-=-=-=-=-=----------
mailto:Ronald....@baesystems.com                Phone:(607)206-8718
BAE SYSTEMS                       1701 North Street, Endicott, NY 13760
----------=-=-=-=-=-=-=-=-===================-=-=-=-=-=-=-=-=----------

On Sep 18, 2014, at 1:10 PM, Zu, Bruce wrote:

How about provide a config option to decide alphabetical order or their place order(default)?
/Bruce

Sent from my Sony Xperia(tm) smartphone

To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.

[Dave Borowitz]

On Thu, Sep 18, 2014 at 10:33 AM, Dave Borowitz <dbor...@google.com> wrote:

On Thu, Sep 18, 2014 at 9:45 AM, Welch, Ronald P (US SSA) <ronald....@baesystems.com> wrote:

Hi Thomas,

In the "Your Label Here" section of the labels config-labels.html

file at:

https://gerrit-review.googlesource.com/Documentation/config-labels.html

The last paragraph says:

"Labels are laid out in the order they are specified in project.config, with inherited 

labels appearing first, providing some layout control to the administrator."

Maybe I am not interpreting what is meant by that correctly…

I suspect they are coming back in the right order in the REST API and then reordered on the client. (Either that or I was lying when I wrote that sentence...)

Can you look at the REST API response and confirm?

I found at least one place in the code where we're sorting label names returned by the server. We probably shouldn't, but I don't know that the iteration order of results is the same as they came on the wire, is probably why it is the way it is.

[Welch, Ronald P (US SSA)]

Hi Dave,

Here is the REST output:

$ curl 'cvs01.cs.na.baesystems.com:8080/changes/?o=LABELS'

)]}'

[

  {

    "kind": "gerritcodereview#change",

    "id": "wc10_Windchill~environment%2Frelease-candidate~If33e305919825bf70e4656cacae96049bc2cfeb5",

    "project": "wc10_Windchill",

    "branch": "environment/release-candidate",

    "change_id": "If33e305919825bf70e4656cacae96049bc2cfeb5",

    "subject": "[IT-TMS-14675] Workflow robot logging update",

    "status": "NEW",

    "created": "2014-09-13 19:07:14.851000000",

    "updated": "2014-09-18 12:08:29.039000000",

    "mergeable": true,

    "insertions": 66,

    "deletions": 26,

    "_sortkey": "002fde180000009a",

    "_number": 154,

    "owner": {

      "name": "Ronald Welch"

    },

    "labels": {

      "Code-Review": {},

      "DevlBuild": {},

      "QualBuild": {},

      "ProdBuild": {}

    }

  }

]

Looks like the are coming back in the "wrong" order.

Thanks for your help,

Ron

----------=-=-=-=-=-=-=-=-========oOo========-=-=-=-=-=-=-=-=----------
mailto:Ronald....@baesystems.com                Phone:(607)206-8718
BAE SYSTEMS                       1701 North Street, Endicott, NY 13760
----------=-=-=-=-=-=-=-=-===================-=-=-=-=-=-=-=-=----------

[Thomas Swindells (tswindel)]

Yep, I can definitely see why that part of the doc would make you think that.

A configuration option would be needed as child projects can’t enforce alphabetical order when inheriting labels from their parents.

[Thomas Swindells (tswindel)]

[Thomas Swindells] That’s the order that is defined in your config file isn’t it (Q before P) so must be  a client side rendering issue.

[Welch, Ronald P (US SSA)]

Yes you are correct, it is the order from the config file. So the

client side rendering does appear to be holding a smoking gun.

----------=-=-=-=-=-=-=-=-========oOo========-=-=-=-=-=-=-=-=----------
mailto:Ronald....@baesystems.com                Phone:(607)206-8718
BAE SYSTEMS                       1701 North Street, Endicott, NY 13760
----------=-=-=-=-=-=-=-=-===================-=-=-=-=-=-=-=-=----------

[David Ostrovsky]

Am Freitag, 19. September 2014 13:35:48 UTC+2 schrieb Ron Welch:

Yes you are correct, it is the order from the config file. So the

client side rendering does appear to be holding a smoking gun.

Sorting by label name happens here (from the first CS2 version) [1].

1. boolean set(ChangeInfo info, boolean current) {
2. List<String> names = new ArrayList<>(info.labels());
3. Collections.sort(names);

[1] https://gerrit.googlesource.com/gerrit/+/master/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/Labels.java#104

[Welch, Ronald P (US SSA)]

Ok, that makes sense. But alas I think the "problem" may be a bit

wider spread. For example, the labels are also sorted on the search

results table:

And also in the "Reply…" dialog on the change page:

Maybe other places too…I haven't explored completely.

----------=-=-=-=-=-=-=-=-========oOo========-=-=-=-=-=-=-=-=----------
mailto:Ronald....@baesystems.com                Phone:(607)206-8718
BAE SYSTEMS                       1701 North Street, Endicott, NY 13760
----------=-=-=-=-=-=-=-=-===================-=-=-=-=-=-=-=-=----------

[David Ostrovsky]

Am Freitag, 19. September 2014 14:46:45 UTC+2 schrieb Ron Welch:

Ok, that makes sense. But alas I think the "problem" may be a bit

wider spread. 

Untested: https://gerrit-review.googlesource.com/60246