Re: No changes can be seen in All/*

17 views
Skip to first unread message

Shawn Pearce

unread,
Sep 21, 2012, 8:47:31 PM9/21/12
to Ondřej Surý, repo-discuss
On Fri, Sep 21, 2012 at 6:18 AM, Ondřej Surý <ond...@sury.org> wrote:
> we have installed gerrit just yesterday and there seems to be a problem with
> All/{Open,Merged,...} lists, where no Changes can be seen.
>
> I was able to make gerrit-trigger to work. The developers (right now there
> are just two of us testing) can push and review the Changes from
> "My/Changes", but I cannot seem to be able to see any Open or Merged Changes
> in the normal views.

Are you using OpenID? Did you change the port or host name the server
is running on? Some OpenID providers like Google Accounts return
different identifiers when the host or port changes, causing Gerrit to
setup a new user account. That account might not be in the correct
group(s), causing changes to not be visible.

Ondřej Surý

unread,
Sep 23, 2012, 4:09:47 AM9/23/12
to Shawn Pearce, repo-discuss
On Sat, Sep 22, 2012 at 2:47 AM, Shawn Pearce <s...@google.com> wrote:
> On Fri, Sep 21, 2012 at 6:18 AM, Ondřej Surý <ond...@sury.org> wrote:
>> we have installed gerrit just yesterday and there seems to be a problem with
>> All/{Open,Merged,...} lists, where no Changes can be seen.
>>
>> I was able to make gerrit-trigger to work. The developers (right now there
>> are just two of us testing) can push and review the Changes from
>> "My/Changes", but I cannot seem to be able to see any Open or Merged Changes
>> in the normal views.
>
> Are you using OpenID?

Yes, we are. I had some trouble using LDAP.

> Did you change the port or host name the server is running on?

Nope, it was a clean install.

> Some OpenID providers like Google Accounts return
> different identifiers when the host or port changes, causing Gerrit to
> setup a new user account. That account might not be in the correct
> group(s), causing changes to not be visible.

Unfortunatelly that's not the case. My permissions are correct (I am
in the Administrators group and it works correctly.)

Anyway thanks for the reply.

O.
--
Ondřej Surý <ond...@sury.org>

Ondřej Surý

unread,
Sep 23, 2012, 7:20:48 AM9/23/12
to Shawn Pearce, repo-discuss
Hi,

I think I found it, the problem is that "T.sort_key<'Z'" statement in
the query is locale is dependent and the database was initialized with
cs_CZ.utf8.

It's probably worth:
a) mentioning this in the documentation
b) checked for correct sorting (or compatible locale) during installation
c) changing the code to not depend on locale dependant sorting

I have also confirmed this to be a culprit by droping the database and
recreating it with en_GB.utf8. Now All/* works correctly.

Ondrej
--
Ondřej Surý <ond...@sury.org>

Brad Larson

unread,
Sep 23, 2012, 9:31:22 PM9/23/12
to repo-d...@googlegroups.com


On Sunday, September 23, 2012 6:21:13 AM UTC-5, Ondřej Surý wrote:
Hi,

I think I found it, the problem is that "T.sort_key<'Z'" statement in
the query is locale is dependent and the database was initialized with
cs_CZ.utf8.

It's probably worth:
a) mentioning this in the documentation
b) checked for correct sorting (or compatible locale) during installation
c) changing the code to not depend on locale dependant sorting

I have also confirmed this to be a culprit by droping the database and
recreating it with en_GB.utf8. Now All/* works correctly.

Good catch.  I would recommend creating a ticket at http://code.google.com/p/gerrit/issues/list to make sure this doesn't slip through the cracks.

Brad

Martin Fick

unread,
Sep 23, 2012, 10:55:26 PM9/23/12
to Brad Larson, repo-d...@googlegroups.com
I would recommend a submitting a doc change instead! :)

Brad Larson <bkla...@gmail.com> wrote:

>
>
>On Sunday, September 23, 2012 6:21:13 AM UTC-5, Ondřej Surý wrote:
>>
>> Hi,
>>
>> I think I found it, the problem is that "T.sort_key<'Z'" statement in
>
>> the query is locale is dependent and the database was initialized
>with
>> cs_CZ.utf8.
>>
>> It's probably worth:
>> a) mentioning this in the documentation
>> b) checked for correct sorting (or compatible locale) during
>installation
>> c) changing the code to not depend on locale dependant sorting
>>
>> I have also confirmed this to be a culprit by droping the database
>and
>> recreating it with en_GB.utf8. Now All/* works correctly.
>>
>
>Good catch. I would recommend creating a ticket at
>http://code.google.com/p/gerrit/issues/list to make sure this doesn't
>slip
>through the cracks.
>
>Brad
>
>
>>
>> Ondrej
>>
>> On Sun, Sep 23, 2012 at 10:09 AM, Ondřej Surý
><ond...@sury.org<javascript:>>
>> wrote:
>> > On Sat, Sep 22, 2012 at 2:47 AM, Shawn Pearce
><s...@google.com<javascript:>>
>> wrote:
>> >> On Fri, Sep 21, 2012 at 6:18 AM, Ondřej Surý
><ond...@sury.org<javascript:>>
>> > Ondřej Surý <ond...@sury.org <javascript:>>
>>
>>
>>
>> --
>> Ondřej Surý <ond...@sury.org <javascript:>>
>>
>
>--
>To unsubscribe, email repo-discuss...@googlegroups.com
>More info at http://groups.google.com/group/repo-discuss?hl=en

Employee of Qualcomm Innovation Center,Inc. which is a member of Code Aurora Forum
Reply all
Reply to author
Forward
0 new messages