Requiring resolution of inline comments

[Leon Dubinsky]

Hi all,

I'm new to Gerrit so please forgive me if this is an FAQ. 

I'm looking for a way to author a rule that would block commit as long as there are non-addressed inline comments on the change. By "addressed" I mean I'd like to see the author go through and click "Done" button on every one of them.

I don't seem to be able to get this to work. the predicate gerrit:unresolved_comments_count(U) seems to always set U to 0.  Searching this forum brings up a discussion from 2013/2014 only that indicates this was not implemented at the time. 

1. Do I misunderstand the concept of "unresolved comment" here"?

2. Is there a way to do what I'm after - implement a rules.pl predicate to block submit until all the comments are addressed? 

Thanks!

Leon

[Edwin Kempin]

Resolvable comments exist since 2.14 [1].

It's an explicit checkbox on the inline comments (only supported by PolyGerrit).

Using the 'Done" button sets this checkbox automatically.

[1] https://gerrit-review.googlesource.com/c/gerrit/+/92792

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.