Maxime joined Gerrit@Google as an intern

[Patrick Hiesel]

Hi everyone,

please welcome Maxime Guerreiro who just joined the Google team working on Gerrit Code Review as a software engineering intern last week. He is really into open-source software (his GitHub profile rocks!) and is excited about improving Gerrit.

Maxime will stay for about six months and will be working mostly on open-source features of Gerrit around the submittability of changes.

He will spend the first weeks of his internship on factoring out an interface so that plugins can hook into Gerrit's submittability checks without creating Prolog facts that users have to factor into their rules.pl. He'll also create a plugin himself that will offer a UI for users to configure what makes a change submittable without touching Prolog.

So please join me in welcoming Maxime to the Gerrit community!

Thanks,

Patrick

[Luca Milanesio]

Welcome Maxime to the Gerrit Code Review project :-)

> On 19 Feb 2018, at 05:33, 'Patrick Hiesel' via Repo and Gerrit Discussion <repo-d...@googlegroups.com> wrote:
>
> Hi everyone,
>
> please welcome Maxime Guerreiro who just joined the Google team working on Gerrit Code Review as a software engineering intern last week. He is really into open-source software (his GitHub profile rocks!) and is excited about improving Gerrit.
> Maxime will stay for about six months and will be working mostly on open-source features of Gerrit around the submittability of changes.

Never say never ... I recall another "intern" that stayed a bit more than six months :-)

>
> He will spend the first weeks of his internship on factoring out an interface so that plugins can hook into Gerrit's submittability checks without creating Prolog facts that users have to factor into their rules.pl.

This *IS REALLY COOL*, almost *ALL* the Gerrit admins that I know of have dreamed about having a different way to define submit rules.
Having this as a mechanism available for plugins, including scripting plugins, would allow any Gerrit admin to use the his language of choice for defining rules.

> He'll also create a plugin himself that will offer a UI for users to configure what makes a change submittable without touching Prolog.

Sweet, so it could both be a sample of how to use the new plugin interface *AND* an out-of-the-box feature in Gerrit.
I believe it should be targeted as core-plugin ;-)

>
> So please join me in welcoming Maxime to the Gerrit community!

+1

Luca.

>
> Thanks,
> Patrick
>
> --
> --
> To unsubscribe, email repo-discuss...@googlegroups.com
> More info at http://groups.google.com/group/repo-discuss?hl=en
>
> ---
> You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

[Duft Markus]

Yay!

Can we have it... like now? :D

Looking forward to see this happening! Ah, and: welcome! :)

Cheers,
Markus

SSI Schäfer IT Solutions GmbH | Friesachstrasse 15 | 8114 Friesach | Austria
Registered Office: Friesach | Commercial Register: 49324 K | VAT no. ATU28654300
Commercial Court: Landesgericht für Zivilrechtssachen Graz

[thomasmu...@yahoo.com]

Does that mean we can give users c+2 but only allow them to merge it if it touches a specific file (all without using prolog)?

[Patrick Hiesel]

That means you could write a Plugin based on the new interface that would add this capability and you/your users would not have to ever touch Prolog.

Maxime will most likely also build a plugin that will let users specify submit rules in a language that is easier to write than Prolog, so in the end you might not even have to write a plugin for this. But I don't want to spoiler too much at this point :)

It is really nice to see that you are all excited about this project - so am I :)

--

[thomasmu...@yahoo.com]

This would be wmf can use the reviewers plugin and get rid of our mw page https://www.mediawiki.org/wiki/Git/Reviewers

On Monday, February 19, 2018 at 1:33:33 PM UTC, Patrick Hiesel wrote:

[Patrick Hiesel]

Yes, that will certainly work with the new interface.

Note that this is currently also possible with a plugin that provides a custom Prolog fact (find-owners): https://gerrit.googlesource.com/plugins/find-owners

It requires you to add OWNERS files to your Git repo though and you would need to add the provided Prolog fact to your rules.pl.

The new interface will make this more extensible/easier to approach.

--

[Matthias Sohn]

On Mon, Feb 19, 2018 at 2:39 PM, Luca Milanesio <luca.mi...@gmail.com> wrote:

Welcome Maxime to the Gerrit Code Review project :-)

> On 19 Feb 2018, at 05:33, 'Patrick Hiesel' via Repo and Gerrit Discussion <repo-d...@googlegroups.com> wrote:
>
> Hi everyone,
>
> please welcome Maxime Guerreiro who just joined the Google team working on Gerrit Code Review as a software engineering intern last week. He is really into open-source software (his GitHub profile rocks!) and is excited about improving Gerrit.
> Maxime will stay for about six months and will be working mostly on open-source features of Gerrit around the submittability of changes.

Never say never ... I recall another "intern" that stayed a bit more than six months :-)

>
> He will spend the first weeks of his internship on factoring out an interface so that plugins can hook into Gerrit's submittability checks without creating Prolog facts that users have to factor into their rules.pl.

This *IS REALLY COOL*, almost *ALL* the Gerrit admins that I know of have dreamed about having a different way to define submit rules.
Having this as a mechanism available for plugins, including scripting plugins, would allow any Gerrit admin to use the his language of choice for defining rules.

> He'll also create a plugin himself that will offer a UI for users to configure what makes a change submittable without touching Prolog.

Sweet, so it could both be a sample of how to use the new plugin interface *AND* an out-of-the-box feature in Gerrit.
I believe it should be targeted as core-plugin ;-)

>
> So please join me in welcoming Maxime to the Gerrit community!

+1

nice, welcome Maxime

-Matthias 

[Luca Milanesio]

On 19 Feb 2018, at 09:23, 'Patrick Hiesel' via Repo and Gerrit Discussion <repo-d...@googlegroups.com> wrote:

Yes, that will certainly work with the new interface.

Note that this is currently also possible with a plugin that provides a custom Prolog fact (find-owners): https://gerrit.googlesource.com/plugins/find-owners

Or use the owners plugin:

https://gerrit.googlesource.com/plugins/owners

:-)

[thomasmu...@yahoo.com]

We won't be using prolog @ wmf. So we will be looking forward to using the new plugin that Maxime will be creating :).

(Also welcome Maxime too) :)

On Monday, February 19, 2018 at 1:33:33 PM UTC, Patrick Hiesel wrote: