Execution of Runnables in Dispatcher

[Luciano Leggieri]

In RingBufferDispatcher (and similarly in WorkQueueDispatcher), there is the following code:

public void execute(final Runnable command) {

ringBuffer.publishEvent(new EventTranslator<RingBufferTask>() {

@Override

public void translateTo(RingBufferTask event, long sequence) {

command.run();

}

});

}

debugging it, I realized that command.run() is executed in the calling thread (so, it's synchronous). This is because publishEvent calls transtateTo.

I was wondering if this is the expected behaviour. Shouldn't it be something like executor.execute(command), or executor.submit(command)?

Cheers!

[Jon Brisbin]

Thanks for the catch! :)

I'm pushing a fix right now (well, the tests are running at the moment :) and am preparing to do an RC1 release so this fix should show up in that.

Thanks!

Jon Brisbin | Reactor Project Lead

http://about.me/jbrisbin | @j_brisbin

--
You received this message because you are subscribed to the Google Groups "reactor-framework" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reactor-framew...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Luciano Leggieri]

Thanks to you! Also, if Reactor-Spring targets Spring 4, could you make AbstractAsyncTaskExecutor extend AsyncListenableTaskExecutor instead of just AsyncTaskExecutor ? :)

[Jon Brisbin]

FYI I just released reactor-spring-core 1.1.0.RC1. TaskExecutors are now AsyncListenableTaskExecutors.

1.1.0.RELEASE is planned for sometime Tuesday.

Thanks!

Jon Brisbin | Reactor Project Lead

http://about.me/jbrisbin | @j_brisbin

[Luciano Leggieri]

Thank you. I've already updated my project to 1.1.0.RELEASE :-)