Inserting objects with null values causes NullPointerException

[ra.ra...@gmail.com]

Please see the test case written here. If confirmed I will will publish as an issue on GitHub repo.

https://github.com/xolve/ReactiveMongo/blob/objectsWithNull/driver/src/test/scala/InsertObjectWithNull.scala

I think that BSONDocument doesn't allow null in document. When lazy reading values later from its internal stream while insert will cause NullPointerException. NPE also happens when calling BSONDocument.pretty() on such a document.

The fix should be that such Writer should convert these Java's null to either scala's None or BSONull.

[Cédric Chantepie]

In anyway, using null is a bad practice.

[ra.ra...@gmail.com]

Agreed! While scala lives in JVM system, null's will be there and many users have identified they get random NullPointerException when using reactivemongo. The exception thrown quite later doesn't help at all. I have following solutions in mind:

1. Give users message that NullPointerException is caused by which field being null. This is at least more helpful than current message.

2. BSON writers should handle null to BSONull or None.

Lemme know if you are accepting patches for same.

[Cédric Chantepie]

Fixing Option.get call inside handler (getAs.get) is not the responsibility of the driver for me.

Such practice, whatever is the Option producer as not specific to the driver, swallow the error cause.

If the field is not optional rather use/compose using getAsTry .