Shapeless dependency

[João Ferreira]

Hi

I recently migrated from 0.11. to 0.12 and noticed that a shapeless dependency was introduced. Having a look at the build history this seems the offending commit https://github.com/ReactiveMongo/ReactiveMongo/commit/13a2c9dcb5481f3c8af53ec9df4d8d52f16ba29d (shapeless previously was only a test dependency)

Per the reporting guidelines I opened a discussion first but I can open a PR later...

Thanks for this nice project

Regards

Joao

[Cédric Chantepie]

Shapeless is used only for the tests for now. The dependency scope be restricted accordingly.

In case of version conflict for this dependency, it can be excluded from the driver dependency.

[João Ferreira]

I understand you want to use shapeless for tests only, however I think there is an error in the build file.

In https://github.com/ReactiveMongo/ReactiveMongo/blob/master/project/ReactiveMongo.scala#L408 the project "bsonmacros" uses shapelessTest % Test. However in https://github.com/ReactiveMongo/ReactiveMongo/blob/master/project/ReactiveMongo.scala#L467 shapelessTest is used without the Test modifier.

Also in https://mvnrepository.com/artifact/org.reactivemongo/reactivemongo_2.11/0.12.6 shapeless is reported as a dependency

A possible fix is in here https://github.com/jtjeferreira/ReactiveMongo/commit/bde6dfce46734dcd6361fdbf2d491458d5432ce3

Cheers

Joao

2017-09-24 11:35 GMT+01:00 Cédric Chantepie <chantep...@gmail.com>:

Shapeless is used only for the tests for now. The dependency scope be restricted accordingly.

In case of version conflict for this dependency, it can be excluded from the driver dependency.

--
You received this message because you are subscribed to a topic in the Google Groups "ReactiveMongo - http://reactivemongo.org" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/reactivemongo/ACVTgsUFkKk/unsubscribe.
To unsubscribe from this group and all its topics, send an email to reactivemongo+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[João Ferreira]

Thanks for fixing this