LoadAsync with hierarchical Include returns null

[Denis Martinho]

From SO : http://stackoverflow.com/questions/40785126/ravendb-loadasync-with-include-returns-null

Hi ! 

Here the SO post : 

I was adding some async calls in my project when i've encountered a problem. The same call between Session and AsyncSession doesn't return my document.
Here the document : 

class Company {
    string Id;
    string Name;
    BusinessUnit BusinessUnit;
} 

class BusinessUnit {
    string Name;
    List<BusinessUnit> BusinessUnits;
    List<Employee> Employees;
} 

class Employee {
    string Position;
    string UserId;
} 

class User {
    string Id;
    string FullName;
} 

User and Company are two collections in my RavenDb. As you can see, we have a tree of business unit in our document Company. So when i want to load a Company, i make this call : 

var company = Session.Include<Employee, User>(x => x.UserId).Load<Company>(companyId); //Working like a charm 

But when i tried to do the same with Async : 

var company = await AsyncSession.Include<Employee, User>(x => x.UserId).LoadAsync<Company>(companyId); //company is null
var company = await AsyncSession.LoadAsync<Company>(companyId); //This is working 

I can't see why it isn't working.
During my searching of answers, i've found a small difference between the implementation of MultiLoaderWithInclude and AsyncMultiLoaderWithInclude. I don't know if my issue can be resolved by these classes.

----------------

Ayende asks for an unit test, you will find one in attachment.

About the versions i was using ravendb 3.5.1 dlls with server build #35179

Thanks for any help :)

Denis

 

[Oren Eini (Ayende Rahien)]

Thanks for the test, I can confirm the issue.

We'll fix it in the next release, but in the meantime, the root cause is that you are using fields, if you'll use properties, this would work properly.

Hibernating Rhinos Ltd  

Oren Eini l CEO l Mobile: + 972-52-548-6969

Office: +972-4-622-7811 l Fax: +972-153-4-622-7811

 

--
You received this message because you are subscribed to the Google Groups "RavenDB - 2nd generation document database" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ravendb+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Denis Martinho]

Yep i fixed that. Thanks !

I found another issue : you will find a test in attachment.

This time when i try to use LoadAsync with Includes, the document is not returned when i use the ValueType implementation. But the LoadAsync without includes is working.

To unsubscribe from this group and stop receiving emails from it, send an email to ravendb+u...@googlegroups.com.

[Grisha Kotler]

var returnedCompany = await asyncSession.Include<Company, User>(x => x.BusinessUnit.Employees.Select(y => y.UserId)).LoadAsync<Company>(companyShortId);

Hibernating Rhinos Ltd  

Grisha Kotler l RavenDB Core Team Developer l Mobile: +972-54-586-8647

Office: +972-4-622-7811 l Fax: +972-153-4-622-7811

RavenDB paving the way to "Data Made Simple" http://ravendb.net/

To unsubscribe from this group and stop receiving emails from it, send an email to ravendb+unsubscribe@googlegroups.com.

[Oren Eini (Ayende Rahien)]

The issue is that you are doing something very strange:

  var returnedCompany = await asyncSession.Include<Employee, User>(x => x.UserId)

                        .LoadAsync<Company>(companyShortId); //fails  

We are actually trying to load "employees/1" here, not "companies/1", but without that issue (which is fixed), you are doing something broken, I think Grisha's suggestion is better.

To unsubscribe from this group and stop receiving emails from it, send an email to ravendb+unsubscribe@googlegroups.com.

[Denis Martinho]

I understand Grisha's suggestion but there is something missing : I have a tree of BusinessUnit.

For example i can have a tree like that : 

Company

|

|- BusinessUnit 1

|  |- BusinessUnit 1.1

|  |- BusininessUnit 1.2

|

|- BusinessUnit 2

  |- BusinessUnit 2.1

  |- BusinessUnit 2.2

     |- BusinessUnit 2.2.1

Etc. Etc.

With Grisha's suggestion i will only have the employees of BusinessUnit 1 and 2 and not their child.

[Oren Eini (Ayende Rahien)]

You can use Include with Recurse inside a transformer, then:

http://ravendb.net/docs/article-page/3.5/csharp/transformers/transforming-hierarchical-data

But note that this is probably a strange model.

Have the employees of the company as a collection, then have them reference the internal business unit they are on.

To unsubscribe from this group and stop receiving emails from it, send an email to ravendb+unsubscribe@googlegroups.com.

[Denis Martinho]

It's because i'm not giving you our class names in the test, so it's maybe a little odd. Sorry ! ^^'

In fact, i want to load a Company then i will load the Users in each BusinessUnit's Employee list that is why i need to include recursively them. 

Do you mean "collection" like : a document collection or a list of employee in company ? 

In any case, i have to set an id to BusinessUnit, right ? 

By the way, i saw the Ayende's commit about the ValueType on LoadAsync. Thanks ! 

[Oren Eini (Ayende Rahien)]

I meant a list inside the document, yes.

Hibernating Rhinos Ltd  

Oren Eini l CEO l Mobile: + 972-52-548-6969

Office: +972-4-622-7811 l Fax: +972-153-4-622-7811

 

--