SQL replication setting drop down list problem

[Yanjie Zhou]

Hi, 

I have a problem on the page Setting/SqlReplication. The drop down list "Edit Replication" for all SQL replication exist in the system can at most show me the first 25 SQL replication in the DB,although the rest of them still functional but I can't directly edit them on the setting page, could you please help to deal with this problem? Thank you.

Yanjie Zhou

[Oren Eini (Ayende Rahien)]

Can you show a screen shot? I'm not sure that I'm following the issue.

Hibernating Rhinos Ltd  

Oren Eini l CEO l Mobile: + 972-52-548-6969

Office: +972-4-622-7811 l Fax: +972-153-4-622-7811

 

--
You received this message because you are subscribed to the Google Groups "RavenDB - 2nd generation document database" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ravendb+u...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Yanjie Zhou]

Here is the screen shot, the drop down only shows me the SQL replication from beginning letter "A" to beginning letter "P", but I have many more replication that didn't shows up like beginning letter with "S", that is also in the screen shot.

Do you know what is wrong about it?

Thank you

Yanjie Zhou

[Oren Eini (Ayende Rahien)]

Yes, the issue is in this line:

https://github.com/ravendb/ravendb/blob/master/Raven.Studio/Features/Settings/SqlReplicationSettingsSectionModel.cs#L242

Fixed in the next unstable build for 2.5

[Yanjie Zhou]

Thank you, 

After changed that line of code, I find another problem:

If I make some modifications on one SQL replication code and save it, a small window will shows up. If click the check box and click ok, that sql replication will run and replicate data again(Please see the attached picture).

But some of the replications in the bottom of the Edit Replication drop down list, this small window will not show up when I changed and re-save the replication code. Additionally, those save will not trigger the replication run again.

Could you please help to deal with this problem? 

Thank you

Yanjie Zhou

[Oren Eini (Ayende Rahien)]

You can reset this manually by editing the Raven/SqlReplication/Status document directly.

[Yanjie Zhou]

Thank you.

Another problem I found today, please see the attached document, this is happen when I creating the SQL replication, do you have any ideas about it?

Thanks

Yanjie Zhou

[Oren Eini (Ayende Rahien)]

No, never seen this before. How did you reproduce this?

[Yanjie Zhou]

It happen when I want to write more SQL replications into Raven DB and when I click save changes, it happens. Now it also happens when I want to make changes to the SQL replication that already exist.

Thank you

Yanjie Zhou

[Oren Eini (Ayende Rahien)]

Can you send us a copy of your db?

[Yanjie Zhou]

You want the Ravendb.dll?

Thank you

Yanjie Zhou

[Oren Eini (Ayende Rahien)]

No, your replication docs

[Yanjie Zhou]

it seems related to the change that fixed the list of SQLReplication (was 25, now is 512). Since this change, it has this error if the changed item beyond the position of 30. It seems the code to save the changed script has some loop that caused this issue.

Thanks

[James Tan]

Seems the code line 207 of Raven.Studio.Commands.SaveSettingsCommand has issue, which loops all configs and load by ID.

foreach (var sqlReplicationConfig in sqlReplicationSettings.SqlReplicationConfigs)

{

var id = "Raven/SqlReplication/Configuration/" + sqlReplicationConfig.Name;

var config = await session.LoadAsync<SqlReplicationConfig>(id);

config  = UpdateConfig(config, sqlReplicationConfig);

session.Store(config);

[Oren Eini (Ayende Rahien)]

Thanks, fixed and issued a new unstable build.