I've messed up another pull-request ...

[Stacey]

On pull request https://github.com/ayende/ravendb/pull/3762, I'm not sure what the error it is giving me is: "commit/message/conventions"

I thought this was related to having a reference to an issue in the YouTrack, isn't it? Which I did.

I'm also very uncertain how to go about with the tests failing. I only changed the Html studio, so there's no reason the tests should be failing like that.

I couldn't find any documentation that was clear about pull-request conventions and the like. Is it posted somewhere and I've just missed it?

[Oren Eini (Ayende Rahien)]

The RavenDB-4648 should be in the commit messages, not just in the PR description.

Hibernating Rhinos Ltd  

Oren Eini l CEO l Mobile: + 972-52-548-6969

Office: +972-4-622-7811 l Fax: +972-153-4-622-7811

 

--
You received this message because you are subscribed to the Google Groups "RavenDB - 2nd generation document database" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ravendb+u...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Stacey Thornton]

So what can I do? I can’t go back and edit the commit messages.

--
You received this message because you are subscribed to a topic in the Google Groups "RavenDB - 2nd generation document database" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/ravendb/Tm7jBnlA0K4/unsubscribe.
To unsubscribe from this group and all its topics, send an email to ravendb+u...@googlegroups.com.

[Oren Eini (Ayende Rahien)]

Of course you can: https://help.github.com/articles/changing-a-commit-message/

[Oren Eini (Ayende Rahien)]

At any rate, we're reviewing the PR now

[Stacey Thornton]

Thank you. I think I got it done.