Request property is always null

[jo...@thesimonshouse.com]

This code has a bug:

https://github.com/ravendb/ravendb/blob/ca822bdfd0c2b2c0a7dc46807776bd3dd3b580c6/Raven.Client.Lightweight/Connection/Implementation/HttpJsonRequestFactory.cs#L100

You need to use the conditional directive (#if !DNXCORE50) to also populate the Request property.

Easy to repro:

documentStore.JsonRequestFactory.ConfigureRequest += (sender, args) =>

            {

                args.Request.Proxy = new WebProxy(new Uri("http://localhost:8889"), false);

            };

This is in v3.0

Cheers

John

[Oren Eini (Ayende Rahien)]

That isn't a bug, you are expected to use the Client in 3.0

Hibernating Rhinos Ltd  

Oren Eini l CEO l Mobile: + 972-52-548-6969

Office: +972-4-622-7811 l Fax: +972-153-4-622-7811

 

--
You received this message because you are subscribed to the Google Groups "RavenDB - 2nd generation document database" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ravendb+u...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[John Simons]

So how do u set the proxy via the client?

You received this message because you are subscribed to a topic in the Google Groups "RavenDB - 2nd generation document database" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/ravendb/DtQk1h6tdEo/unsubscribe.
To unsubscribe from this group and all its topics, send an email to ravendb+u...@googlegroups.com.

[Oren Eini (Ayende Rahien)]

var httpClientHandler = new HttpClientHandler
                        {
                            Proxy = new WebProxy("http://localhost:8888", false),
                            UseProxy = true
                        }

[John Simons]

I may be looking at this wrong but I can't see a way to replace the handler on the HttpClient instance, and I don't think u saying to replace the whole Client? Actually I don't think that would work anyway.

[jo...@thesimonshouse.com]

So I have tried:

documentStore.JsonRequestFactory.ConfigureRequest += (sender, args) =>

            {

                args.Client = new HttpClient(new HttpClientHandler

                {

                    UseDefaultCredentials = true,

                    Credentials = CredentialCache.DefaultNetworkCredentials,

                    Proxy = new WebProxy(new Uri("http://localhost:8888/"), false),

                    UseProxy = true,

                });

            };

But it doesn't work, because args.Client is ignored.

Any other ideas ?

[Maxim Buryak]

Hi, 

Please try attached example, note that local addresses/proxies won't be supported

 using (var store = new DocumentStore

                {

                    Url = RAVEN_URL,               

                    DefaultDatabase = store.DefaultDatabase,

                    HttpMessageHandlerFactory = () =>

                    new HttpClientHandler

                    {

                        UseDefaultCredentials = true,

                        Credentials = CredentialCache.DefaultNetworkCredentials,

                        Proxy = new WebProxy(new Uri(PROXY_ADDRESS), false),

                        UseProxy = true,

                    }

                })

Best Regards,

Hibernating Rhinos Ltd  

Maxim Buryak l Core Team Developer l Mobile:+972-54-217-7751

Office: +972-4-622-7811 l Fax: +972-153-4-622-7811

RavenDB paving the way to "Data Made Simple" http://ravendb.net/  

[Maxim Buryak]

* local addresses won't be supported, local proxis are just fine

Best Regards,

Hibernating Rhinos Ltd  

Maxim Buryak l Core Team Developer l Mobile:+972-54-217-7751

Office: +972-4-622-7811 l Fax: +972-153-4-622-7811

RavenDB paving the way to "Data Made Simple" http://ravendb.net/