setLockMode() error on JPAUpdateClause with Hibernate 4.3.8

[Michael Tontchev]

I am trying to run

JPAUpdateClause query = new JPAUpdateClause(em, user);

query.set(user.name, "test").setLockMode(LockModeType.PESSIMISTIC_WRITE);

 

However, when I execute this, I get

java.lang.IllegalStateException: Illegal attempt to set lock mode on a non-SELECT query

thrown by org.hibernate.jpa.spi.AbstractQueryImpl.setLockMode(AbstractQueryImpl.java:129)

I'm using Hibernate 4.3.8. Do you think this is a Hibernate bug? There appears to have been a similar bug in 4.3.0, but it was allegedly fixed in 4.3.1.

Thanks!

[timowest]

Hi.

This looks like a Hibernate bug. At least no something tht should be controlled on the Queryds level.

Timo

[Michael Tontchev]

Okay. I'm looking at the major JPA providers, and every single one besides OpenJPA restricts setLockMode() to only work for select queries:

Hibernate: http://grepcode.com/file/repo1.maven.org/maven2/org.hibernate/hibernate-entitymanager/4.3.8.Final/org/hibernate/jpa/spi/AbstractQueryImpl.java#AbstractQueryImpl.setLockMode%28javax.persistence.LockModeType%29

EclipseLink: http://grepcode.com/file/repo1.maven.org/maven2/org.eclipse.persistence/eclipselink/2.6.0-RC1/org/eclipse/persistence/internal/jpa/QueryImpl.java#QueryImpl.setLockMode%28javax.persistence.LockModeType%29

Data Nucleus: http://grepcode.com/file/repo1.maven.org/maven2/org.datanucleus/datanucleus-api-jpa/4.0.6/org/datanucleus/api/jpa/JPAQuery.java#JPAQuery.setLockMode%28javax.persistence.LockModeType%29

In fact, it seems like javax itself specifies that

Throws: IllegalStateException - if the query is found not to be a Java Persistence query language SELECT query or a Criteria API query

Am I reading this wrong, or is JPA not supposed to allow lock modes on update queries?

[Michael Tontchev]

Bump. Are you sure JPA allows lock modes on update/delete clauses?

[timowest]

Looks like you are right. Could you create an issue for it?

[Michael Tontchev]

Done!