Re: Pull request for domain widget

Marek Marczykowski-Górecki

unread,

Jun 15, 2019, 8:00:50 PM6/15/19

to airele...@tutanota.com, qubes-devel

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On Fri, Jun 14, 2019 at 11:38:19PM +0200, airele...@tutanota.com wrote:
> Hi Marek,
>
> Here's the result of `git request-pull` for the domains widget changes.

Thanks!

> My public key F72E63AC was recently uploaded to github and keyserver.ubuntu.com
>
> (I couldn't create a pull request on github, I think because I originally
> cloned qubes-builder instead of using github's fork feature.)

Yes, that's probably the reason. Unfortunately, github doesn't allow to
link such repositories later, the only way is to remove (or rename) and
re-create using their fork function.

> If there is anything wrong with this pull request, let me know and I'll fix it.

I've pushed it to my account, to have Travis run various checks and
pylint complains about few things:
https://travis-ci.com/marmarek/qubes-desktop-linux-manager/builds/115693766

Other than that, looks good!

BTW when sending patches, please cc qubes-devel mailing list.

> - Air Elemental
>
> ----------------------------------------------------------------
> The following changes since commit c2c627e0432523b030b791ebb64b582ff88938f5:
>
> version 4.0.19 (2019-06-05 18:16:55 +0200)
>
> are available in the Git repository at:
>
> https://github.com/airelemental/qubes-desktop-linux-manager.git <https://github.com/airelemental/qubes-desktop-linux-manager.git> tags/pullme
>
> for you to fetch changes up to 59915344c0cd613e82252058145d26c0de01132f:
>
> revert arbitrary version string (2019-06-12 17:43:18 -0700)
>
> ----------------------------------------------------------------
> concise cpu usage and headers
>
> ----------------------------------------------------------------
> Air Elemental (8):
>       Move cpu percentage text to the left of the bar
>       fix double-digit cpu percentage interfering with memory display
>       headers; hide 0% cpu
>       show headers using update_state(), instead of as initial value
>       don't show submenu for header; rename memory header
>       whitespace fixes, better description
>       remove unused code
>       revert arbitrary version string
>
> qui/decorators.py   | 39 ++++++++++++++++++++++++++-------------
> qui/tray/domains.py | 49 ++++++++++++++++++-------------------------------
> 2 files changed, 44 insertions(+), 44 deletions(-)
>

- --
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAl0FhqkACgkQ24/THMrX
1yxNdQf/d83W0VLVfDRMkT5kMeN12pqGVsRPBQythiRBpVXh18v9KKb/41O128Wo
gZd4ryMbjhx88OCYQYuKtKTizHKv+kB9hqcmQ3VTWZh9IczN//lg25cjhfNx7mnj
sG7Vw8CxkgSO31INDTwFHIxq7gHvuxH22L1PqWsgZ880A4lWc9HHGPn/XG/vtqOe
pGTc3dLzZhXL0uXrxoRsAXNguxPXVG2jm4wEjQBjgFRYoq597IiF+01z9s5RycdI
fc8a0WjmFN3bgwyMOSXHqQAX6Sbg5kpNjP0ehcZ6/3AaAQOGYspWjmgaPnr3KGzD
08rcvoutoPm9foY7r/KvoQ7vb7bR9w==
=KjNV
-----END PGP SIGNATURE-----

airele...@tutanota.com

unread,

Jun 16, 2019, 2:37:11 AM6/16/19

to qubes...@googlegroups.com

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Should fix all the pylint issues.

- ----------------------------------------------------------------

The following changes since commit c2c627e0432523b030b791ebb64b582ff88938f5:

version 4.0.19 (2019-06-05 18:16:55 +0200)

are available in the Git repository at:

https://github.com/airelemental/qubes-desktop-linux-manager.git <https://github.com/airelemental/qubes-desktop-linux-manager.git> tags/pullme2

for you to fetch changes up to 971d5dd24ba1ab71d2638d182ac37a4f51ea87d1:

fix trailing whitespace, unused imports (2019-06-15 21:15:01 -0700)

- ----------------------------------------------------------------

concise cpu usage and headers

- ----------------------------------------------------------------
Air Elemental (9):

      Move cpu percentage text to the left of the bar
      fix double-digit cpu percentage interfering with memory display
      headers; hide 0% cpu
      show headers using update_state(), instead of as initial value
      don't show submenu for header; rename memory header
      whitespace fixes, better description
      remove unused code
      revert arbitrary version string

fix trailing whitespace, unused imports

qui/decorators.py | 38 +++++++++++++++++++++++++-------------
qui/tray/domains.py | 50 +++++++++++++++++++-------------------------------

2 files changed, 44 insertions(+), 44 deletions(-)

Marek Marczykowski-Górecki

unread,

Jun 16, 2019, 12:52:07 PM6/16/19

to airele...@tutanota.com, qubes...@googlegroups.com

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On Sun, Jun 16, 2019 at 08:37:08AM +0200, airele...@tutanota.com wrote:
> Should fix all the pylint issues.

Now it's good, thanks!
Merged to master.

- --
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAl0Gc68ACgkQ24/THMrX
1ywzuAf+K02oB9epq4HBGOCQ4jhhJIm55Z8ANqEBPaKGYUgY8l9rL/LX0Ht3Qlg2
97EUN04ZkLQXTOUayITB5W0TwiBbTCVCxv556d1qMgsG5SFplAcB3Sfze5hhFzHl
bVl+BNi2CG4tRjV4sRgGFza4qTh9KsPpXNTRWYbfZ7/wOdudqFJyVIF4QLVjCD7p
pxrYOLSIakq5N1AprEGOUjP+O/Xhu8lnMPeCDIZZp9cijccOrVkilV9DX4HlrWOT
rKh9UfpLf2bp07RZd2SCTPHnhN6bOsAY2kYuFu0owmD61wupT//nX1HjtI/xjQf2
Fk819yfRrUtSCzPkisPyZo/P3HsmTA==
=R4gT
-----END PGP SIGNATURE-----

Reply all

Reply to author

Forward