patches for Kernel 4.14.57-1 and 4.14.57-2 compilation fail due to 'get_identifier_with_length'

[Marcus Linsner]

In file included from /home/user/qubes-linux-kernel/kernel-4.14.57/linux-4.14.57/scripts/gcc-plugins/gcc-common.h:101,
from <stdin>:1:
/usr/lib/gcc/x86_64-redhat-linux/8/plugin/include/attribs.h: In function 'tree_node* canonicalize_attr_name(tree)':
/usr/lib/gcc/x86_64-redhat-linux/8/plugin/include/attribs.h:118:12: error: 'get_identifier_with_length' was not declared in this scope
return get_identifier_with_length (s + 2, l - 4);
^~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/lib/gcc/x86_64-redhat-linux/8/plugin/include/attribs.h:118:12: note: suggested alternative: 'get_attr_min_length'
return get_identifier_with_length (s + 2, l - 4);
^~~~~~~~~~~~~~~~~~~~~~~~~~
get_attr_min_length
Cannot use CONFIG_GCC_PLUGINS: your gcc installation does not support plugins, perhaps the necessary headers are missing?
make[2]: *** [scripts/Makefile.gcc-plugins:70: gcc-plugins-check] Error 1
make[2]: Leaving directory '/home/user/qubes-linux-kernel/kernel-4.14.57/linux-obj'
make[1]: *** [Makefile:146: sub-make] Error 2
make[1]: Leaving directory '/home/user/qubes-linux-kernel/kernel-4.14.57/linux-4.14.57'
error: Bad exit status from /var/tmp/rpm-tmp.1wmTem (%prep)

I found(and tested) the patches required to fix this, they are directly downloadable from github:
https://github.com/torvalds/linux/commit/b86729109c5fd0a480300f40608aac68764b5adf.patch
https://github.com/torvalds/linux/commit/80d172431696482d9acd8d2c4ea78fed8956e2a1.patch

or can be seen on the kernel website:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b86729109c5fd0a480300f40608aac68764b5adf
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=80d172431696482d9acd8d2c4ea78fed8956e2a1

Related reports(without solution) via google search:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=904379
https://lists.gnu.org/archive/html/gm2/2017-11/msg00000.html

I've no idea how you guys got to compile this, I was using the v4.14.57-2 tag and 'make rpms'. Oh,... maybe using gcc 7 not 8?

[Marcus Linsner]

On Wednesday, August 22, 2018 at 8:56:03 PM UTC+2, Marcus Linsner wrote:
> In file included from /home/user/qubes-linux-kernel/kernel-4.14.57/linux-4.14.57/scripts/gcc-plugins/gcc-common.h:101,
> from <stdin>:1:
> /usr/lib/gcc/x86_64-redhat-linux/8/plugin/include/attribs.h: In function 'tree_node* canonicalize_attr_name(tree)':
> /usr/lib/gcc/x86_64-redhat-linux/8/plugin/include/attribs.h:118:12: error: 'get_identifier_with_length' was not declared in this scope
> return get_identifier_with_length (s + 2, l - 4);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~
> /usr/lib/gcc/x86_64-redhat-linux/8/plugin/include/attribs.h:118:12: note: suggested alternative: 'get_attr_min_length'
> return get_identifier_with_length (s + 2, l - 4);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~
> get_attr_min_length
> Cannot use CONFIG_GCC_PLUGINS: your gcc installation does not support plugins, perhaps the necessary headers are missing?
> make[2]: *** [scripts/Makefile.gcc-plugins:70: gcc-plugins-check] Error 1
> make[2]: Leaving directory '/home/user/qubes-linux-kernel/kernel-4.14.57/linux-obj'
> make[1]: *** [Makefile:146: sub-make] Error 2
> make[1]: Leaving directory '/home/user/qubes-linux-kernel/kernel-4.14.57/linux-4.14.57'
> error: Bad exit status from /var/tmp/rpm-tmp.1wmTem (%prep)
>
>
>
> I found(and tested) the patches required to fix this, they are directly downloadable from github:

[1] > https://github.com/torvalds/linux/commit/b86729109c5fd0a480300f40608aac68764b5adf.patch
[2] > https://github.com/torvalds/linux/commit/80d172431696482d9acd8d2c4ea78fed8956e2a1.patch

>
> or can be seen on the kernel website:

[1] > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b86729109c5fd0a480300f40608aac68764b5adf
[2] > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=80d172431696482d9acd8d2c4ea78fed8956e2a1

>
> Related reports(without solution) via google search:
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=904379
> https://lists.gnu.org/archive/html/gm2/2017-11/msg00000.html
>
>
> I've no idea how you guys got to compile this, I was using the v4.14.57-2 tag and 'make rpms'. Oh,... maybe using gcc 7 not 8?

In case anyone's wondering why the [1] patch is also needed, it is to avoid the following error which results from applying only the [2] patch:
HOSTCXX -fPIC scripts/gcc-plugins/latent_entropy_plugin.o
/home/user/qubes-linux-kernel/kernel-4.14.57/linux-4.14.57/scripts/gcc-plugins/latent_entropy_plugin.c:269:1: error: designator order for field 'attribute_spec::affects_type_identity' does not match declaration order in 'attribute_spec'
};
^
make[3]: *** [scripts/Makefile.host:153: scripts/gcc-plugins/latent_entropy_plugin.o] Error 1
make[2]: *** [scripts/Makefile.gcc-plugins:83: gcc-plugins] Error 2

make[2]: Leaving directory '/home/user/qubes-linux-kernel/kernel-4.14.57/linux-obj'
make[1]: *** [Makefile:146: sub-make] Error 2
make[1]: Leaving directory '/home/user/qubes-linux-kernel/kernel-4.14.57/linux-4.14.57'

error: Bad exit status from /var/tmp/rpm-tmp.TN1Ycw (%prep)

[Marek Marczykowski-Górecki]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

In the meantime we have 4.14.67, does the problem still happen there?

- --
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAluNLC8ACgkQ24/THMrX
1yxMPQf/W/wNuMBRaqYoybNcCVFRIA8g+ByddAT3XUZhWAPV4eYgMt+XbTfXmeJe
27ao2Ela90CyytP2nP2sSCGFotrppWjfMySJcRD0D0UnGhrvVf8p62gDIIgeUbzV
flk+UK0lzBQYkqPnRB/ViaXacYzU5yr6IvEyjrQOUBoAW6j4RhhICbRqCnMtWrkk
E5NFS3QdyL13sfhRZGPdkDOlPQSS3S/Z2lW3xsovdR6VkjaWU674k/GtcWePh7CU
HBBSNwqu47FoFcHGwXWNzop3LFBFlefJLNGIruexmwuB3mEUeeEVe7+D4eQqdTBS
1/BvlGJjhYaX07F1e2wdUH5xyK1aVw==
=MWwl
-----END PGP SIGNATURE-----