possible BUG in qubes-builder/qubes-src/builder-rpm/prepare-chroot-base ?

[audiom...@gmail.com]

Shouldn't line 179 contain an || instead of &&?

179 echo "${result_status}" | grep -q "$PGP_NOTSIGNED" && {
180 echo "Filename: ${file} is not signed. Exiting!"
181 exit 1
182 }

[C J du Preez]

If $PGP_NOTSIGNED contains a string that indicates the file is not
signed, the grep -q will return true if that string is in the
${result_status} output. This will result in the { } clause after the &&
triggering, which seems correct to me.

[audiom...@gmail.com]

Am Sonntag, 3. Juni 2018 23:01:51 UTC+2 schrieb C J du Preez:

Sorry, my bad. The question should have been:
Shouldn't line 179 contain an && instead of ||?
Line 179 is the already corrected version.

[Marek Marczykowski-Górecki]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

The current version (with ||) is correct, PGP_NOTSIGNED variable name is
misleading. The test is against packages being not signed at all
(hence the name), but PGP_NOTSIGNED contains the pattern expected on
signed package.

I've changed its name to PGP_SIGNED.

- --
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAlsVoNQACgkQ24/THMrX
1ywRLgf9FTWE4uoRDbqPW6eWfCNc2rN68nlvNRDFMWGy25MK7DgpqCkYXh4znEXG
qRxJMgEsWzyweXgV8kgQGjcwaVC8CJw5COvTe393b8sdUR7E9BYrSrV7xqMiMtBh
UqRfHCP1ARygoP4viCkFk0bRBuogBKJHTt41cK6nd/R00DUNNpVhg4PWrw5cTpmm
CQU3GewjbvZ1S113pvqV8XMelv3CALHdw8NMRdijj5sh83OXXcKNS95e/8aNOPyL
fi5eHXPEqWMtxgo7wxlHwDmJ8vDiBmL11UkzAkWAdfFdKrEOK9WFLnhMmIgJQzX0
6TBNJ4g2b6mwTUDr9g/Wshi7zTdSlQ==
=kNB7
-----END PGP SIGNATURE-----