Trivial change for sampleproject

9 views
Skip to first unread message

Pavlo Kapyshin

unread,
Mar 1, 2017, 8:58:00 AM3/1/17
to pypa-dev
Hello,

I’ve made a trivial pull request to sampleproject (https://github.com/pypa/sampleproject/pull/52), can anyone please review it and merge?

Paul Moore

unread,
Mar 1, 2017, 9:31:59 AM3/1/17
to Pavlo Kapyshin, pypa-dev
It looks good to me. I'd be OK to merge, but the Travis build is
failing (AFAICT because flake8 no longer supports Python 2.6).

@PyPA - are we OK to merge this with the Python 2.6 build failing? I
don't have time right now to fix that (it's only removing 2.6 from the
travis config, unless we actually want to continue requiring 2.6 to
work...)

Paul

Paul Moore

unread,
Mar 1, 2017, 9:33:08 AM3/1/17
to Pavlo Kapyshin, pypa-dev
PS I just noticed I wasn't clear - personally I'd be perfectly OK with
dropping 2.6 support and (when I get the time, possibly this evening)
removing it from Travis.

Donald Stufft

unread,
Mar 1, 2017, 9:35:20 AM3/1/17
to Paul Moore, Pavlo Kapyshin, pypa-dev
Next major version of pip drops 2.6 support anyways. Seems reasonable to drop it here too.


Donald Stufft



Paul Moore

unread,
Mar 1, 2017, 9:37:25 AM3/1/17
to Donald Stufft, Pavlo Kapyshin, pypa-dev
On 1 March 2017 at 14:35, Donald Stufft <don...@stufft.io> wrote:
> Next major version of pip drops 2.6 support anyways. Seems reasonable to
> drop it here too.

OK. Unless I hear "no" from someone in the next few hours, I'll drop
2.6 from the matrix (I may also add 3.5 and 3.6 just for the heck of
it :-)) this evening. I'll commit Pavlo's change then, too.

Thanks,
Paul

Dustin Ingram

unread,
Mar 1, 2017, 9:53:52 AM3/1/17
to Donald Stufft, Paul Moore, Pavlo Kapyshin, pypa-dev
Here's a PR to remove Python 2.6 support:

https://github.com/pypa/sampleproject/pull/51

D.

Paul Moore

unread,
Mar 1, 2017, 10:00:33 AM3/1/17
to Dustin Ingram, Donald Stufft, Pavlo Kapyshin, pypa-dev
On 1 March 2017 at 14:53, Dustin Ingram <dustin...@gmail.com> wrote:
> Here's a PR to remove Python 2.6 support:
>
> https://github.com/pypa/sampleproject/pull/51

Cool, thanks for the pointer. I've checked this and it looks good, so
I've merged both this and Pavlo's change.

Thanks to both of you :-)
Paul
Reply all
Reply to author
Forward
0 new messages